All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Julien Corjon <corjon.j@ecagroup.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency
Date: Sun, 14 Nov 2021 13:28:34 +0100	[thread overview]
Message-ID: <20211114132834.18b7ca20@gmx.net> (raw)
In-Reply-To: <20211114101554.878427-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sun, 14 Nov 2021 11:15:54 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> zstd is an optional dependency which is enabled by default since version
> 5.13.0 and
> https://github.com/qt/qtbase/commit/f25bc30d8d9d13fffd34213dfbf5e7373a18222a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>


--- build/qt5base-5.15.2_orig/config.summary     2021-11-14 00:00:33.698378466 +0100
+++ build/qt5base-5.15.2/config.summary 2021-11-14 13:16:42.818139194 +0100
@@ -30,7 +30,7 @@
   Using pkg-config ....................... yes
   udev ................................... no
   Using system zlib ...................... yes
-  Zstandard support ...................... no
+  Zstandard support ...................... yes


Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter


> ---
>  package/qt5/qt5base/qt5base.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 9da3de468a..b04d710d78 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -116,6 +116,13 @@ else
>  QT5BASE_CONFIGURE_OPTS += -no-cups
>  endif
>
> +ifeq ($(BR2_PACKAGE_ZSTD),y)
> +QT5BASE_DEPENDENCIES += zstd
> +QT5BASE_CONFIGURE_OPTS += -zstd
> +else
> +QT5BASE_CONFIGURE_OPTS += -no-zstd
> +endif
> +
>  # Qt5 SQL Plugins
>  ifeq ($(BR2_PACKAGE_QT5BASE_SQL),y)
>  ifeq ($(BR2_PACKAGE_QT5BASE_MYSQL),y)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-11-14 12:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 10:15 [Buildroot] [PATCH 1/1] package/qt5/qt5base: add zstd optional dependency Fabrice Fontaine
2021-11-14 12:28 ` Peter Seiderer [this message]
2021-11-14 13:35 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211114132834.18b7ca20@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@buildroot.org \
    --cc=corjon.j@ecagroup.com \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.