From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F09F4C433F5 for ; Mon, 15 Nov 2021 11:31:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F65061BC1 for ; Mon, 15 Nov 2021 11:31:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F65061BC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67B416E063; Mon, 15 Nov 2021 11:31:13 +0000 (UTC) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id E09F36E063 for ; Mon, 15 Nov 2021 11:31:12 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 70BEA2B0117B; Mon, 15 Nov 2021 06:31:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 15 Nov 2021 06:31:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:content-type:mime-version :content-transfer-encoding; s=fm1; bh=oEPb279Pc8ICHxOjxF4sDkFL+s /davMGKpI867X6PF8=; b=Zp8ep0hNHQS6Py/AgYK2oGRSuIc8KKJtecqBd+zFCH /UyNSYhI5dA0D4FvPyHofOl/lD0IeKboJox/8/Zk+IuhQxPM34kPlbjKPxliy5hc m8OKUuojBOB7gyw5m49i+U/KCh69KnBartF1y+DSYssDVaI+W1a2Z2JCTVOiWELt 3jPUlOsgPZXXDrSyySs4rzDTFNeHxMy902DVwNBUV6KZpwYkNE3fBm+u/KPr2s0C JRJlqlH4x5ObEbjPM0X26tnDCo/BQkwOamDCh7hxSzI74NZey8wuWNR7IjdfJt37 Dm+7WLOju2idhKqy30HBNavvuywX0zhGZThyGzYfNxzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oEPb27 9Pc8ICHxOjxF4sDkFL+s/davMGKpI867X6PF8=; b=ETg29ZlcFmHgF8t+4PoLs6 iq8HK5h74SaAgfc1FGkChNU+WvsGMsfGFIHNmMhx0swBxZYVyNr9jk0X+lhHAedu HE5o1xUhicc8GDH8DyEdZJQaafBXg5h9ZtglDcWItdOesAzOYXUofFV78Itln3VX isamYLrDrHpnqOLNuf0hOVKJLOZvmg3Xf32mE/TM2rGfFkdZlnot6/SVpEtamSnF rBDCP0ex6iqxHSkWfzNcH8RQmLH+dJ8+MSB+I9XMs967sy9ZCi3Vd9OMMbDAi1gf 95Aa5GOJ2vBL7G2vb/Lrb3dKZzCnCNSEN7Z715Ty7+wDtIPRRfCf1U4mLixEOU4w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfedtgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgtggfgsehtqhertdertdejnecuhfhrohhmpeforgigihhmvgcu tfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrthhtvg hrnhepteeikefgffekgeekledtheduteetjefgkeeuvefhhfetgedugfektdeugeffgfef necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgi himhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Nov 2021 06:31:07 -0500 (EST) From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Daniel Vetter , David Airlie Subject: [PATCH 0/6] drm/vc4: kms: Misc fixes for HVS commits Date: Mon, 15 Nov 2021 12:30:59 +0100 Message-Id: <20211115113105.103275-1-maxime@cerno.tech> X-Mailer: git-send-email 2.33.1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , Jian-Hong Pan , dri-devel@lists.freedesktop.org, Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi,=0D =0D The conversion to DRM commit helpers (f3c420fe19f8, "drm/vc4: kms: Convert = to=0D atomic helpers") introduced a number of issues in corner cases, most of the= m=0D showing themselves in the form of either a vblank timeout or use-after-free= =0D error.=0D =0D These patches should fix most of them, some of them still being debugged.=0D =0D Maxime=0D =0D Maxime Ripard (6):=0D drm/vc4: kms: Wait for the commit before increasing our clock rate=0D drm/vc4: kms: Fix return code check=0D drm/vc4: kms: Add missing drm_crtc_commit_put=0D drm/vc4: kms: Clear the HVS FIFO commit pointer once done=0D drm/vc4: kms: Don't duplicate pending commit=0D drm/vc4: kms: Fix previous HVS commit wait=0D =0D drivers/gpu/drm/vc4/vc4_kms.c | 36 ++++++++++++++---------------------=0D 1 file changed, 14 insertions(+), 22 deletions(-)=0D =0D -- =0D 2.33.1=0D =0D