From: Dan Carpenter <dan.carpenter@oracle.com>
To: Karolina Drobnik <karolinadrobnik@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
forest@alittletooquiet.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/8] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn`
Date: Mon, 15 Nov 2021 18:47:13 +0300 [thread overview]
Message-ID: <20211115154713.GF26989@kadam> (raw)
In-Reply-To: <cover.1636729147.git.karolinadrobnik@gmail.com>
On Mon, Nov 15, 2021 at 10:55:41AM +0000, Karolina Drobnik wrote:
> * merge two patches (using incrementation in `idx` and cleanup) into one,
> partially implementing Dan's suggestion
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
I don't know why you didn't implement my suggestions exactly as I
described.... :/
If I were reading this patchset the first time through I would have
NAKed it because patch 2 is done in the wrong way. In a way, it's my
fault because I tried to explain exactly how the one thing per patch
rule worked and I obviously was not clear.
Ah well... Let's just merge it and move on.
regards,
dan carpenter
prev parent reply other threads:[~2021-11-15 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 10:55 [PATCH v3 0/8] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn` Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 1/8] staging: vt6655: Remove unnecessary type casts Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 2/8] staging: vt6655: Introduce `idx` variable Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 3/8] staging: vt6655: Use incrementation in `idx` Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 4/8] staging: vt6655: Rewrite conditional in AL7320 initialization Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 5/8] staging: vt6655: Rename `RFvWriteWakeProgSyn` function Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 6/8] staging: vt6655: Update comment for `rf_write_wake_prog_syn` Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 7/8] staging: vt6655: Delete bogus check for `init_count` in AL2230 Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 8/8] staging: vt6655: Delete bogus check for `init_count` in AL7230 Karolina Drobnik
2021-11-15 15:47 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115154713.GF26989@kadam \
--to=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.