From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A146FC433EF for ; Mon, 15 Nov 2021 21:28:54 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E852161BF4 for ; Mon, 15 Nov 2021 21:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E852161BF4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 210B4837B6; Mon, 15 Nov 2021 22:28:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TcZo6qfc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1FCE7837B6; Mon, 15 Nov 2021 22:28:50 +0100 (CET) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB2DF837AB for ; Mon, 15 Nov 2021 22:28:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72f.google.com with SMTP id i9so18389726qki.3 for ; Mon, 15 Nov 2021 13:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E+aa6XXvSNDrEdvuhyRlPb4G9BGMJOzIp/rZ9c9puRg=; b=TcZo6qfcJxkc3x3wO9M8rAAoimyCAZf6zgHY5tMj6oCpcb4XHKVd3txbvbGA7FjsEe s65zKrp5z24Z6NJpuvW1JXxpXG4XaR522t6Z+tWEw93kAeQk1aEEsofPNy302kCYjCSi pzX/UoSabJLhaII96mvHk9HKQvGmg7lBhR1wc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E+aa6XXvSNDrEdvuhyRlPb4G9BGMJOzIp/rZ9c9puRg=; b=pOtejASsTWk6zt88qBmmQpYEPSxLIhtFOJNDYvfTrkVs+FQga50JNQmpkMtNFfNk2f 7g99r38MU/WdA/4gFdbNyPF9jodOKRA6L13SB1veM0ao8vwZe8k8PFObNpnGmC909zoX m77+am8GLN5xjBR5Y8ELIo/AQR0JYUJlTZY+EJs2XF/CXLD5h0pzjxSDudd66+6Ve87a OahHDnQxkW/ATX8OJlrZnuaiYAQPyDlx95qGp7ul2kZx1NKBfC5m1iD4ti0jwADSV4wU o/WhF5RyPjYEHoT1IjC0k+g0iR40R6Ijec0ehtcYarV4v21OeLV8ZZ4M+V0ecSDJhAqT dDSQ== X-Gm-Message-State: AOAM5322Hvl8x/t182y+SWrDUiGdYxWPU9vDwOnJ0rj9a32HuxkR53nc rxMt/zPs6R9XcYchSojgEsIAMw== X-Google-Smtp-Source: ABdhPJyd3rCmcVTfU8GS3gE5ubUb/urLq/ZU6suLop4Rcbg1OtQe8fCwDwXRuqUM31hgA9BP/3joQw== X-Received: by 2002:a37:dd4:: with SMTP id 203mr1829908qkn.149.1637011725428; Mon, 15 Nov 2021 13:28:45 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-24a1-dfd8-1438-caaa.res6.spectrum.com. [2603:6081:7b01:cbda:24a1:dfd8:1438:caaa]) by smtp.gmail.com with ESMTPSA id bk25sm5332920qkb.13.2021.11.15.13.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 13:28:44 -0800 (PST) Date: Mon, 15 Nov 2021 16:28:41 -0500 From: Tom Rini To: Ariel D'Alessandro Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, aford173@gmail.com, andre.przywara@arm.com, andrey.zhizhikin@leica-geosystems.com, christianshewitt@gmail.com, festevam@gmail.com, hs@denx.de, iliev@ronetix.at, jagan@amarulasolutions.com, marcel.ziswiler@toradex.com, narmstrong@baylibre.com, patrick.delaunay@foss.st.com, pbrobinson@gmail.com, peng.fan@nxp.com, rick@andestech.com, sbabic@denx.de, seanga2@gmail.com, sjg@chromium.org, t.remmet@phytec.de, tharvey@gateworks.com Subject: Re: [PATCH v2] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board Message-ID: <20211115212841.GY24579@bill-the-cat> References: <20211115202422.537136-1-ariel.dalessandro@collabora.com> <20211115211133.GX24579@bill-the-cat> <6ab89061-46eb-ef79-3133-a661f23101d1@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VSVsGWCPih4tqO5h" Content-Disposition: inline In-Reply-To: <6ab89061-46eb-ef79-3133-a661f23101d1@collabora.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --VSVsGWCPih4tqO5h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 15, 2021 at 06:27:08PM -0300, Ariel D'Alessandro wrote: > Hi Tom, >=20 > Thanks for the feedback. >=20 > On 11/15/21 6:11 PM, Tom Rini wrote: > > On Mon, Nov 15, 2021 at 05:24:22PM -0300, Ariel D'Alessandro wrote: > >=20 > >> Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: > >> > >> - 1GiB DDR4 RAM > >> - 16 GiB eMMC > >> - SD card > >> - Gigabit ethernet > >> - USBOTG1 peripheral - fastboot > >> > >> Signed-off-by: Ariel D'Alessandro > >> --- > >> MAINTAINERS | 8 + > >=20 > > Typically this goes in to board/.../MAINTAINERS >=20 > Will fix in v3. >=20 > >=20 > >> arch/arm/dts/imx8mn-var-som.dts | 423 ++++++++++++++ > >=20 > > What linux kernel version (or, is it just in linux-next?) is this from? >=20 > It's already supported in current linux/master: >=20 > $ git describe origin/master > v5.16-rc1-3-g8ab774587903 OK, good, thanks. >=20 > >=20 > > [snip] > >> +#ifdef CONFIG_SPL_BUILD > >> + > >> +#define CONFIG_SPL_STACK 0x980000 > >> +#define CONFIG_SPL_BSS_START_ADDR 0x950000 > >> +#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K > >> +#define CONFIG_SYS_SPL_MALLOC_START 0x42200000 > >> +#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K > >> + > >> +/* For RAW image gives a error info not panic */ > >> +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE > >> + > >> +#endif /* CONFIG_SPL_BUILD */ > >=20 > > We can't guard CONFIG options with CONFIG_SPL_BUILD or > > !CONFIG_SPL_BUILD. >=20 > Sorry I don't understand, could you expand on the proper way to handle > the above configuration? AFAICS, several imx8m boards follow this same > pattern: >=20 > $ git grep -l CONFIG_SPL_BUILD -- include/configs/imx8m* > include/configs/imx8mm-cl-iot-gate.h > include/configs/imx8mm_beacon.h > include/configs/imx8mm_evk.h > include/configs/imx8mm_icore_mx8mm.h > include/configs/imx8mm_venice.h > include/configs/imx8mn_beacon.h > include/configs/imx8mn_evk.h > include/configs/imx8mp_evk.h > include/configs/imx8mq_cm.h > include/configs/imx8mq_evk.h > include/configs/imx8mq_phanbell.h Yes, it's sadly a common anti-pattern. Just always define things. --=20 Tom --VSVsGWCPih4tqO5h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGS0QYACgkQFHw5/5Y0 tyx/8wwAiz4coTaQuYwzWLXadrrFNauj4vVchMH8d8K5O8O8nwMKRnHGCMWvWNW2 1t8I/KHMtpw2WVJRuwpzPU2gnsQzp/VXzSkEm+5FValKl1N5tnICA69kViESaQYG MdcVHdub4njvXh/GrneEok36U6NBowQQUjILC7Kfs+GQSKy+aiu1HlpmGmdcY0ZF p5tbEGxvB1hA/gHUVpaF3SxodEOqCp1rdOtr4Bc6s0R/NSRGopNa2W+4OOhm4wFn MC+E4OpvFU4KCjJR8cs8/HNC8SphjCL3AkKz1tYGLGK6K2DdlT9SqA9xtEbJJ11g O7fprAdLywDO4Q6tW7zJ8gSxvPVB4rK2Jt4ADunoRTEXacTV1e0dC5g/NuhLlfnP f+ZZ/W8pmzRszUJ4iHTL+CCVzLBvTrlmvvBSmQb6a4iixsde+L7E2BvnHp+581oI NMxnNvKtggTY7S8LHpK1tTYH137ttWKgwXQf21uvgHDPW/Rk421p97je+ZoYVNSV 5YNLm+5g =UHZR -----END PGP SIGNATURE----- --VSVsGWCPih4tqO5h--