Re: [Buildroot] package/bdwgc: bump to 8.0.6

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Ivan Maidanski <ivmai@mail.ru>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] package/bdwgc: bump to 8.0.6
Date: Mon, 15 Nov 2021 23:34:36 +0100	[thread overview]
Message-ID: <20211115233436.029a67dd@windsurf> (raw)
In-Reply-To: <1637012444.996998717@f769.i.mail.ru>

Hello Ivan,

On Tue, 16 Nov 2021 00:40:44 +0300
Ivan Maidanski via buildroot <buildroot@buildroot.org> wrote:

> Here’s a patch updating bdwgc from 8.0.4 to 8.0.6.

I have applied your patch to the next branch, with some changes (see
below). However, for future patches, could you use "git send-email" to
send them so that the patch appears inline, which makes it easier to
review?

Here is your patch:

> -sha256 436a0ddc67b1ac0b0405b61a9675bca9e075c8156f4debd1d06f3a56c7cd289d  gc-8.0.4.tar.gz
> -sha256 aeeaabbf44e67d413e18719f0c6ac9c23387ab0b33e7a15ee46cf59ddef12cc7  README.QUICK
> +sha256 3b4914abc9fa76593596773e4da671d7ed4d5390e3d46fbf2e5f155e121bea11  gc-8.0.6.tar.gz
> +sha256 0aab7a56a92ed878c4a5464cf282d65f38bcdee64fe9cf213e26254bddb3f340  README.QUICK

When the license file hash changes, we want an indication in the commit
log explaining why it has changed. Indeed, the reason why we have such
hashes is to detect changes in the license terms of upstream projects.
If we "silently" change such hashes without a proper justification, it
kind of defeats the entire purpose of those hashes. After checking the
differences in README.QUICK between 8.0.4 and 8.0.6, I've added an
explanation in the commit log.

> diff --git a/package/bdwgc/bdwgc.mk b/package/bdwgc/bdwgc.mk
> index 57dd82cab4..54bc4fd889 100644
> --- a/package/bdwgc/bdwgc.mk
> +++ b/package/bdwgc/bdwgc.mk
> @@ -4,9 +4,9 @@
>  #
>  ################################################################################
>  
> -BDWGC_VERSION = 8.0.4
> +BDWGC_VERSION = 8.0.6
>  BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
> -BDWGC_SITE = http://www.hboehm.info/gc/gc_source
> +BDWGC_SITE = https://github.com/ivmai/bdwgc/releases/download/v$(BDWGC_VERSION)
>  BDWGC_INSTALL_STAGING = YES
>  BDWGC_LICENSE = bdwgc license
>  BDWGC_LICENSE_FILES = README.QUICK
> @@ -28,8 +28,6 @@ HOST_BDWGC_CONF_OPTS = --with-libatomic-ops=yes
>  
>  ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
>  BDWGC_CONF_OPTS += --enable-cplusplus
> -else
> -BDWGC_CONF_OPTS += --disable-cplusplus

No, we want to keep this, even if this is the default. We want to be
explicit about such options, which is what we do in the vast majority
of packages. So I've reverted that particular change from your patch
when applying.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot