From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38D2C433F5 for ; Tue, 16 Nov 2021 18:42:13 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 1272F61BA1 for ; Tue, 16 Nov 2021 18:42:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1272F61BA1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.openwall.com Received: (qmail 8063 invoked by uid 550); 16 Nov 2021 18:42:03 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 8026 invoked from network); 16 Nov 2021 18:42:02 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rpZo5Ukhloxpo3t6te7xJnWQRrow3d4oIhzJ9wNY//s=; b=VSNC43P14WmPSZmUrPilJ+DgGj5eVm+rYneRkINAieo4BCqCLBy5QiE+yxx4dMJHrP ofgb/NWCMtHijcLBbRJZt2srQLA+UEZ3FYMnXTi4zhVU59bazntvLi1ZB9x1FOAMm3MU zC1NqI7P7FvTEoA0kb6E30B9MNDZ7w/u4TNWQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rpZo5Ukhloxpo3t6te7xJnWQRrow3d4oIhzJ9wNY//s=; b=0KQGpbJgH4K4lBG9pER5+g3XInBEnfMhZa85w2fwqG3f9dK4XGGtCp1pD1T5jLVBHd WvRDywWfkwCagUqU8YF6pZVpYDC/dXQjkOnLf9fNDE3B3bQXYWnf6zEq8DOw6KxzpqF8 PZjwgoAYuTXwRD6tDIkjg2k1XMGsWERiJOTMiyP9v9qfSiSuMATN06mFFqAQVVEgsY7k O6VXMyvkuU+Galt8h6Q/VMVVYMeSjHFUwQ95WtN4+UCHf2y9lRtKozsOPbQ1RiNmm6Vc eFQIcmEjgv1hacrH7QHBymNor4AGMZri+4bmcCYfzdLp25G2xQUUaDBZsNcmIu7JWIvK lG7g== X-Gm-Message-State: AOAM5316Je0TdVjj90pl/VgSAycSIxIUYcqhIvKFvR7go8dDnWCbYEK6 AUdkNqjdIh4uXf3TNq9pfPJdaA== X-Google-Smtp-Source: ABdhPJycX3gPzRKrPSWv0E+uNTJtZaFFdHv8BhJIhDH//Ix6o2hDequKidyqHX9nzJJNXw16lwDFmQ== X-Received: by 2002:a17:902:ced1:b0:141:e15d:49e0 with SMTP id d17-20020a170902ced100b00141e15d49e0mr47744243plg.27.1637088110227; Tue, 16 Nov 2021 10:41:50 -0800 (PST) Date: Tue, 16 Nov 2021 10:41:49 -0800 From: Kees Cook To: Alexander Popov Cc: Steven Rostedt , Linus Torvalds , Lukas Bulwahn , Jonathan Corbet , Paul McKenney , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Joerg Roedel , Maciej Rozycki , Muchun Song , Viresh Kumar , Robin Murphy , Randy Dunlap , Lu Baolu , Petr Mladek , Luis Chamberlain , Wei Liu , John Ogness , Andy Shevchenko , Alexey Kardashevskiy , Christophe Leroy , Jann Horn , Greg Kroah-Hartman , Mark Rutland , Andy Lutomirski , Dave Hansen , Will Deacon , Ard Biesheuvel , Laura Abbott , David S Miller , Borislav Petkov , Arnd Bergmann , Andrew Scull , Marc Zyngier , Jessica Yu , Iurii Zaikin , Rasmus Villemoes , Wang Qing , Mel Gorman , Mauro Carvalho Chehab , Andrew Klychkov , Mathieu Chouquet-Stringer , Daniel Borkmann , Stephen Kitt , Stephen Boyd , Thomas Bogendoerfer , Mike Rapoport , Bjorn Andersson , Kernel Hardening , linux-hardening@vger.kernel.org, "open list:DOCUMENTATION" , linux-arch , Linux Kernel Mailing List , linux-fsdevel , notify@kernel.org, main@lists.elisa.tech, safety-architecture@lists.elisa.tech, devel@lists.elisa.tech, Shuah Khan Subject: Re: [PATCH v2 0/2] Introduce the pkill_on_warn parameter Message-ID: <202111161037.7456C981@keescook> References: <20211027233215.306111-1-alex.popov@linux.com> <77b79f0c-48f2-16dd-1d00-22f3a1b1f5a6@linux.com> <20211115110649.4f9cb390@gandalf.local.home> <202111151116.933184F716@keescook> <59534db5-b251-c0c8-791f-58aca5c00a2b@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59534db5-b251-c0c8-791f-58aca5c00a2b@linux.com> On Tue, Nov 16, 2021 at 12:12:16PM +0300, Alexander Popov wrote: > What if the Linux kernel had a LSM module responsible for error handling policy? > That would require adding LSM hooks to BUG*(), WARN*(), KERN_EMERG, etc. > In such LSM policy we can decide immediately how to react on the kernel error. > We can even decide depending on the subsystem and things like that. That would solve the "atomicity" issue the WARN tracepoint solution has, and it would allow for very flexible userspace policy. I actually wonder if the existing panic_on_* sites should serve as a guide for where to put the hooks. The current sysctls could be replaced by the hooks and a simple LSM. -- Kees Cook