All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v3 4/4] selftests: mptcp: add inq test case
Date: Wed, 17 Nov 2021 00:21:28 +0100	[thread overview]
Message-ID: <20211116232128.GG6326@breakpoint.cc> (raw)
In-Reply-To: <8efe4040-1e8f-4dd-3ec-9be2c6a46213@linux.intel.com>

Mat Martineau <mathew.j.martineau@linux.intel.com> wrote:
> > +static void connect_one_server(int fd, int unixfd)
> > +{
> > +	size_t len, i, total, sent;
> > +	char buf[4096], buf2[4096];
> > +	int queued, on = 1;
> 
> Still getting the 'unused variable' warnings on this line, but we can squash
> a fix for that (or wait to apply just this last patch?).

Sigh.  Mathieu, can you zap the line above (queued, on) after applying &
squash this?

  reply	other threads:[~2021-11-16 23:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 13:48 [PATCH v3 mptcp-next 0/4] TCP_INQ support Florian Westphal
2021-11-16 13:48 ` [PATCH mptcp-next v3 1/4] mptcp: add TCP_INQ cmsg support Florian Westphal
2021-11-18 17:53   ` Mat Martineau
2021-11-16 13:48 ` [PATCH mptcp-next v3 2/4] selftests: mptcp: add TCP_INQ support Florian Westphal
2021-11-16 13:48 ` [PATCH mptcp-next v3 3/4] mptcp: add SIOCINQ, OUTQ and OUTQNSD ioctls Florian Westphal
2021-11-16 13:48 ` [PATCH mptcp-next v3 4/4] selftests: mptcp: add inq test case Florian Westphal
2021-11-16 19:12   ` Mat Martineau
2021-11-16 23:21     ` Florian Westphal [this message]
2021-11-16 19:16 ` [PATCH v3 mptcp-next 0/4] TCP_INQ support Mat Martineau
2021-11-19 16:09 ` Matthieu Baerts
2021-11-19 16:11   ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116232128.GG6326@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.