From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8154014402630623442==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [RFC PATCH] crypto/ffdhe: ffdhe2048_g[] can be static Date: Thu, 18 Nov 2021 04:04:51 +0800 Message-ID: <20211117200451.GA184405@ce70f3326797> In-Reply-To: <20211112125928.97318-4-hare@suse.de> List-Id: --===============8154014402630623442== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable crypto/ffdhe_helper.c:18:10: warning: symbol 'ffdhe2048_g' was not declared= . Should it be static? crypto/ffdhe_helper.c:20:10: warning: symbol 'ffdhe2048_p' was not declared= . Should it be static? crypto/ffdhe_helper.c:55:10: warning: symbol 'ffdhe2048_q' was not declared= . Should it be static? crypto/ffdhe_helper.c:94:10: warning: symbol 'ffdhe3072_g' was not declared= . Should it be static? crypto/ffdhe_helper.c:96:10: warning: symbol 'ffdhe3072_p' was not declared= . Should it be static? crypto/ffdhe_helper.c:147:10: warning: symbol 'ffdhe3072_q' was not declare= d. Should it be static? crypto/ffdhe_helper.c:202:10: warning: symbol 'ffdhe4096_g' was not declare= d. Should it be static? crypto/ffdhe_helper.c:204:10: warning: symbol 'ffdhe4096_p' was not declare= d. Should it be static? crypto/ffdhe_helper.c:271:10: warning: symbol 'ffdhe4096_q' was not declare= d. Should it be static? crypto/ffdhe_helper.c:342:10: warning: symbol 'ffdhe6144_g' was not declare= d. Should it be static? crypto/ffdhe_helper.c:344:10: warning: symbol 'ffdhe6144_p' was not declare= d. Should it be static? crypto/ffdhe_helper.c:443:10: warning: symbol 'ffdhe6144_q' was not declare= d. Should it be static? crypto/ffdhe_helper.c:546:10: warning: symbol 'ffdhe8192_g' was not declare= d. Should it be static? crypto/ffdhe_helper.c:548:10: warning: symbol 'ffdhe8192_p' was not declare= d. Should it be static? crypto/ffdhe_helper.c:679:10: warning: symbol 'ffdhe8192_q' was not declare= d. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- ffdhe_helper.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/crypto/ffdhe_helper.c b/crypto/ffdhe_helper.c index d7018bc3a8ec5..5d8da12912523 100644 --- a/crypto/ffdhe_helper.c +++ b/crypto/ffdhe_helper.c @@ -15,9 +15,9 @@ /* * ffdhe2048 generator (g), modulus (p) and group size (q) */ -const u8 ffdhe2048_g[] =3D { 0x02 }; +static const u8 ffdhe2048_g[] =3D { 0x02 }; = -const u8 ffdhe2048_p[] =3D { +static const u8 ffdhe2048_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, @@ -52,7 +52,7 @@ const u8 ffdhe2048_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, }; = -const u8 ffdhe2048_q[] =3D { +static const u8 ffdhe2048_q[] =3D { 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, @@ -91,9 +91,9 @@ const u8 ffdhe2048_q[] =3D { * ffdhe3072 generator (g), modulus (p) and group size (q) */ = -const u8 ffdhe3072_g[] =3D { 0x02 }; +static const u8 ffdhe3072_g[] =3D { 0x02 }; = -const u8 ffdhe3072_p[] =3D { +static const u8 ffdhe3072_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, @@ -144,7 +144,7 @@ const u8 ffdhe3072_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, }; = -const u8 ffdhe3072_q[] =3D { +static const u8 ffdhe3072_q[] =3D { 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, @@ -199,9 +199,9 @@ const u8 ffdhe3072_q[] =3D { * ffdhe4096 generator (g), modulus (p) and group size (q) */ = -const u8 ffdhe4096_g[] =3D { 0x02 }; +static const u8 ffdhe4096_g[] =3D { 0x02 }; = -const u8 ffdhe4096_p[] =3D { +static const u8 ffdhe4096_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, @@ -268,7 +268,7 @@ const u8 ffdhe4096_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, }; = -const u8 ffdhe4096_q[] =3D { +static const u8 ffdhe4096_q[] =3D { 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, @@ -339,9 +339,9 @@ const u8 ffdhe4096_q[] =3D { * ffdhe6144 generator (g), modulus (p) and group size (q) */ = -const u8 ffdhe6144_g[] =3D { 0x02 }; +static const u8 ffdhe6144_g[] =3D { 0x02 }; = -const u8 ffdhe6144_p[] =3D { +static const u8 ffdhe6144_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, @@ -440,7 +440,7 @@ const u8 ffdhe6144_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, }; = -const u8 ffdhe6144_q[] =3D { +static const u8 ffdhe6144_q[] =3D { 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, @@ -543,9 +543,9 @@ const u8 ffdhe6144_q[] =3D { * ffdhe8192 generator (g), modulus (p) and group size (q) */ = -const u8 ffdhe8192_g[] =3D { 0x02 }; +static const u8 ffdhe8192_g[] =3D { 0x02 }; = -const u8 ffdhe8192_p[] =3D { +static const u8 ffdhe8192_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xad,0xf8,0x54,0x58,0xa2,0xbb,0x4a,0x9a, 0xaf,0xdc,0x56,0x20,0x27,0x3d,0x3c,0xf1, @@ -676,7 +676,7 @@ const u8 ffdhe8192_p[] =3D { 0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff, }; = -const u8 ffdhe8192_q[] =3D { +static const u8 ffdhe8192_q[] =3D { 0x7f,0xff,0xff,0xff,0xff,0xff,0xff,0xff, 0xd6,0xfc,0x2a,0x2c,0x51,0x5d,0xa5,0x4d, 0x57,0xee,0x2b,0x10,0x13,0x9e,0x9e,0x78, --===============8154014402630623442==--