Re: [PATCH 03/12] crypto/ffdhe: Finite Field DH Ephemeral Parameters

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3465 bytes --]

Hi Hannes,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc1 next-20211117]
[cannot apply to herbert-cryptodev-2.6/master herbert-crypto-2.6/master linux-nvme/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hannes-Reinecke/nvme-In-band-authentication-support/20211112-210112
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5833291ab6de9c3e2374336b51c814e515e8f3a5
config: x86_64-randconfig-s031-20211115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/1eadaf1bdef889b9d1c0b9bb2609cd11599c76bc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hannes-Reinecke/nvme-In-band-authentication-support/20211112-210112
        git checkout 1eadaf1bdef889b9d1c0b9bb2609cd11599c76bc
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> crypto/ffdhe_helper.c:18:10: sparse: sparse: symbol 'ffdhe2048_g' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:20:10: sparse: sparse: symbol 'ffdhe2048_p' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:55:10: sparse: sparse: symbol 'ffdhe2048_q' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:94:10: sparse: sparse: symbol 'ffdhe3072_g' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:96:10: sparse: sparse: symbol 'ffdhe3072_p' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:147:10: sparse: sparse: symbol 'ffdhe3072_q' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:202:10: sparse: sparse: symbol 'ffdhe4096_g' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:204:10: sparse: sparse: symbol 'ffdhe4096_p' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:271:10: sparse: sparse: symbol 'ffdhe4096_q' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:342:10: sparse: sparse: symbol 'ffdhe6144_g' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:344:10: sparse: sparse: symbol 'ffdhe6144_p' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:443:10: sparse: sparse: symbol 'ffdhe6144_q' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:546:10: sparse: sparse: symbol 'ffdhe8192_g' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:548:10: sparse: sparse: symbol 'ffdhe8192_p' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:679:10: sparse: sparse: symbol 'ffdhe8192_q' was not declared. Should it be static?
>> crypto/ffdhe_helper.c:816:3: sparse: sparse: symbol 'ffdhe_group_map' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32103 bytes --]