From: Kees Cook <keescook@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jouni Malinen <j@w1.fi>, Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] intersil: Use struct_group() for memcpy() region
Date: Thu, 18 Nov 2021 12:25:19 -0800 [thread overview]
Message-ID: <202111181224.088CD29@keescook> (raw)
In-Reply-To: <c5d8c214b5df75b5b77450d71c7aec9f3bd97a67.camel@sipsolutions.net>
On Thu, Nov 18, 2021 at 08:46:11PM +0100, Johannes Berg wrote:
> On Thu, 2021-11-18 at 10:41 -0800, Kees Cook wrote:
> >
> > /* 802.11 */
> > - __le16 frame_control; /* parts not used */
> > - __le16 duration_id;
> > - u8 addr1[ETH_ALEN];
> > - u8 addr2[ETH_ALEN]; /* filled by firmware */
> > - u8 addr3[ETH_ALEN];
> > - __le16 seq_ctrl; /* filled by firmware */
> > + struct_group(frame,
>
> Arguably, that should be 'header' rather than 'frame' :)
Works for me. :) I will rename it. Thanks!
--
Kees Cook
prev parent reply other threads:[~2021-11-18 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 18:41 [PATCH] intersil: Use struct_group() for memcpy() region Kees Cook
2021-11-18 19:46 ` Johannes Berg
2021-11-18 20:25 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111181224.088CD29@keescook \
--to=keescook@chromium.org \
--cc=allen.lkml@gmail.com \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romain.perier@gmail.com \
--cc=vaibhavgupta40@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.