From: "Marek Behún" <kabel@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Cc: "Simon Glass" <sjg@chromium.org>,
u-boot-board-maintainers@lists.denx.de,
u-boot-custodians@lists.denx.de, "Tom Rini" <trini@konsulko.com>,
u-boot@lists.denx.de, "Joe Hershberger" <joe.hershberger@ni.com>,
"Wolfgang Denk" <wd@denx.de>, "Marek Behún" <marek.behun@nic.cz>,
ilias.apalodimas@linaro.org,
"Kazuhiko Sakamoto" <sakamoto.kazuhiko@socionext.com>
Subject: Re: [PATCH] Revert "board: synquacer: developerbox: Don't set gd->env_addr to default_environment"
Date: Thu, 18 Nov 2021 14:42:19 +0100 [thread overview]
Message-ID: <20211118144219.6fa2032e@thinkpad> (raw)
In-Reply-To: <163721432461.467760.11657628315867225456.stgit@localhost>
On Thu, 18 Nov 2021 14:45:25 +0900
Masami Hiramatsu <masami.hiramatsu@linaro.org> wrote:
> Without default setting of gd->env_addr, U-Boot will cause
> a synchronous abort if the env-variables on the SPI flash is
> broken or not saved corectly. Set gd->env_addr correctly.
>
> This reverts commit 535870f3b0fb09ee9b2885409f05304111464643.
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> ---
> board/socionext/developerbox/developerbox.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/socionext/developerbox/developerbox.c b/board/socionext/developerbox/developerbox.c
> index 31b1349514..9552bfcdc3 100644
> --- a/board/socionext/developerbox/developerbox.c
> +++ b/board/socionext/developerbox/developerbox.c
> @@ -82,6 +82,8 @@ int board_init(void)
> {
> gd->bd->bi_boot_params = CONFIG_SYS_LOAD_ADDR + LOAD_OFFSET;
>
> + gd->env_addr = (ulong)&default_environment[0];
> +
> synquacer_setup_scbm_smmu();
>
> return 0;
>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
I will look into this when I respin the default environment series.
Marek
next prev parent reply other threads:[~2021-11-18 13:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 13:47 [PATCH 00/14] Some more env fixes Marek Behún
2021-10-22 13:47 ` [PATCH 01/14] env: sf: Cosmetic fix in env_sf_init_addr() Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 02/14] env: sf: Use ENV_VALID enum names instead of literals Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 03/14] env: sf: Put ENV_INVALID into gd->env_valid on CRC failure Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-22 13:47 ` [PATCH 04/14] env: nand: Put ENV_INVALID into gd->env_valid if default environment Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 05/14] env: nvram: Let generic env_init() assign " Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 06/14] env: nvram: Cosmetic fix in env_nvram_init() Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 07/14] env: nowhere: Let generic env_init() assign default environment Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 08/14] env: nowhere: Cosmetic fix Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 09/14] env: flash: Let generic env_init() assign default environment Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-22 13:47 ` [PATCH 10/14] env: flash: Cosmetic fix Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-10-22 13:47 ` [PATCH 11/14] board: synquacer: developerbox: Don't set gd->env_addr to default_environment Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:57 ` Simon Glass
2021-11-17 4:58 ` Masami Hiramatsu
2021-11-17 20:36 ` Simon Glass
2021-11-18 5:40 ` Masami Hiramatsu
2021-11-18 5:45 ` [PATCH] Revert "board: synquacer: developerbox: Don't set gd->env_addr to default_environment" Masami Hiramatsu
2021-11-18 13:42 ` Marek Behún [this message]
2021-11-18 23:27 ` Tom Rini
2021-10-22 13:47 ` [PATCH 12/14] board: freescale: various boards: Let env subsystem set gd->env_addr Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:56 ` Simon Glass
2021-10-22 13:47 ` [PATCH 13/14] env: Always use char for default_environment Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:56 ` Simon Glass
2021-10-22 13:47 ` [PATCH 14/14] env: Use static_assert() to check if default_environment is too large Marek Behún
2021-10-22 16:08 ` Simon Glass
2021-10-31 12:56 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118144219.6fa2032e@thinkpad \
--to=kabel@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=marek.behun@nic.cz \
--cc=masami.hiramatsu@linaro.org \
--cc=sakamoto.kazuhiko@socionext.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot-board-maintainers@lists.denx.de \
--cc=u-boot-custodians@lists.denx.de \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.