All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: io-uring@vger.kernel.org
Cc: Liu Changcheng <changcheng.liu@aliyun.com>,
	Stefan Metzmacher <metze@samba.org>
Subject: [PATCHv2 8/7] debian/rules: fix version comparison for Ubuntu
Date: Thu, 18 Nov 2021 18:50:20 +0000	[thread overview]
Message-ID: <20211118185020.M466694@dcvr> (raw)
In-Reply-To: <20211118031016.354105-1-e@80x24.org>

Perl version strings do not accept values such as "12.10ubuntu1",
so only compare the digits and "." parts at the beginning.

Tested-by: Stefan Metzmacher <metze@samba.org>
Link: https://lore.kernel.org/io-uring/8ccd3b34-bd3a-6c9f-fdb6-64d1b3b43f64@samba.org/
Signed-off-by: Eric Wong <e@80x24.org>
---
 debian/rules | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index cd41bb8..d0b4eea 100755
--- a/debian/rules
+++ b/debian/rules
@@ -84,7 +84,8 @@ binary-arch: install-arch
 # --add-udeb is needed for < 12.3, and breaks with auto-detection
 #  on debhelper 13.3.4, at least
 	if perl -MDebian::Debhelper::Dh_Version -e \
-	'exit(eval("v$$Debian::Debhelper::Dh_Version::version") lt v12.3)'; \
+	'($$v) = ($$Debian::Debhelper::Dh_Version::version =~ /\A([\d\.]+)/);' \
+	-e 'exit(eval("v$$v") lt v12.3)'; \
 		then dh_makeshlibs -a; else \
 		dh_makeshlibs -a --add-udeb '$(libudeb)'; fi
 

  parent reply	other threads:[~2021-11-18 18:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 22:44 [PATCH 0/4] liburing debian packaging fixes Eric Wong
2021-11-16 22:44 ` [PATCH 1/4] make-debs: fix version detection Eric Wong
2021-11-17 10:17   ` Stefan Metzmacher
2021-11-18  1:25     ` Eric Wong
2021-11-16 22:44 ` [PATCH 2/4] debian: avoid prompting package builder for signature Eric Wong
2021-11-17 10:01   ` Stefan Metzmacher
2021-11-18  3:14     ` Eric Wong
2021-11-16 22:44 ` [PATCH 3/4] debian/rules: fix for newer debhelper Eric Wong
2021-11-17 10:04   ` Stefan Metzmacher
2021-11-18  1:20     ` Eric Wong
2021-11-16 22:44 ` [PATCH 4/4] debian/rules: support parallel build Eric Wong
2021-11-18  3:10 ` [PATCH v2 0/7] liburing debian packaging fixes Eric Wong
2021-11-18  3:10   ` [PATCH v2 1/7] make-debs: fix version detection Eric Wong
2021-11-18  3:10   ` [PATCH v2 2/7] debian: avoid prompting package builder for signature Eric Wong
2021-11-18  3:10   ` [PATCH v2 3/7] debian/rules: fix for newer debhelper Eric Wong
2021-11-18  4:42     ` Stefan Metzmacher
2021-11-18  5:11       ` Eric Wong
2021-11-18  5:35         ` Eric Wong
2021-11-18 14:37           ` Stefan Metzmacher
2021-11-18  3:10   ` [PATCH v2 4/7] debian/rules: support parallel build Eric Wong
2021-11-18  3:10   ` [PATCH v2 5/7] debian: rename package to liburing2 to match .so version Eric Wong
2021-11-18  3:10   ` [PATCH v2 6/7] make-debs: use version from RPM .spec Eric Wong
2021-11-18  3:10   ` [PATCH v2 7/7] make-debs: remove dependency on git Eric Wong
2021-11-18 18:50   ` Eric Wong [this message]
2022-01-21 18:26 ` [PULL|PATCH v3 0/7] liburing debian packaging fixes Eric Wong
2022-01-21 18:26   ` [PATCH v3 1/7] make-debs: fix version detection Eric Wong
2022-01-21 18:26   ` [PATCH v3 2/7] debian: avoid prompting package builder for signature Eric Wong
2022-01-21 18:26   ` [PATCH v3 3/7] debian/rules: fix for newer debhelper Eric Wong
2022-01-21 18:26   ` [PATCH v3 4/7] debian/rules: support parallel build Eric Wong
2022-01-21 18:26   ` [PATCH v3 5/7] debian: rename package to liburing2 to match .so version Eric Wong
2022-01-21 18:26   ` [PATCH v3 6/7] make-debs: use version from RPM .spec Eric Wong
2022-01-21 18:26   ` [PATCH v3 7/7] make-debs: remove dependency on git Eric Wong
2022-04-03  8:48   ` [PULL|PATCH v3 0/7] liburing debian packaging fixes Eric Wong
2022-04-03 14:54     ` Jens Axboe
2022-04-03 20:43       ` Eric Wong
2022-04-04 16:13       ` Stefan Metzmacher
2022-04-04 16:17         ` Stefan Metzmacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211118185020.M466694@dcvr \
    --to=e@80x24.org \
    --cc=changcheng.liu@aliyun.com \
    --cc=io-uring@vger.kernel.org \
    --cc=metze@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.