From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Sasha Levin <sashal@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
stable@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19
Date: Fri, 19 Nov 2021 08:16:59 -0800 [thread overview]
Message-ID: <202111190808.1DA0067@keescook> (raw)
In-Reply-To: <YZeaCndfOGSZLHgX@kroah.com>
On Fri, Nov 19, 2021 at 01:35:22PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 15, 2021 at 11:39:18AM -0700, Nathan Chancellor wrote:
> > Hi Greg and Sasha,
> >
> > There is a build error with newer versions of clang due to a broken
> > FORTIFY_SOURCE implementation, which has never worked:
> >
> > https://github.com/ClangBuiltLinux/linux/issues/1496
> > https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1457787760
> >
> > Please apply upstream commit a52f8a59aef4 ("fortify: Explicitly disable
> > Clang support") to 5.15 through 4.19 to resolve this. It should apply
> > cleanly.
>
> Hah! Oh the Android people are going to _LOVE_ this one...
They (we) are already aware[1]. Fortify has always been broken under
Clang, so really this doesn't change anything for Android builds. :P
But yes, one of many motivations of the recent memcpy and fortify work
has been to get fortify fixed for Clang. Hopefully this will be all done
by 5.17.
-Kees
[1] https://github.com/KSPP/linux/issues/77
--
Kees Cook
prev parent reply other threads:[~2021-11-19 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 18:39 Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19 Nathan Chancellor
2021-11-19 12:35 ` Greg Kroah-Hartman
2021-11-19 16:16 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111190808.1DA0067@keescook \
--to=keescook@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.