From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH] skbuff: Switch structure bounds to struct_group()
Date: Fri, 19 Nov 2021 08:40:47 +0800 [thread overview]
Message-ID: <202111190811.V28qMJWc-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 9571 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20211118183615.1281978-1-keescook@chromium.org>
References: <20211118183615.1281978-1-keescook@chromium.org>
TO: Kees Cook <keescook@chromium.org>
Hi Kees,
I love your patch! Perhaps something to improve:
[auto build test WARNING on kees/for-next/pstore]
[also build test WARNING on net-next/master net/master linus/master v5.16-rc1 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kees-Cook/skbuff-Switch-structure-bounds-to-struct_group/20211119-023639
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: x86_64-randconfig-s031-20211118 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/fc83cc3a3fb04bbc702c6c59ab17f87a3a9d6946
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kees-Cook/skbuff-Switch-structure-bounds-to-struct_group/20211119-023639
git checkout fc83cc3a3fb04bbc702c6c59ab17f87a3a9d6946
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash net/x25/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
net/x25/x25_timer.c: note: in included file (through include/net/net_namespace.h, include/linux/netdevice.h, include/net/sock.h):
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/sysctl_net_x25.c: note: in included file:
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_subr.c: note: in included file:
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_route.c: note: in included file (through include/linux/if_arp.h):
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_dev.c: note: in included file (through include/net/net_namespace.h, include/linux/netdevice.h):
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_forward.c: note: in included file (through include/linux/if_arp.h):
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/af_x25.c: note: in included file (through include/net/net_namespace.h, include/linux/netdevice.h):
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_in.c: note: in included file:
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_link.c: note: in included file (through include/net/net_namespace.h, include/linux/netdevice.h):
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_out.c: note: in included file:
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_facilities.c: note: in included file:
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
--
net/x25/x25_proc.c: note: in included file (through include/net/net_namespace.h):
>> include/linux/skbuff.h:820:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:822:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:846:1: sparse: sparse: directive in macro's argument list
include/linux/skbuff.h:848:1: sparse: sparse: directive in macro's argument list
vim +820 include/linux/skbuff.h
6a5bcd84e886a9a Ilias Apalodimas 2021-06-07 810
fc83cc3a3fb04bb Kees Cook 2021-11-18 811 /* Fields enclosed in headers group are copied
b1937227316417a Eric Dumazet 2014-09-28 812 * using a single memcpy() in __copy_skb_header()
b1937227316417a Eric Dumazet 2014-09-28 813 */
fc83cc3a3fb04bb Kees Cook 2021-11-18 814 struct_group(headers,
4031ae6edb92f7e Alexander Duyck 2012-01-27 815
233577a22089fac Hannes Frederic Sowa 2014-09-12 816 /* if you move pkt_type around you also must adapt those constants */
233577a22089fac Hannes Frederic Sowa 2014-09-12 817 #ifdef __BIG_ENDIAN_BITFIELD
233577a22089fac Hannes Frederic Sowa 2014-09-12 818 #define PKT_TYPE_MAX (7 << 5)
233577a22089fac Hannes Frederic Sowa 2014-09-12 819 #else
233577a22089fac Hannes Frederic Sowa 2014-09-12 @820 #define PKT_TYPE_MAX 7
^1da177e4c3f415 Linus Torvalds 2005-04-16 821 #endif
233577a22089fac Hannes Frederic Sowa 2014-09-12 822 #define PKT_TYPE_OFFSET() offsetof(struct sk_buff, __pkt_type_offset)
fe55f6d5c0cfec4 Vegard Nossum 2008-08-30 823
d2f273f0a920525 Randy Dunlap 2020-02-15 824 /* private: */
233577a22089fac Hannes Frederic Sowa 2014-09-12 825 __u8 __pkt_type_offset[0];
d2f273f0a920525 Randy Dunlap 2020-02-15 826 /* public: */
b1937227316417a Eric Dumazet 2014-09-28 827 __u8 pkt_type:3;
b1937227316417a Eric Dumazet 2014-09-28 828 __u8 ignore_df:1;
b1937227316417a Eric Dumazet 2014-09-28 829 __u8 nf_trace:1;
b1937227316417a Eric Dumazet 2014-09-28 830 __u8 ip_summed:2;
3853b5841c01a3f Tom Herbert 2010-11-21 831 __u8 ooo_okay:1;
8b7008620b84527 Stefano Brivio 2018-07-11 832
61b905da33ae25e Tom Herbert 2014-03-24 833 __u8 l4_hash:1;
a3b18ddb9cc1056 Tom Herbert 2014-07-01 834 __u8 sw_hash:1;
6e3e939f3b1bf85 Johannes Berg 2011-11-09 835 __u8 wifi_acked_valid:1;
6e3e939f3b1bf85 Johannes Berg 2011-11-09 836 __u8 wifi_acked:1;
3bdc0eba0b8b477 Ben Greear 2012-02-11 837 __u8 no_fcs:1;
77cffe23c1f8883 Tom Herbert 2014-08-27 838 /* Indicates the inner headers are valid in the skbuff. */
6a674e9c75b17e7 Joseph Gasparakis 2012-12-07 839 __u8 encapsulation:1;
7e2b10c1e52ca37 Tom Herbert 2014-06-04 840 __u8 encap_hdr_csum:1;
5d0c2b95bc57cf8 Tom Herbert 2014-06-10 841 __u8 csum_valid:1;
8b7008620b84527 Stefano Brivio 2018-07-11 842
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30273 bytes --]
next reply other threads:[~2021-11-19 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 0:40 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-18 18:36 [PATCH] skbuff: Switch structure bounds to struct_group() Kees Cook
2021-11-19 7:13 ` Jakub Kicinski
2021-11-19 16:24 ` Kees Cook
2021-11-19 18:26 ` Kees Cook
2021-11-19 18:41 ` Jakub Kicinski
2021-11-19 18:53 ` Jakub Kicinski
2021-11-19 19:04 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111190811.V28qMJWc-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.