From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3439BC433F5 for ; Fri, 19 Nov 2021 16:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B53761B1E for ; Fri, 19 Nov 2021 16:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236566AbhKSQjC (ORCPT ); Fri, 19 Nov 2021 11:39:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236548AbhKSQjC (ORCPT ); Fri, 19 Nov 2021 11:39:02 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C8FCC06173E for ; Fri, 19 Nov 2021 08:36:00 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id u11so8541306plf.3 for ; Fri, 19 Nov 2021 08:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mUA1Ik1IrEtjZziXrTIENZOvTLv8BEae3qCpSE+YCyM=; b=HrLUCriF+D8Cvoif6PoPXuZ01iT7CVMXAmIoIU345nrBpdU8RCDZ+XDjy4aMpyqWxX 1mwslROiPVbi4rQFrNiFLaQRmGBi3X/LId8fpbBu1EBXodx74x0ejyq7NGD7dF6bmaCd XHh44079HyOoO48w9cAB4WkzNpBCpXyILFZkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mUA1Ik1IrEtjZziXrTIENZOvTLv8BEae3qCpSE+YCyM=; b=DCw4dSi8o2stWOA0U5sD3hria8YsN9E5YhqBxNsQZ3jw7GMQPJTDkScACT1wzxCMCz ji0k6c6IPu5yjl8gPGLn8CMS2TqkjkBbn3zI+V5+AQ/BIlnzjsB9azp1Hyq2tzzZyFtK c31Izi1T29/F1SFzOasxOJb0FXHcMheBLczmadZEwRpDNltalfbVPR/gL1WqE6CG/Vw5 YL6+Fkwnig0GvLRmUS/hjOuV9UGfh6aYNYGqywWZndjFG4v3rPs83UStu84YXECDxMtJ TeovpuZNh30/iUwNZFH416GiIHBBtNfmXZ8uhlwcO4M2tbj/8G4bcYteUp9vGJr/GleH PgtQ== X-Gm-Message-State: AOAM533vrU39Vrdtgf6ipyMdTISImLm2ieTIn+ryb7K0yMp4zPBLNW2x FHbOL+wNdgN9G0FqG+Pm7IbDUOjZuQ+X2g== X-Google-Smtp-Source: ABdhPJwVGtrRIcvhQKROwLYzVQy0XXGjw4lU4UVPO7uYFvU2N/IYecAtrr5pfHvRHECUwfWCqLA7aQ== X-Received: by 2002:a17:90a:e00c:: with SMTP id u12mr1072545pjy.139.1637339759754; Fri, 19 Nov 2021 08:35:59 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w37sm184115pgk.87.2021.11.19.08.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 08:35:59 -0800 (PST) Date: Fri, 19 Nov 2021 08:35:58 -0800 From: Kees Cook To: Kyle Huey Cc: "Eric W. Biederman" , Linus Torvalds , Andrea Righi , Shuah Khan , Alexei Starovoitov , Andy Lutomirski , Will Drewry , "open list:KERNEL SELFTEST FRAMEWORK" , bpf , open list , linux-hardening@vger.kernel.org, Robert O'Callahan Subject: Re: [REGRESSION] 5.16rc1: SA_IMMUTABLE breaks debuggers Message-ID: <202111190829.C0B365D4@keescook> References: <87k0h6334w.fsf@email.froward.int.ebiederm.org> <202111171341.41053845C3@keescook> <202111171728.D85A4E2571@keescook> <875ysp1m39.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Nov 19, 2021 at 08:07:36AM -0800, Kyle Huey wrote: > On Thu, Nov 18, 2021 at 8:12 AM Eric W. Biederman wrote: > > Kyle thank you for your explanation of what breaks. For future kernels > > I do need to do some work in this area and I will copy on the patches > > going forward. In particular I strongly suspect that changing the > > sigaction and blocked state of the signal for these synchronous signals > > is the wrong thing to do, especially if the process is not killed. I > > want to find another solution that does not break things but that also > > does not change the program state behind the programs back so things > > work differently under the debugger. > > The heads up in the future is appreciated, thanks. Yeah, I wonder if we could add you as a Reviewer in the MAINTAINERS file for ptrace/signal stuff? Then anyone using scripts/get_maintainers.pl would have a CC to you added. Also, are there more instructions about running the rr tests? When the execve refactoring was happening, I tried it[1], but the results were unclear (there seemed to be a lot of warnings and it made me think I'd done something wrong on my end). -Kees [1] https://github.com/rr-debugger/rr/wiki/Building-And-Installing#tests -- Kees Cook