From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65394C433EF for ; Fri, 19 Nov 2021 20:26:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C976A613C8 for ; Fri, 19 Nov 2021 20:26:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C976A613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9F698835B4; Fri, 19 Nov 2021 21:25:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="kXAHmG2h"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1A0EC83630; Fri, 19 Nov 2021 21:24:44 +0100 (CET) Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 39EE88373C for ; Fri, 19 Nov 2021 21:24:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-ot1-x32d.google.com with SMTP id g91-20020a9d12e4000000b0055ae68cfc3dso18462607otg.9 for ; Fri, 19 Nov 2021 12:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iKOix0zkTjw0q2RY+Qrjkbd956mvA91wrw+I848RrcM=; b=kXAHmG2htk7gmFSnl6DyqSuffW9xHeYajDGhFQUPcKKo+++7nFo/1QtRbBtkHhjf25 DlzShWSFUhq2HtUjeZJ9dEsZcPl1hKl3Je6nsDTTygvQ0KURa6/mFFrUq1GTuu/VAvnD IxZ2AOHen1kOy+2M+B7k2tEnfOXVBywrtMpaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iKOix0zkTjw0q2RY+Qrjkbd956mvA91wrw+I848RrcM=; b=O+hDAKTCrkn1vPBvNnYXr10QgAOh+5rFdzBWtsSxQgmRtfOP/GxD4vzHjRaF81ChNg xgFdYmktrtd/tcJrzIbE9AxdkA8DeFlp63P7sdSwXcOusN+Btna/kuXJxiRcZ7axXuSV M6ihntE7Za9c5BgdDxiHpd5g27u7TiS9vgipPKpiljqOfZoV0w0bZ7iOmhAxxx8h1Nbh p14tdWPt1Bjp+OfNRfwHczNyt0ritl/BqQD7HEDCfzG1EKzT1OqMxPnXsggbD0pfjTbW DOwrhSFN1vAlBExi47WkjosglhKTieby9l7S3OKQucik4NdngIoami9VMH4lHJFnxAT7 vaAA== X-Gm-Message-State: AOAM533zs+YgrRM26tvSITYyM/gYptK7s1mEgmc9pOSXAugxhc8rsR/N b7tWtaNSfv19CYEFpDRMr0zkduvwiDqqeQ== X-Google-Smtp-Source: ABdhPJxhr2CzKSq59txSMxdQsmg3lAQaEmys5SK8u/iOPfidbkSD6sSiKkipiVeXDQljSan3EhrVxw== X-Received: by 2002:a05:6830:1392:: with SMTP id d18mr6784095otq.374.1637353463704; Fri, 19 Nov 2021 12:24:23 -0800 (PST) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id bl33sm197093oib.47.2021.11.19.12.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 12:24:23 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Anatolij Gustschin , Tom Rini , Simon Glass Subject: [PATCH 05/23] sandbox: video: Correct the address of the copy base Date: Fri, 19 Nov 2021 13:23:49 -0700 Message-Id: <20211119202408.1815506-6-sjg@chromium.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211119202408.1815506-1-sjg@chromium.org> References: <20211119202408.1815506-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The intention is for the copy base to start halfway through the frame-buffer area. At present is it actually below the frame buffer, which could have anything in it (probably it is malloc space). Fix this. Signed-off-by: Simon Glass --- drivers/video/sandbox_sdl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/sandbox_sdl.c b/drivers/video/sandbox_sdl.c index de8c6609c46..eb321ad17f5 100644 --- a/drivers/video/sandbox_sdl.c +++ b/drivers/video/sandbox_sdl.c @@ -43,7 +43,7 @@ static int sandbox_sdl_probe(struct udevice *dev) uc_priv->vidconsole_drv_name = plat->vidconsole_drv_name; uc_priv->font_size = plat->font_size; if (IS_ENABLED(CONFIG_VIDEO_COPY)) - uc_plat->copy_base = uc_plat->base - uc_plat->size / 2; + uc_plat->copy_base = uc_plat->base + uc_plat->size / 2; return 0; } -- 2.34.0.rc2.393.gf8c9666880-goog