From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC2D4C433F5 for ; Fri, 19 Nov 2021 22:10:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4833182DB4; Fri, 19 Nov 2021 23:10:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WG/tMS6c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B4B1D82DB4; Fri, 19 Nov 2021 23:09:59 +0100 (CET) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5AED782A65 for ; Fri, 19 Nov 2021 23:09:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id m192so7254246qke.2 for ; Fri, 19 Nov 2021 14:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qOGqUmrClKldQozxlJa+e7HVaq7iwoK1HhGxq0+BJTQ=; b=WG/tMS6cCjlMjErRtWWxuza3K4QTCdeJm17bayEs+630zjbiVqNgHp+YxqMacouwr/ zel8EcsgKrnmvy00ybIVotp884flYyP0NX1yGSI3uzyUDELz3Oo3POinqGOIoGHP1CgP hMVV3A2tJAz3+d96DQG86F4r6NBv4r81DySJ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qOGqUmrClKldQozxlJa+e7HVaq7iwoK1HhGxq0+BJTQ=; b=WGAh+FisR23v2Uvdy+tcsLQs3dIGi/3j+mYOvjr086mMcSlr1LnZkAd9drpEiGyR8j rfwbyWgJJ+KaemJ7+mO5GpsUxgtsJKXJs0VgMXoFqj+mBSoNRaV7eLoe9Q96hSuPLbap 1xFCApLEWNM6H0N8B62puGn3Lr24zJ4+/jkMK2DC4JtihtDUuFNUuEe+26jJzhpbx7Do bCxyG6DDJg2SW5Ig8jalwTNl7ixNy/LzE7UzbRPgOzMjtmeCgdXojG7PMbTZ/gBwgoBN nhGikegzRoheaKQlcPVLWvYztQ1+UEixEhQuKU22laWDzCARg9Y9aKFkVjmokAWdCVES /60A== X-Gm-Message-State: AOAM530cVpMAlKEA9LwJ7o8/mQ9SSKhFugsTUzMWDKyGlOFWRp6Et+PQ hizn4EZxbbA/lbNlwc916ILxCQ== X-Google-Smtp-Source: ABdhPJzug2u+mX3MJPMH6e/yVDJmrKq2ihfHgHRj5z7MRkKha/1q20ciLo3fBpapAV4ziUj4DV0U+A== X-Received: by 2002:a05:620a:3707:: with SMTP id de7mr31434924qkb.125.1637359795232; Fri, 19 Nov 2021 14:09:55 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-298c-b356-0e05-d708.res6.spectrum.com. [2603:6081:7b01:cbda:298c:b356:e05:d708]) by smtp.gmail.com with ESMTPSA id j24sm481021qkg.133.2021.11.19.14.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 14:09:53 -0800 (PST) Date: Fri, 19 Nov 2021 17:09:51 -0500 From: Tom Rini To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Ilias Apalodimas , Simon Glass Subject: Re: [PATCH] efi: Call bootm_disable_interrupts earlier in efi_exit_boot_services Message-ID: <20211119220951.GL24579@bill-the-cat> References: <20211119213304.2824837-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DdODeaPUdQhij6po" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --DdODeaPUdQhij6po Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 19, 2021 at 10:52:27PM +0100, Heinrich Schuchardt wrote: >=20 >=20 > Am 19. November 2021 22:33:04 MEZ schrieb Tom Rini : > >If we look at the path that bootm/booti take when preparing to boot the > >OS, we see that as part of (or prior to calling do_bootm_states, > >explicitly) the process, bootm_disable_interrupts() is called prior to > >announce_and_cleanup() which is where udc_disconnect() / > >board_quiesce_devices() / dm_remove_devices_flags() are called from. In > >the EFI path, these are called afterwards. In efi_exit_boot_services() > >however we have been calling bootm_disable_interrupts() after the above > >functions, as part of ensuring that we disable interrupts as required > >by the spec. However, bootm_disable_interrupts() is also where we go > >and call usb_stop(). While this has been fine before, on the TI J721E > >platform this leads us to an exception. This exception seems likely to > >be the case that we're trying to stop devices that we have already > >disabled clocks for. The most direct way to handle this particular >=20 > This patch may hide an error on your board but obviously does not address= the real problem. >=20 > If dependencies in the shut down sequence should exist, we need to consid= er them in the driver model. >=20 > What is your plan to analyze the problem? I'm not sure there is a different problem to solve here. It's unsafe to call the "shut everything down" function, which is what usb_stop() is, after having shut everything down. We may be able to stop calling usb_stop() as any sort of shutdown should already have happened via driver model, which is what we see now. --=20 Tom --DdODeaPUdQhij6po Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGYIKwACgkQFHw5/5Y0 tyy/vwv/eGtb+TOxrOa6rmCAorQUHw/6kvxipPq8bmUMG3VS9T8TRgiyFncKJXDZ 4Alomla2AqoTz/kd4Wqnwxvv2lr3q96IE+QcKU3Ys3HVEgyFAYUsCyzP91cHkw6p lrCM14L4XvDsok/vv1E/G/iCRvq/kdX6bZFvMURUQ4UVPpv0tWKZg4N8bcu3ytwl EMycBxUb4+rEVoYdITXYjmhCL1eSq4MJX1yj5T+81b3QVPY+l03bmai71cm1ypIb mHuK1TMiKEBAKNRb4ilr0mjX1eqcZVMOo7yH0J2/y7T9ZzrYXT69QMN90ObpeeWd Mq6wzVHiq7wjuGpac70ttJkdBdZZFoWqK9T0Z7Vr/8T7QXl/KMVN0iNfhkoeBjBe ZExhDTmztVVTBlxOLp9I+pVjewegFKX4deoz1OLHUymQXAkCgtgOyIcwUPTuqKbX ITplafYcPew5Mk4iNV5WZJ/7geLHsk9svGfrZXA7QpSXi3BSbdQtGDG/nNwv4DcN R83+zDgh =Cmmz -----END PGP SIGNATURE----- --DdODeaPUdQhij6po--