Re: [meta-ti] [PATCH] ti33x: remove the screen machine feature

["Denys Dmytriyenko" <denis@denix.org>]

On Fri, Nov 19, 2021 at 03:15:33PM -0500, Vivien Didelot wrote:
> Some distros or image recipes may rely on the presence of the "screen"
> machine feature to install graphical front-end applications.
> 
> The ti33x SoC has an integrated GPU but does not have a screen per-se,
> thus having this feature in the SoC configuration may lead to unwanted
> packages being built.
> 
> Comment the 'screen' feature and remove it from MACHINE_FEATURES.

Well, 'screen' also implies not just a built-in LCD, but also external screens 
connected over HDMI or DVI. There are even remnant MACHINE_GUI_CLASS variables 
set in machine configs for either "bigscreen" or "smallscreen", although that 
one is no longer used.

All TI platforms with am335x SoC do have screen outputs, but I do understand 
there could be headless platforms from other manufacturers with this SoC. The 
correct way would be to not completely remove "screen" MACHINE_FEATURE from 
the SoC include file, but rather move it to corresponding machine configs that 
use it - am335x-evm, beaglebone, etc.


> Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
> ---
>  conf/machine/include/ti33x.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
> index 197cac19..c499928c 100644
> --- a/conf/machine/include/ti33x.inc
> +++ b/conf/machine/include/ti33x.inc
> @@ -61,8 +61,8 @@ UBI_VOLNAME = "rootfs"
>  
>  EXTRA_IMAGEDEPENDS += "virtual/bootloader"
>  
> -# List common SoC features, may need to add touchscreen for specific machines
> -MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet gpu"
> +# List common SoC features, may need to add "screen touchscreen" for specific machines
> +MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 alsa ethernet gpu"
>  
>  # Set the list of device targets for ti-pdk class recipes
>  TI_PDK_LIMIT_SOCS = "am335x"
> -- 
> 2.33.1
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964