Re: [PATCH v4 08/10] flow_offload: add reoffload process to update hw_count

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4914 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20211118130805.23897-9-simon.horman@corigine.com>
References: <20211118130805.23897-9-simon.horman@corigine.com>
TO: Simon Horman <simon.horman@corigine.com>
TO: netdev(a)vger.kernel.org
CC: Cong Wang <xiyou.wangcong@gmail.com>
CC: Ido Schimmel <idosch@nvidia.com>
CC: Jamal Hadi Salim <jhs@mojatatu.com>
CC: Jiri Pirko <jiri@resnulli.us>
CC: Oz Shlomo <ozsh@nvidia.com>
CC: Roi Dayan <roid@nvidia.com>
CC: Vlad Buslov <vladbu@nvidia.com>
CC: Baowen Zheng <baowen.zheng@corigine.com>
CC: Louis Peens <louis.peens@corigine.com>

Hi Simon,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Simon-Horman/allow-user-to-offload-tc-action-to-net-device/20211118-210959
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f6ef47e5bdc6f652176e433b02317fc83049f8d7
:::::: branch date: 33 hours ago
:::::: commit date: 33 hours ago
config: microblaze-randconfig-m031-20211118 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
net/sched/act_api.c:981 tcf_register_action() error: we previously assumed 'ops->id' could be null (see line 961)

Old smatch warnings:
arch/microblaze/include/asm/thread_info.h:91 current_thread_info() error: uninitialized symbol 'sp'.

vim +981 net/sched/act_api.c

^1da177e4c3f41 Linus Torvalds   2005-04-16  943  
ddf97ccdd7cb7e WANG Cong        2016-02-22  944  int tcf_register_action(struct tc_action_ops *act,
ddf97ccdd7cb7e WANG Cong        2016-02-22  945  			struct pernet_operations *ops)
^1da177e4c3f41 Linus Torvalds   2005-04-16  946  {
1f747c26c48bb2 WANG Cong        2013-12-15  947  	struct tc_action_ops *a;
ddf97ccdd7cb7e WANG Cong        2016-02-22  948  	int ret;
^1da177e4c3f41 Linus Torvalds   2005-04-16  949  
ddf97ccdd7cb7e WANG Cong        2016-02-22  950  	if (!act->act || !act->dump || !act->init || !act->walk || !act->lookup)
76c82d7a3d24a4 Jamal Hadi Salim 2013-12-04  951  		return -EINVAL;
76c82d7a3d24a4 Jamal Hadi Salim 2013-12-04  952  
ab102b80cef28c WANG Cong        2016-10-11  953  	/* We have to register pernet ops before making the action ops visible,
ab102b80cef28c WANG Cong        2016-10-11  954  	 * otherwise tcf_action_init_1() could get a partially initialized
ab102b80cef28c WANG Cong        2016-10-11  955  	 * netns.
ab102b80cef28c WANG Cong        2016-10-11  956  	 */
ab102b80cef28c WANG Cong        2016-10-11  957  	ret = register_pernet_subsys(ops);
ab102b80cef28c WANG Cong        2016-10-11  958  	if (ret)
ab102b80cef28c WANG Cong        2016-10-11  959  		return ret;
ab102b80cef28c WANG Cong        2016-10-11  960  
adae2ff19c2701 Baowen Zheng     2021-11-18 @961  	if (ops->id) {
adae2ff19c2701 Baowen Zheng     2021-11-18  962  		ret = tcf_pernet_add_id_list(*ops->id);
adae2ff19c2701 Baowen Zheng     2021-11-18  963  		if (ret)
adae2ff19c2701 Baowen Zheng     2021-11-18  964  			goto id_err;
adae2ff19c2701 Baowen Zheng     2021-11-18  965  	}
adae2ff19c2701 Baowen Zheng     2021-11-18  966  
^1da177e4c3f41 Linus Torvalds   2005-04-16  967  	write_lock(&act_mod_lock);
1f747c26c48bb2 WANG Cong        2013-12-15  968  	list_for_each_entry(a, &act_base, head) {
eddd2cf195d6fb Eli Cohen        2019-02-10  969  		if (act->id == a->id || (strcmp(act->kind, a->kind) == 0)) {
adae2ff19c2701 Baowen Zheng     2021-11-18  970  			ret = -EEXIST;
adae2ff19c2701 Baowen Zheng     2021-11-18  971  			goto err_out;
^1da177e4c3f41 Linus Torvalds   2005-04-16  972  		}
^1da177e4c3f41 Linus Torvalds   2005-04-16  973  	}
1f747c26c48bb2 WANG Cong        2013-12-15  974  	list_add_tail(&act->head, &act_base);
^1da177e4c3f41 Linus Torvalds   2005-04-16  975  	write_unlock(&act_mod_lock);
ddf97ccdd7cb7e WANG Cong        2016-02-22  976  
^1da177e4c3f41 Linus Torvalds   2005-04-16  977  	return 0;
adae2ff19c2701 Baowen Zheng     2021-11-18  978  
adae2ff19c2701 Baowen Zheng     2021-11-18  979  err_out:
adae2ff19c2701 Baowen Zheng     2021-11-18  980  	write_unlock(&act_mod_lock);
adae2ff19c2701 Baowen Zheng     2021-11-18 @981  	tcf_pernet_del_id_list(*ops->id);
adae2ff19c2701 Baowen Zheng     2021-11-18  982  id_err:
adae2ff19c2701 Baowen Zheng     2021-11-18  983  	unregister_pernet_subsys(ops);
adae2ff19c2701 Baowen Zheng     2021-11-18  984  	return ret;
^1da177e4c3f41 Linus Torvalds   2005-04-16  985  }
62e3ba1b558e5f Patrick McHardy  2008-01-22  986  EXPORT_SYMBOL(tcf_register_action);
^1da177e4c3f41 Linus Torvalds   2005-04-16  987  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38555 bytes --]