Re: [Buildroot] [PATCH 1/1] package/lighttpd: run autoreconf

[Peter Seiderer <ps.report@gmx.net>]

Hello Fabrice,

On Sat, 20 Nov 2021 21:39:13 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Le sam. 20 nov. 2021 à 21:23, Peter Seiderer <ps.report@gmx.net> a écrit :
> >
> > Hello Farbrice,
> >
> > On Sat, 20 Nov 2021 21:15:40 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> >  
> > > Le sam. 20 nov. 2021 à 20:54, Peter Seiderer <ps.report@gmx.net> a écrit :  
> > > >
> > > > Hello Fabrice,
> > > >
> > > > On Sat, 20 Nov 2021 10:23:11 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > > >  
> > > > > Hello Peter,
> > > > >
> > > > > Le sam. 20 nov. 2021 à 00:33, Peter Seiderer <ps.report@gmx.net> a écrit :  
> > > > > >
> > > > > > Hello Fabrice,
> > > > > >
> > > > > > On Thu, 18 Nov 2021 22:06:23 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > > > > >  
> > > > > > > For an unknown reason, the build fails since bump to version 1.4.60 in
> > > > > > > commit d62b7f54f00291a50274409fb5510527fd725ffe on:
> > > > > > >
> > > > > > > array.c:140:2: error: 'for' loop initial declarations are only allowed in C99 mode
> > > > > > >   for (uint32_t i = 0; i < sz; ++i) {
> > > > > > >   ^
> > > > > > >
> > > > > > > Running autoreconf fixes the build.  
> > > > > >
> > > > > > The difference is during the configure step:
> > > > > >
> > > > > > - checking for .../host/bin/arm-none-linux-gnueabi-gcc option to accept ISO C89... none needed
> > > > > > + checking for .../host/bin/arm-none-linux-gnueabi-gcc option to enable C11 features... -std=gnu11
> > > > > >
> > > > > > And the use of the '-std=gnu11' flag for the compile steps..., any more
> > > > > > lightweight option to enable C11?  
> > > > > Then, I assume that upstream forgot to regenerate the configure script after
> > > > > https://github.com/lighttpd/lighttpd1.4/commit/73865025729897d11494de56a29c77c4fc8e5702
> > > > > I opened an issue here: https://redmine.lighttpd.net/issues/3116  
> > > >
> > > >
> > > > Thanks for effort, but upstream seems very convinced of doing nothing wrong (and
> > > > not ready to investigate further)...., despite using autoconf-2.69 (from 2012,
> > > > see lighttpd-1.4.61/configure) and:
> > > >
> > > >         $ diff -u lighttpd-1.4.59/configure lighttpd-1.4.61/configure
> > > > [...]
> > > > @@ -4440,298 +4460,6 @@
> > > >  fi
> > > >
> > > >
> > > > -   case $ac_cv_prog_cc_stdc in #(
> > > > -  no) :
> > > > -    ac_cv_prog_cc_c99=no; ac_cv_prog_cc_c89=no ;; #(
> > > > -  *) :
> > > > -    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for $CC option to accept ISO C99" >&5
> > > > -$as_echo_n "checking for $CC option to accept ISO C99... " >&6; }
> > > > -if ${ac_cv_prog_cc_c99+:} false; then :
> > > > -  $as_echo_n "(cached) " >&6
> > > > -else
> > > > -  ac_cv_prog_cc_c99=no
> > > > -ac_save_CC=$CC
> > > > [...]
> > > >
> > > >
> > > > The whole c99 check vanished...., and:
> > > >
> > > >         $ diff -u lighttpd-1.4.59/configure.ac lighttpd-1.4.61/configure.ac
> > > > [...]
> > > > @@ -61,7 +61,6 @@
> > > >
> > > >  dnl Checks for programs.
> > > >  AC_PROG_CC
> > > > -AC_PROG_CC_STDC
> > > >  AX_PROG_CC_FOR_BUILD
> > > >  LT_PATH_LD
> > > >  AC_PROG_INSTALL
> > > >
> > > >
> > > > But there is although support for the meson build system in the sources...,
> > > > maybe time to change to it?  
> > > I don't know if this is a good idea to change it before the 2021.11
> > > release as meson will probably raise its own build failures.  
> >
> > Good point for the autoreconf solution (and meson for next ;-))...  
> Sure,  if you agree, I'll let you handle the meson part ;-)

Done, see [1]...

Regards,
Peter

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20211121212937.13983-1-ps.report@gmx.net/

> >
> > Regards,
> > Peter
> >  
> > > >
> > > > Regards,
> > > > Peter
> > > >  
> > > > >  
> > > > > >
> > > > > > Regards,
> > > > > > Peter
> > > > > >  
> > > > > > >
> > > > > > > Fixes:
> > > > > > >  - http://autobuild.buildroot.org/results/0349d8fed35b0766796dd9ba3b8de6ff8bd68fe7
> > > > > > >
> > > > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > > > > > ---
> > > > > > >  package/lighttpd/lighttpd.mk | 2 ++
> > > > > > >  1 file changed, 2 insertions(+)
> > > > > > >
> > > > > > > diff --git a/package/lighttpd/lighttpd.mk b/package/lighttpd/lighttpd.mk
> > > > > > > index 9c18a6038e..c39a5db20f 100644
> > > > > > > --- a/package/lighttpd/lighttpd.mk
> > > > > > > +++ b/package/lighttpd/lighttpd.mk
> > > > > > > @@ -12,6 +12,8 @@ LIGHTTPD_LICENSE = BSD-3-Clause
> > > > > > >  LIGHTTPD_LICENSE_FILES = COPYING
> > > > > > >  LIGHTTPD_CPE_ID_VENDOR = lighttpd
> > > > > > >  LIGHTTPD_DEPENDENCIES = host-pkgconf
> > > > > > > +# Issue in configure script provided in tarball
> > > > > > > +LIGHTTPD_AUTORECONF = YES
> > > > > > >  LIGHTTPD_CONF_OPTS = \
> > > > > > >       --without-wolfssl \
> > > > > > >       --libdir=/usr/lib/lighttpd \  
> > > > > >  
> > > > > Best Regards,
> > > > >
> > > > > Fabrice  
> > > >  
> > > Best Regards,
> > >
> > > Fabrice  
> >  
> Best Regards,
> 
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot