From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD681C433EF for ; Mon, 22 Nov 2021 01:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h/1pjcldsVWcvpv0Ea56iMShd3qQ6IfLzYDOWfUnlEo=; b=lfgP6pWtO8qgMM fxX1Ow7lmrRxiO2tpOyO8Rm/WjNkkpPLXQdTxRGZFp+tWijJETORRz58mg2BOQ4c8jl6YjTnIt4/q wsY9SzydAxGvQvJvJvLJGj/cUe9xmyMJuX0SYtczqB1erjWqB+B5sy0rY/4GQEj9B62wOY34GGflk aObARsn9OJVUTRTL9r+w3ZxItAuBgz7gznY27i34G48GoPVXAEA4Tl18snOEVixqEi2l5AFRXrw4h vQAX/Gmie5yAmkXO3taRu2HdG10fWtofEJGxZZSsqmou9CvuKIIZJaKzeM1/SjoaTN//Dv3GouvsD 28fY7hH/j7gdMVZk4BVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1moy3f-00EdcT-G1; Mon, 22 Nov 2021 01:23:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1moy3c-00Edc9-5z for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 01:23:45 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7ADFC60E08; Mon, 22 Nov 2021 01:23:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637544223; bh=LfnPkYh/EaWqDlTJkbB/lROrU2JHX7ISyT3/AlpTzJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P1sxY7vRiTGJ8t4djPq1xJDXyEQE0VLsiLwfwblFRntGbsLQSra85K4Q/TCnBId1U axRyb/qdQaT29yxg/HBpYx+GV0syBKDBoa4MVsP8KsiajCv6ujPlY1sqabUxcvVuLG ZhCbMo2Lszz9QcjgfP9lq002eT/nXUJiJ9dDnXEBm0wPwN6HCXZ0lKl+4nj1shh57Q v8rit4pKGUm8mxxVIYal5xfL8fDLpK6IOblXzubzego46xGbJQX114vRN1jvts4HZ2 avMmGd3T8fr85P+iQs7wgmp8GI2Bj4iOoWay3ZHiIC5UVEBACe94sz/s1LYzeOlOEg Gl/dLYmDm3aBg== Date: Mon, 22 Nov 2021 09:23:38 +0800 From: Shawn Guo To: Fabio Estevam Cc: robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, georgemakarov1@gmail.com, peter.chen@kernel.org, otavio@ossystems.com.br Subject: Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0 Message-ID: <20211122012337.GU31998@dragon> References: <20211118095934.1138604-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211118095934.1138604-1-festevam@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211121_172344_477337_70E1FF9E X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 18, 2021 at 06:59:34AM -0300, Fabio Estevam wrote: > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > have the ESAI_TX0 functionality, not ESAI_T0. > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. > > Add an entry for the correct name and still keep the old one to > avoid potential breakage. > > Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support") > Reported-by: George Makarov > Signed-off-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6ull-pinfunc.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ull-pinfunc.h b/arch/arm/boot/dts/imx6ull-pinfunc.h > index eb025a9d4759..b492164e8cfb 100644 > --- a/arch/arm/boot/dts/imx6ull-pinfunc.h > +++ b/arch/arm/boot/dts/imx6ull-pinfunc.h > @@ -82,6 +82,11 @@ > #define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0 > #define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0 > #define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0 > +/* > + * As per the Reference Manual the correct name is ESAI_TX0. > + * Keep the old name here to avoid breakage. > + */ > #define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0 I don't see any user of it, so should be be safe just to remove it, no? Shawn > +#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0 > > #endif /* __DTS_IMX6ULL_PINFUNC_H */ > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel