From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Maurizio Lombardi <mlombard@redhat.com>,
kch@nvidia.com, linux-nvme@lists.infradead.org, hch@lst.de
Subject: Re: [PATCH] nvmet: use IOCB_NOWAIT only if the filesystem supports it.
Date: Mon, 22 Nov 2021 13:51:09 +0100 [thread overview]
Message-ID: <20211122125109.GA32499@lst.de> (raw)
In-Reply-To: <38d3f20d-36e3-c813-e00e-92e1bfb3e27c@grimberg.me>
On Mon, Nov 22, 2021 at 12:21:46PM +0200, Sagi Grimberg wrote:
> I'd suggest to fix the alignment if we are touching this.
> if (likely(!req->f.mpool_alloc) &&
> req->ns->file->f_mode & FMODE_NOWAIT &&
> nvmet_file_execute_io(req, IOCB_NOWAIT))
I had the same though and wil fix this up when applying the patch.
next prev parent reply other threads:[~2021-11-22 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 10:08 [PATCH] nvmet: use IOCB_NOWAIT only if the filesystem supports it Maurizio Lombardi
2021-11-22 10:21 ` Sagi Grimberg
2021-11-22 12:51 ` Christoph Hellwig [this message]
2021-11-23 8:35 ` Chaitanya Kulkarni
2021-11-23 16:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122125109.GA32499@lst.de \
--to=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.