From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v4 1/4] mm: support deterministic memory charging of filesystems
Date: Tue, 23 Nov 2021 04:43:58 +0800 [thread overview]
Message-ID: <202111230401.IO8MFSQM-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 7596 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20211120045011.3074840-2-almasrymina@google.com>
References: <20211120045011.3074840-2-almasrymina@google.com>
TO: Mina Almasry <almasrymina@google.com>
TO: Alexander Viro <viro@zeniv.linux.org.uk>
TO: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Johannes Weiner <hannes@cmpxchg.org>
TO: Michal Hocko <mhocko@kernel.org>
TO: Vladimir Davydov <vdavydov.dev@gmail.com>
TO: Hugh Dickins <hughd@google.com>
CC: Mina Almasry <almasrymina@google.com>
CC: Jonathan Corbet <corbet@lwn.net>
CC: Shuah Khan <skhan@linuxfoundation.org>
Hi Mina,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on hnaz-mm/master]
[also build test WARNING on linus/master v5.16-rc2 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mina-Almasry/Deterministic-charging-of-shared-memory/20211120-125229
base: https://github.com/hnaz/linux-mm master
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: i386-randconfig-s002-20211122 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/5ecf5e613f50d859803aae9bc6f8295cb199701d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mina-Almasry/Deterministic-charging-of-shared-memory/20211120-125229
git checkout 5ecf5e613f50d859803aae9bc6f8295cb199701d
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
mm/memcontrol.c:2644:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> mm/memcontrol.c:2644:17: sparse: struct mem_cgroup [noderef] __rcu *
>> mm/memcontrol.c:2644:17: sparse: struct mem_cgroup *
mm/memcontrol.c:2699:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:2699:17: sparse: struct mem_cgroup [noderef] __rcu *
mm/memcontrol.c:2699:17: sparse: struct mem_cgroup *
mm/memcontrol.c:4192:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4192:21: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4192:21: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:4194:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4194:21: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4194:21: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:4350:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4350:9: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4350:9: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:4444:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4444:9: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4444:9: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:6059:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:6059:23: sparse: struct task_struct [noderef] __rcu *
mm/memcontrol.c:6059:23: sparse: struct task_struct *
mm/memcontrol.c: note: in included file:
include/linux/memcontrol.h:779:9: sparse: sparse: context imbalance in 'folio_lruvec_lock' - wrong count at exit
include/linux/memcontrol.h:779:9: sparse: sparse: context imbalance in 'folio_lruvec_lock_irq' - wrong count at exit
include/linux/memcontrol.h:779:9: sparse: sparse: context imbalance in 'folio_lruvec_lock_irqsave' - wrong count at exit
mm/memcontrol.c:2019:6: sparse: sparse: context imbalance in 'folio_memcg_lock' - wrong count at exit
mm/memcontrol.c:2071:17: sparse: sparse: context imbalance in '__folio_memcg_unlock' - unexpected unlock
mm/memcontrol.c:5910:28: sparse: sparse: context imbalance in 'mem_cgroup_count_precharge_pte_range' - unexpected unlock
mm/memcontrol.c:6104:36: sparse: sparse: context imbalance in 'mem_cgroup_move_charge_pte_range' - unexpected unlock
vim +2644 mm/memcontrol.c
5ecf5e613f50d8 Mina Almasry 2021-11-19 2630
5ecf5e613f50d8 Mina Almasry 2021-11-19 2631 void mem_cgroup_put_name_in_seq(struct seq_file *m, struct super_block *sb)
5ecf5e613f50d8 Mina Almasry 2021-11-19 2632 {
5ecf5e613f50d8 Mina Almasry 2021-11-19 2633 struct mem_cgroup *memcg;
5ecf5e613f50d8 Mina Almasry 2021-11-19 2634 int ret = 0;
5ecf5e613f50d8 Mina Almasry 2021-11-19 2635 char *buf = __getname();
5ecf5e613f50d8 Mina Almasry 2021-11-19 2636 int len = PATH_MAX;
5ecf5e613f50d8 Mina Almasry 2021-11-19 2637
5ecf5e613f50d8 Mina Almasry 2021-11-19 2638 if (!buf)
5ecf5e613f50d8 Mina Almasry 2021-11-19 2639 return;
5ecf5e613f50d8 Mina Almasry 2021-11-19 2640
5ecf5e613f50d8 Mina Almasry 2021-11-19 2641 buf[0] = '\0';
5ecf5e613f50d8 Mina Almasry 2021-11-19 2642
5ecf5e613f50d8 Mina Almasry 2021-11-19 2643 rcu_read_lock();
5ecf5e613f50d8 Mina Almasry 2021-11-19 @2644 memcg = rcu_dereference(sb->s_memcg_to_charge);
5ecf5e613f50d8 Mina Almasry 2021-11-19 2645 if (memcg && !css_tryget_online(&memcg->css))
5ecf5e613f50d8 Mina Almasry 2021-11-19 2646 memcg = NULL;
5ecf5e613f50d8 Mina Almasry 2021-11-19 2647 rcu_read_unlock();
5ecf5e613f50d8 Mina Almasry 2021-11-19 2648
5ecf5e613f50d8 Mina Almasry 2021-11-19 2649 if (!memcg)
5ecf5e613f50d8 Mina Almasry 2021-11-19 2650 return;
5ecf5e613f50d8 Mina Almasry 2021-11-19 2651
5ecf5e613f50d8 Mina Almasry 2021-11-19 2652 ret = cgroup_path(memcg->css.cgroup, buf + len / 2, len / 2);
5ecf5e613f50d8 Mina Almasry 2021-11-19 2653 if (ret >= len / 2)
5ecf5e613f50d8 Mina Almasry 2021-11-19 2654 strcpy(buf, "?");
5ecf5e613f50d8 Mina Almasry 2021-11-19 2655 else {
5ecf5e613f50d8 Mina Almasry 2021-11-19 2656 char *p = mangle_path(buf, buf + len / 2, " \t\n\\");
5ecf5e613f50d8 Mina Almasry 2021-11-19 2657
5ecf5e613f50d8 Mina Almasry 2021-11-19 2658 if (p)
5ecf5e613f50d8 Mina Almasry 2021-11-19 2659 *p = '\0';
5ecf5e613f50d8 Mina Almasry 2021-11-19 2660 else
5ecf5e613f50d8 Mina Almasry 2021-11-19 2661 strcpy(buf, "?");
5ecf5e613f50d8 Mina Almasry 2021-11-19 2662 }
5ecf5e613f50d8 Mina Almasry 2021-11-19 2663
5ecf5e613f50d8 Mina Almasry 2021-11-19 2664 css_put(&memcg->css);
5ecf5e613f50d8 Mina Almasry 2021-11-19 2665 if (buf[0] != '\0')
5ecf5e613f50d8 Mina Almasry 2021-11-19 2666 seq_printf(m, ",memcg=%s", buf);
5ecf5e613f50d8 Mina Almasry 2021-11-19 2667
5ecf5e613f50d8 Mina Almasry 2021-11-19 2668 __putname(buf);
5ecf5e613f50d8 Mina Almasry 2021-11-19 2669 }
5ecf5e613f50d8 Mina Almasry 2021-11-19 2670
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38300 bytes --]
next reply other threads:[~2021-11-22 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 20:43 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-20 4:50 [PATCH v4 0/4] Deterministic charging of shared memory Mina Almasry
[not found] ` <20211120045011.3074840-1-almasrymina-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2021-11-20 4:50 ` [PATCH v4 1/4] mm: support deterministic memory charging of filesystems Mina Almasry
2021-11-20 4:50 ` Mina Almasry
2021-11-20 7:53 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111230401.IO8MFSQM-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.