From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
Cc: "Forest Bond" <forest@alittletooquiet.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Aldas Taraškevičius" <aldas60@gmail.com>,
"Karolina Drobnik" <karolinadrobnik@gmail.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Lucas Henneman" <lucas.henneman@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: rename variable bHWRadioOff
Date: Tue, 23 Nov 2021 21:08:32 +0100 [thread overview]
Message-ID: <20211123200832.GA3206@tom-desktop> (raw)
In-Reply-To: <20211121112000.632456-1-alb3rt0.m3rciai@gmail.com>
On Sun, Nov 21, 2021 at 12:19:59PM +0100, Alberto Merciai wrote:
> Replace camelcase hungarian notated variable "bHWRadioOff"
> into linux kernel coding style equivalent variable "hw_radio_off".
>
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
> ---
> drivers/staging/vt6655/device.h | 2 +-
> drivers/staging/vt6655/device_main.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index ff171acc11f4..e9d1b56d8809 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -229,7 +229,7 @@ struct vnt_private {
> /* GPIO Radio Control */
> unsigned char byRadioCtl;
> unsigned char byGPIO;
> - bool bHWRadioOff;
> + bool hw_radio_off;
> bool bPrvActive4RadioOFF;
> bool bGPIOBlockRead;
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 1f98f2b069c4..897d70cf32b8 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -373,7 +373,7 @@ static void device_init_registers(struct vnt_private *priv)
>
> priv->byRadioCtl = SROMbyReadEmbedded(priv->port_offset,
> EEP_OFS_RADIOCTL);
> - priv->bHWRadioOff = false;
> + priv->hw_radio_off = false;
>
> if (priv->byRadioCtl & EEP_RADIOCTL_ENABLE) {
> /* Get GPIO */
> @@ -383,10 +383,10 @@ static void device_init_registers(struct vnt_private *priv)
> !(priv->byRadioCtl & EEP_RADIOCTL_INV)) ||
> (!(priv->byGPIO & GPIO0_DATA) &&
> (priv->byRadioCtl & EEP_RADIOCTL_INV)))
> - priv->bHWRadioOff = true;
> + priv->hw_radio_off = true;
> }
>
> - if (priv->bHWRadioOff || priv->bRadioControlOff)
> + if (priv->hw_radio_off || priv->bRadioControlOff)
> CARDbRadioPowerOff(priv);
>
> /* get Permanent network address */
> --
> 2.25.1
>
Look's okay.
Acked-by: Tommaso Merciai <tommaso.merciai@gmail.com>
Regards,
Tommaso
next prev parent reply other threads:[~2021-11-23 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 11:19 [PATCH] staging: vt6655: rename variable bHWRadioOff Alberto Merciai
2021-11-23 20:08 ` Tommaso Merciai [this message]
2021-11-23 22:15 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123200832.GA3206@tom-desktop \
--to=tomm.merciai@gmail.com \
--cc=alb3rt0.m3rciai@gmail.com \
--cc=aldas60@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.henneman@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.