From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63049C433F5 for ; Wed, 24 Nov 2021 06:39:55 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-434-JqHhdj3nNzWuqwuq_G1QGw-1; Wed, 24 Nov 2021 01:39:50 -0500 X-MC-Unique: JqHhdj3nNzWuqwuq_G1QGw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70A8B1DDE4; Wed, 24 Nov 2021 06:39:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 520C417D61; Wed, 24 Nov 2021 06:39:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 048271809C8A; Wed, 24 Nov 2021 06:39:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AO6diN0002568 for ; Wed, 24 Nov 2021 01:39:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id 557C71121318; Wed, 24 Nov 2021 06:39:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 511EC1121315 for ; Wed, 24 Nov 2021 06:39:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B429181E063 for ; Wed, 24 Nov 2021 06:39:41 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-35-YCE6xIYbMWCb1W4Ey1gYrg-1; Wed, 24 Nov 2021 01:39:38 -0500 X-MC-Unique: YCE6xIYbMWCb1W4Ey1gYrg-1 Received: by verein.lst.de (Postfix, from userid 2407) id D92CF68AFE; Wed, 24 Nov 2021 07:39:34 +0100 (CET) Date: Wed, 24 Nov 2021 07:39:34 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Message-ID: <20211124063934.GC6889@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-15-hch@lst.de> <20211123223642.GI266024@magnolia> MIME-Version: 1.0 In-Reply-To: <20211123223642.GI266024@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: nvdimm@lists.linux.dev, Mike Snitzer , linux-s390@vger.kernel.org, linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Dan Williams , linux-ext4@vger.kernel.org, Ira Weiny , Christoph Hellwig Subject: Re: [dm-devel] [PATCH 14/29] fsdax: simplify the pgoff calculation X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong wrote: > > - phys_addr_t phys_off = (start_sect + sector) * 512; > > - > > - if (pgoff) > > - *pgoff = PHYS_PFN(phys_off); > > - if (phys_off % PAGE_SIZE || size % PAGE_SIZE) > > AFAICT, we're relying on fs_dax_get_by_bdev to have validated this > previously, which is why the error return stuff goes away? Exactly. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0137BC433EF for ; Wed, 24 Nov 2021 06:39:44 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HzWZl27Znz2ymP for ; Wed, 24 Nov 2021 17:39:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HzWZg5jgxz2xsv for ; Wed, 24 Nov 2021 17:39:39 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id D92CF68AFE; Wed, 24 Nov 2021 07:39:34 +0100 (CET) Date: Wed, 24 Nov 2021 07:39:34 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Subject: Re: [PATCH 14/29] fsdax: simplify the pgoff calculation Message-ID: <20211124063934.GC6889@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-15-hch@lst.de> <20211123223642.GI266024@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123223642.GI266024@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Mike Snitzer , linux-s390@vger.kernel.org, linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Dan Williams , linux-ext4@vger.kernel.org, Ira Weiny , Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong wrote: > > - phys_addr_t phys_off = (start_sect + sector) * 512; > > - > > - if (pgoff) > > - *pgoff = PHYS_PFN(phys_off); > > - if (phys_off % PAGE_SIZE || size % PAGE_SIZE) > > AFAICT, we're relying on fs_dax_get_by_bdev to have validated this > previously, which is why the error return stuff goes away? Exactly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8223FC433FE for ; Wed, 24 Nov 2021 06:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237376AbhKXGms (ORCPT ); Wed, 24 Nov 2021 01:42:48 -0500 Received: from verein.lst.de ([213.95.11.211]:35823 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbhKXGmr (ORCPT ); Wed, 24 Nov 2021 01:42:47 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D92CF68AFE; Wed, 24 Nov 2021 07:39:34 +0100 (CET) Date: Wed, 24 Nov 2021 07:39:34 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Dan Williams , Mike Snitzer , Ira Weiny , dm-devel@redhat.com, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 14/29] fsdax: simplify the pgoff calculation Message-ID: <20211124063934.GC6889@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-15-hch@lst.de> <20211123223642.GI266024@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123223642.GI266024@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong wrote: > > - phys_addr_t phys_off = (start_sect + sector) * 512; > > - > > - if (pgoff) > > - *pgoff = PHYS_PFN(phys_off); > > - if (phys_off % PAGE_SIZE || size % PAGE_SIZE) > > AFAICT, we're relying on fs_dax_get_by_bdev to have validated this > previously, which is why the error return stuff goes away? Exactly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87A7EC433EF for ; Wed, 24 Nov 2021 06:39:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1E04E80D09; Wed, 24 Nov 2021 06:39:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KHHQzE5o-LoR; Wed, 24 Nov 2021 06:39:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id D017980CD4; Wed, 24 Nov 2021 06:39:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A2325C001E; Wed, 24 Nov 2021 06:39:40 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 570ABC0012 for ; Wed, 24 Nov 2021 06:39:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3AF0940126 for ; Wed, 24 Nov 2021 06:39:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eh2MX6xZYAuC for ; Wed, 24 Nov 2021 06:39:38 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp2.osuosl.org (Postfix) with ESMTPS id 792E340003 for ; Wed, 24 Nov 2021 06:39:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D92CF68AFE; Wed, 24 Nov 2021 07:39:34 +0100 (CET) Date: Wed, 24 Nov 2021 07:39:34 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Subject: Re: [PATCH 14/29] fsdax: simplify the pgoff calculation Message-ID: <20211124063934.GC6889@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-15-hch@lst.de> <20211123223642.GI266024@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211123223642.GI266024@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: nvdimm@lists.linux.dev, Mike Snitzer , linux-s390@vger.kernel.org, linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Dan Williams , linux-ext4@vger.kernel.org, Ira Weiny , Christoph Hellwig X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong wrote: > > - phys_addr_t phys_off = (start_sect + sector) * 512; > > - > > - if (pgoff) > > - *pgoff = PHYS_PFN(phys_off); > > - if (phys_off % PAGE_SIZE || size % PAGE_SIZE) > > AFAICT, we're relying on fs_dax_get_by_bdev to have validated this > previously, which is why the error return stuff goes away? Exactly. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization