From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8458511867816527987==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 10/11] hda: cs35l41: Add support for CS35L41 in HDA systems Date: Wed, 24 Nov 2021 11:18:15 +0800 Message-ID: <202111241121.KkNm9IFL-lkp@intel.com> In-Reply-To: <20211123163149.1530535-11-tanureal@opensource.cirrus.com> List-Id: --===============8458511867816527987== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Lucas, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20211123] [cannot apply to broonie-sound/for-next tiwai-sound/for-next rafael-pm/linu= x-next linus/master v5.16-rc2 v5.16-rc1 v5.15 v5.16-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Lucas-Tanure/Add-support-f= or-Legion-7-16ACHg6-laptop/20211124-003454 base: aacdecce8147c20b01f865b4e214bb8dbe8c4af1 config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20211124= /202111241121.KkNm9IFL-lkp(a)intel.com/config.gz) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/57fb53c7cacc1a5e603bd248f= 5609e48582f19ff git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Lucas-Tanure/Add-support-for-Legio= n-7-16ACHg6-laptop/20211124-003454 git checkout 57fb53c7cacc1a5e603bd248f5609e48582f19ff # save the config file to linux build tree COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= ARCH=3Dm68k = If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> sound/pci/hda/patch_realtek.c:6546:6: warning: no previous prototype for= 'alc287_legion_16achg6_playback_hook' [-Wmissing-prototypes] 6546 | void alc287_legion_16achg6_playback_hook(struct hda_pcm_stream *= hinfo, struct hda_codec *codec, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- >> sound/pci/hda/cs35l41_hda.c:179:5: warning: no previous prototype for 'c= s35l41_hda_bind' [-Wmissing-prototypes] 179 | int cs35l41_hda_bind(struct device *dev, struct device *master, = void *master_data) | ^~~~~~~~~~~~~~~~ sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_hda_read_acpi': sound/pci/hda/cs35l41_hda.c:314:59: error: invalid use of undefined type= 'struct acpi_device' 314 | cs35l41->reset_gpio =3D fwnode_gpiod_get_index(&adev->fw= node, "reset", index, GPIOD_OUT_LOW, | ^~ -- >> sound/pci/hda/../../soc/codecs/cs35l41-lib.c:54:6: warning: no previous = prototype for 'cs35l41_readable_reg' [-Wmissing-prototypes] 54 | bool cs35l41_readable_reg(struct device *dev, unsigned int reg) | ^~~~~~~~~~~~~~~~~~~~ >> sound/pci/hda/../../soc/codecs/cs35l41-lib.c:338:6: warning: no previous= prototype for 'cs35l41_precious_reg' [-Wmissing-prototypes] 338 | bool cs35l41_precious_reg(struct device *dev, unsigned int reg) | ^~~~~~~~~~~~~~~~~~~~ >> sound/pci/hda/../../soc/codecs/cs35l41-lib.c:351:6: warning: no previous= prototype for 'cs35l41_volatile_reg' [-Wmissing-prototypes] 351 | bool cs35l41_volatile_reg(struct device *dev, unsigned int reg) | ^~~~~~~~~~~~~~~~~~~~ vim +/alc287_legion_16achg6_playback_hook +6546 sound/pci/hda/patch_realtek= .c 6545 = > 6546 void alc287_legion_16achg6_playback_hook(struct hda_pcm_stream *hinf= o, struct hda_codec *codec, 6547 struct snd_pcm_substream *sub, int action) 6548 { 6549 struct alc_spec *spec =3D codec->spec; 6550 unsigned int rx_slot; 6551 int i =3D 0; 6552 = 6553 switch (action) { 6554 case HDA_GEN_PCM_ACT_PREPARE: 6555 rx_slot =3D 0; 6556 i =3D find_comp_by_dev_name(spec, "i2c-CLSA0100:00-cs35l41-hda.0"); 6557 if (i >=3D 0) 6558 spec->comps[i].set_channel_map(spec->comps[i].dev, 0, NULL, 1, &r= x_slot); 6559 = 6560 rx_slot =3D 1; 6561 i =3D find_comp_by_dev_name(spec, "i2c-CLSA0100:00-cs35l41-hda.1"); 6562 if (i >=3D 0) 6563 spec->comps[i].set_channel_map(spec->comps[i].dev, 0, NULL, 1, &r= x_slot); 6564 break; 6565 } 6566 = 6567 for (i =3D 0; i < HDA_MAX_COMPONENTS; i++) { 6568 if (spec->comps[i].dev) 6569 spec->comps[i].playback_hook(spec->comps[i].dev, action); 6570 } 6571 = 6572 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8458511867816527987==--