From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: lvivier@redhat.com, virtualization@lists.linux-foundation.org,
eperezma@redhat.com, Si-Wei Liu <si-wei.liu@oracle.com>
Subject: Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques
Date: Thu, 25 Nov 2021 02:22:38 -0500 [thread overview]
Message-ID: <20211125022223-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20211125070126.GB211101@mtl-vdi-166.wap.labs.mlnx>
On Thu, Nov 25, 2021 at 09:01:26AM +0200, Eli Cohen wrote:
> On Wed, Nov 24, 2021 at 03:55:34PM -0800, Si-Wei Liu wrote:
> >
> >
> > On 11/24/2021 9:19 AM, Eli Cohen wrote:
> > > Increase the limit on the maximum number of supported virtqueues to 256
> > > to match hardware capabilities.
> > >
> > > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
> > > ---
> > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index ed7a63e48335..8f2918a8efc6 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
> > > /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> > > * provides for driver space allocation
> > > */
> > > -#define MLX5_MAX_SUPPORTED_VQS 16
> > > +#define MLX5_MAX_SUPPORTED_VQS 256
> > Did we check how much increase of memory footprint ended up with on struct
> > mlx5_vdpa_net?
> >
>
> The grow is 1048 * 240 = 251520 bytes.
Pls include this info in the commit log.
> > -Siwei
> >
> > > static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> > > {
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-11-25 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211124171953.57858-1-elic@nvidia.com>
2021-11-24 23:55 ` [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques Si-Wei Liu
[not found] ` <20211125070126.GB211101@mtl-vdi-166.wap.labs.mlnx>
2021-11-25 7:22 ` Michael S. Tsirkin [this message]
2021-11-25 4:40 ` Jason Wang
2021-11-25 7:21 ` Michael S. Tsirkin
[not found] ` <20211125072953.GA213638@mtl-vdi-166.wap.labs.mlnx>
2021-11-25 16:22 ` Michael S. Tsirkin
2021-11-29 22:59 ` Si-Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211125022223-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=lvivier@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.