From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F35C43217 for ; Thu, 25 Nov 2021 12:48:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343837AbhKYMvw (ORCPT ); Thu, 25 Nov 2021 07:51:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:45206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352585AbhKYMtr (ORCPT ); Thu, 25 Nov 2021 07:49:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9C3CD61106; Thu, 25 Nov 2021 12:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637844395; bh=Dy8qixfk57rxiBBpn+qUTpl4vWEooJOjRKRfTNJLD/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bij3g2C/t7Mf00IbUdKDfY+HDz0dRyV/6sQFImcbYYDCwQTYPPh3g/g7cXQD8rb9s 0QsFyQ7NrGavpa385+PNBioY3/GJj3rLoOHrg1dDsg9Q8RO5sKL3V3vruiD92w33bx rYMIWtoc5FoCU5WvyG3cDgEsxophgKKGjOTpflxQRNYwTKjPLkwIq4qdRb+u2lw2zd 8hVrfgvGxq/oO8zbxocOABbESreRdJjQ5FuO9yF1CEN83PYMzZFyIXhwpLS5TDET2q je/wkVobQnaA8h3+CtFVbsKdqAJPoFYwkonmG2d3vlKGV+NysCh5yQiIaxZ95Q7Tm6 C0W9to3icYTvg== Received: by pali.im (Postfix) id 5B737EDE; Thu, 25 Nov 2021 13:46:35 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , =?UTF-8?q?Marek=20Beh=C3=BAn?= Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/15] PCI: mvebu: Disallow mapping interrupts on emulated bridges Date: Thu, 25 Nov 2021 13:45:55 +0100 Message-Id: <20211125124605.25915-6-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20211125124605.25915-1-pali@kernel.org> References: <20211125124605.25915-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Interrupt support on mvebu emulated bridges is not implemented yet. So properly indicate return value to callers that they cannot request interrupts from emulated bridge. Signed-off-by: Pali Rohár Cc: stable@vger.kernel.org --- drivers/pci/controller/pci-mvebu.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index 19c6ee298442..a3df352d440e 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -705,6 +705,15 @@ static struct pci_ops mvebu_pcie_ops = { .write = mvebu_pcie_wr_conf, }; +static int mvebu_pcie_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) +{ + /* Interrupt support on mvebu emulated bridges is not implemented yet */ + if (dev->bus->number == 0) + return 0; /* Proper return code 0 == NO_IRQ */ + + return of_irq_parse_and_map_pci(dev, slot, pin); +} + static resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev, const struct resource *res, resource_size_t start, @@ -1119,6 +1128,7 @@ static int mvebu_pcie_probe(struct platform_device *pdev) bridge->sysdata = pcie; bridge->ops = &mvebu_pcie_ops; bridge->align_resource = mvebu_pcie_align_resource; + bridge->map_irq = mvebu_pcie_map_irq; return pci_host_probe(bridge); } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58ED4C433EF for ; Thu, 25 Nov 2021 12:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qI+tXEyLweOdEo8sPyNBeZq2k76JUeAaq8t77v2MXso=; b=tcGXwxkj3jdWRO wJ51x/0YieLHOefpVKqCLyoLPhiPLAWkKPGWEGdCjl+Ao1KCx7KROH/Z0u9ERG4UG360/um7pPd1B jQlvU4DDc8w/hCl/ryAMtmE0XIPGD6UCO5jmeUXh9j6goSHz3zPv6QwbXci6BDKS1eLnINn6/QQL6 l8MXb/h7Ju7sX2GhGF7CVqNkWZKAZ++xwkQ1U9gEIN3nMtDybLEpjFGgKdQze9AFzZdZBekYbZMVY 96z0Cg56+JaW2YuDujoV7aEZXNiemCtPS/UUm+ccm2OrNpvMYn6n86WTgbQqYGNsN7ZUpxFAP1vbJ c8S2HAsJIrkWnGIKkOJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqEB9-007TaW-RT; Thu, 25 Nov 2021 12:48:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqE96-007Sod-3h for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 12:46:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9C3CD61106; Thu, 25 Nov 2021 12:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637844395; bh=Dy8qixfk57rxiBBpn+qUTpl4vWEooJOjRKRfTNJLD/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bij3g2C/t7Mf00IbUdKDfY+HDz0dRyV/6sQFImcbYYDCwQTYPPh3g/g7cXQD8rb9s 0QsFyQ7NrGavpa385+PNBioY3/GJj3rLoOHrg1dDsg9Q8RO5sKL3V3vruiD92w33bx rYMIWtoc5FoCU5WvyG3cDgEsxophgKKGjOTpflxQRNYwTKjPLkwIq4qdRb+u2lw2zd 8hVrfgvGxq/oO8zbxocOABbESreRdJjQ5FuO9yF1CEN83PYMzZFyIXhwpLS5TDET2q je/wkVobQnaA8h3+CtFVbsKdqAJPoFYwkonmG2d3vlKGV+NysCh5yQiIaxZ95Q7Tm6 C0W9to3icYTvg== Received: by pali.im (Postfix) id 5B737EDE; Thu, 25 Nov 2021 13:46:35 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , =?UTF-8?q?Marek=20Beh=C3=BAn?= Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/15] PCI: mvebu: Disallow mapping interrupts on emulated bridges Date: Thu, 25 Nov 2021 13:45:55 +0100 Message-Id: <20211125124605.25915-6-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20211125124605.25915-1-pali@kernel.org> References: <20211125124605.25915-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_044636_217621_69E8516B X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SW50ZXJydXB0IHN1cHBvcnQgb24gbXZlYnUgZW11bGF0ZWQgYnJpZGdlcyBpcyBub3QgaW1wbGVt ZW50ZWQgeWV0LgoKU28gcHJvcGVybHkgaW5kaWNhdGUgcmV0dXJuIHZhbHVlIHRvIGNhbGxlcnMg dGhhdCB0aGV5IGNhbm5vdCByZXF1ZXN0CmludGVycnVwdHMgZnJvbSBlbXVsYXRlZCBicmlkZ2Uu CgpTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPgpDYzogc3RhYmxl QHZnZXIua2VybmVsLm9yZwotLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1LmMg fCAxMCArKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1LmMgYi9kcml2ZXJzL3BjaS9j b250cm9sbGVyL3BjaS1tdmVidS5jCmluZGV4IDE5YzZlZTI5ODQ0Mi4uYTNkZjM1MmQ0NDBlIDEw MDY0NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1tdmVidS5jCisrKyBiL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1LmMKQEAgLTcwNSw2ICs3MDUsMTUgQEAgc3RhdGlj IHN0cnVjdCBwY2lfb3BzIG12ZWJ1X3BjaWVfb3BzID0gewogCS53cml0ZSA9IG12ZWJ1X3BjaWVf d3JfY29uZiwKIH07CiAKK3N0YXRpYyBpbnQgbXZlYnVfcGNpZV9tYXBfaXJxKGNvbnN0IHN0cnVj dCBwY2lfZGV2ICpkZXYsIHU4IHNsb3QsIHU4IHBpbikKK3sKKwkvKiBJbnRlcnJ1cHQgc3VwcG9y dCBvbiBtdmVidSBlbXVsYXRlZCBicmlkZ2VzIGlzIG5vdCBpbXBsZW1lbnRlZCB5ZXQgKi8KKwlp ZiAoZGV2LT5idXMtPm51bWJlciA9PSAwKQorCQlyZXR1cm4gMDsgLyogUHJvcGVyIHJldHVybiBj b2RlIDAgPT0gTk9fSVJRICovCisKKwlyZXR1cm4gb2ZfaXJxX3BhcnNlX2FuZF9tYXBfcGNpKGRl diwgc2xvdCwgcGluKTsKK30KKwogc3RhdGljIHJlc291cmNlX3NpemVfdCBtdmVidV9wY2llX2Fs aWduX3Jlc291cmNlKHN0cnVjdCBwY2lfZGV2ICpkZXYsCiAJCQkJCQkgY29uc3Qgc3RydWN0IHJl c291cmNlICpyZXMsCiAJCQkJCQkgcmVzb3VyY2Vfc2l6ZV90IHN0YXJ0LApAQCAtMTExOSw2ICsx MTI4LDcgQEAgc3RhdGljIGludCBtdmVidV9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCiAJYnJpZGdlLT5zeXNkYXRhID0gcGNpZTsKIAlicmlkZ2UtPm9wcyA9ICZtdmVi dV9wY2llX29wczsKIAlicmlkZ2UtPmFsaWduX3Jlc291cmNlID0gbXZlYnVfcGNpZV9hbGlnbl9y ZXNvdXJjZTsKKwlicmlkZ2UtPm1hcF9pcnEgPSBtdmVidV9wY2llX21hcF9pcnE7CiAKIAlyZXR1 cm4gcGNpX2hvc3RfcHJvYmUoYnJpZGdlKTsKIH0KLS0gCjIuMjAuMQoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK