From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40331C433FE for ; Fri, 26 Nov 2021 10:37:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0541F6ECD4; Fri, 26 Nov 2021 10:37:44 +0000 (UTC) Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id F10396EF38; Thu, 25 Nov 2021 13:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1637848282; x=1669384282; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IZMfh96pc1eATKuBd9LQI2ag0STcz/D7Jqsa3v1w6EA=; b=jgzgG10w9vP4Gs2lzNKK5OcYWIoSjFCceX8DfO4YOJzZrwuB6uWkU+lh N/CD5xSySDkCXP39gNpoQDqbD9npZ2jEJ67qoJ4Y1m4s8/63qSGXmtpdX v5+YKWgrrJK5qrNiqgPcu2XvrW3x/1/v+fDfTHjFniB74T+Az0yq/bY+d QuIqeYSQVmODoOG7SlniN07TqY+gmVtrFhfcvJrzsUfO+ayb/EoOACknS Ecc+Tik9aU72uOh3QCtDj7VvFxOM7Md34cuvpJxb4ZiUm7St+4SVFi2zd fQeBhoivxxvTPhX68ikboM3RrwAH98C6zhGLcjst+LHcPtZt5qNv1CAHJ A==; Date: Thu, 25 Nov 2021 14:51:19 +0100 From: Vincent Whitchurch To: "jim.cromie@gmail.com" Subject: Re: [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC Message-ID: <20211125135119.GA7625@axis.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> <20211111220206.121610-9-jim.cromie@gmail.com> <20211112114953.GA1381@axis.com> <20211116104631.195cbd0b@eldfell> <20211118172401.0b4d722e@eldfell> <41ea83b2-a707-cb6f-521e-070bb12502de@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Fri, 26 Nov 2021 10:37:43 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "quic_saipraka@quicinc.com" , Jason Baron , Catalin Marinas , dri-devel , Will Deacon , "maz@kernel.org" , amd-gfx mailing list , Ingo Molnar , Daniel Vetter , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , Intel Graphics Development , Steven Rostedt , Pekka Paalanen , Sean Paul , "intel-gvt-dev@lists.freedesktop.org" , Linux ARM , Sean Paul , Greg KH , LKML , "quic_psodagud@quicinc.com" , "mathieu.desnoyers@efficios.com" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, Nov 19, 2021 at 11:46:31PM +0100, jim.cromie@gmail.com wrote: > Vincent's code has the macro magic to define that event, which IIUC > is what makes it controllable by ftrace, and therefore acceptable in > principle to Steve. > Would there be any reason to expand his set of 2 events into dev_dbg, > pr_debug etc varieties ? > (ie any value to separating dev, !dev ?, maybe so > > Sean's code uses trace_array_printk primarily, which is EXPORTed, > which is a virtue. > > Vincents code does > +/* > + * This code is heavily based on __ftrace_trace_stack(). > + * > + * Allow 4 levels of nesting: normal, softirq, irq, NMI. > + */ > > to implement > > +static void dynamic_trace(const char *fmt, va_list args) > > Has this __ftrace_trace_stack() code been bundled into or hidden under > a supported interface ? > > would it look anything like trace_array_printk() ? > > what problem is that code solving inside dynamic-debug.c ? I'm not sure I fully understand all of your questions, but perhaps this thread with Steven's reply to the first version of my patchset will answer some of them: https://lore.kernel.org/lkml/20200723112644.7759f82f@oasis.local.home/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B254EC433FE for ; Mon, 29 Nov 2021 13:00:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FF5F6FD07; Mon, 29 Nov 2021 13:00:55 +0000 (UTC) Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id F10396EF38; Thu, 25 Nov 2021 13:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1637848282; x=1669384282; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IZMfh96pc1eATKuBd9LQI2ag0STcz/D7Jqsa3v1w6EA=; b=jgzgG10w9vP4Gs2lzNKK5OcYWIoSjFCceX8DfO4YOJzZrwuB6uWkU+lh N/CD5xSySDkCXP39gNpoQDqbD9npZ2jEJ67qoJ4Y1m4s8/63qSGXmtpdX v5+YKWgrrJK5qrNiqgPcu2XvrW3x/1/v+fDfTHjFniB74T+Az0yq/bY+d QuIqeYSQVmODoOG7SlniN07TqY+gmVtrFhfcvJrzsUfO+ayb/EoOACknS Ecc+Tik9aU72uOh3QCtDj7VvFxOM7Md34cuvpJxb4ZiUm7St+4SVFi2zd fQeBhoivxxvTPhX68ikboM3RrwAH98C6zhGLcjst+LHcPtZt5qNv1CAHJ A==; Date: Thu, 25 Nov 2021 14:51:19 +0100 From: Vincent Whitchurch To: "jim.cromie@gmail.com" Message-ID: <20211125135119.GA7625@axis.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> <20211111220206.121610-9-jim.cromie@gmail.com> <20211112114953.GA1381@axis.com> <20211116104631.195cbd0b@eldfell> <20211118172401.0b4d722e@eldfell> <41ea83b2-a707-cb6f-521e-070bb12502de@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Mon, 29 Nov 2021 13:00:35 +0000 Subject: Re: [Intel-gfx] [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "quic_saipraka@quicinc.com" , Jason Baron , Catalin Marinas , dri-devel , Will Deacon , "maz@kernel.org" , amd-gfx mailing list , Ingo Molnar , Daniel Vetter , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , Intel Graphics Development , Steven Rostedt , Pekka Paalanen , Sean Paul , "intel-gvt-dev@lists.freedesktop.org" , Linux ARM , Greg KH , LKML , "quic_psodagud@quicinc.com" , "mathieu.desnoyers@efficios.com" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Nov 19, 2021 at 11:46:31PM +0100, jim.cromie@gmail.com wrote: > Vincent's code has the macro magic to define that event, which IIUC > is what makes it controllable by ftrace, and therefore acceptable in > principle to Steve. > Would there be any reason to expand his set of 2 events into dev_dbg, > pr_debug etc varieties ? > (ie any value to separating dev, !dev ?, maybe so > > Sean's code uses trace_array_printk primarily, which is EXPORTed, > which is a virtue. > > Vincents code does > +/* > + * This code is heavily based on __ftrace_trace_stack(). > + * > + * Allow 4 levels of nesting: normal, softirq, irq, NMI. > + */ > > to implement > > +static void dynamic_trace(const char *fmt, va_list args) > > Has this __ftrace_trace_stack() code been bundled into or hidden under > a supported interface ? > > would it look anything like trace_array_printk() ? > > what problem is that code solving inside dynamic-debug.c ? I'm not sure I fully understand all of your questions, but perhaps this thread with Steven's reply to the first version of my patchset will answer some of them: https://lore.kernel.org/lkml/20200723112644.7759f82f@oasis.local.home/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24006C433F5 for ; Thu, 25 Nov 2021 13:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349619AbhKYN4e (ORCPT ); Thu, 25 Nov 2021 08:56:34 -0500 Received: from smtp1.axis.com ([195.60.68.17]:61038 "EHLO smtp1.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355299AbhKYNye (ORCPT ); Thu, 25 Nov 2021 08:54:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1637848283; x=1669384283; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IZMfh96pc1eATKuBd9LQI2ag0STcz/D7Jqsa3v1w6EA=; b=h6XUS44P03hv5Yq4q5MR+cKyhGt8qGuJWglOJNQ3Diprb3VZAJDmhaGx 2fOdyVNUAQMuUyYLMtHyzBUSSRqDy3msfYwRKc76UHGmHj++LBDiujHs3 3xw+/okM+5JNQFVBfhiN+LWhyno9HNtFxPMVM9c+OH3jnMirXv6U4+2f6 WZtZXrwzWyXChzmHsfM9eDQNlB0kfCXJE4zxLx1zwne5QUrtwdEzsqvM8 dSYRzOj0p6UDhdggEFMxsCTGIarczkazUIC/S9AHEbSJU+HuTaER1IIVq UnyppeWmksgOuc7F9eVsXL1VvD6QKA+wK8Oq8x6kNRgG1R6NwLH8Bdwsx Q==; Date: Thu, 25 Nov 2021 14:51:19 +0100 From: Vincent Whitchurch To: "jim.cromie@gmail.com" CC: Jason Baron , Pekka Paalanen , Sean Paul , Sean Paul , "quic_saipraka@quicinc.com" , Catalin Marinas , dri-devel , Will Deacon , "maz@kernel.org" , amd-gfx mailing list , Ingo Molnar , Daniel Vetter , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , Intel Graphics Development , Steven Rostedt , "intel-gvt-dev@lists.freedesktop.org" , Linux ARM , Greg KH , LKML , "quic_psodagud@quicinc.com" , "mathieu.desnoyers@efficios.com" Subject: Re: [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC Message-ID: <20211125135119.GA7625@axis.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> <20211111220206.121610-9-jim.cromie@gmail.com> <20211112114953.GA1381@axis.com> <20211116104631.195cbd0b@eldfell> <20211118172401.0b4d722e@eldfell> <41ea83b2-a707-cb6f-521e-070bb12502de@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Nov 19, 2021 at 11:46:31PM +0100, jim.cromie@gmail.com wrote: > Vincent's code has the macro magic to define that event, which IIUC > is what makes it controllable by ftrace, and therefore acceptable in > principle to Steve. > Would there be any reason to expand his set of 2 events into dev_dbg, > pr_debug etc varieties ? > (ie any value to separating dev, !dev ?, maybe so > > Sean's code uses trace_array_printk primarily, which is EXPORTed, > which is a virtue. > > Vincents code does > +/* > + * This code is heavily based on __ftrace_trace_stack(). > + * > + * Allow 4 levels of nesting: normal, softirq, irq, NMI. > + */ > > to implement > > +static void dynamic_trace(const char *fmt, va_list args) > > Has this __ftrace_trace_stack() code been bundled into or hidden under > a supported interface ? > > would it look anything like trace_array_printk() ? > > what problem is that code solving inside dynamic-debug.c ? I'm not sure I fully understand all of your questions, but perhaps this thread with Steven's reply to the first version of my patchset will answer some of them: https://lore.kernel.org/lkml/20200723112644.7759f82f@oasis.local.home/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC2A3C433F5 for ; Thu, 25 Nov 2021 13:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y5URxtNAvhXVunRbE3mURcew5vW5gGKt7oE4/f4tzrQ=; b=pnUgZFEIlggUPQ 08HhzY2QCg8CoYPhNVSu6d3x45Y9M02GVcXG7MDGmf7I/2TBjVcy+xXSN+pAgFwanjLMbK8OFFHdc Om8Xoxu8AHj5qg4ACXXzK2q1+xsD9a4wVLX9naw/u8xV0hLPb84q8yLjU5gjzN64wo5U3dAPDot6T +bfTdx/kYdQIyNFLgSHGtcwvBRTALT3FGGTXsg3jq8KPAiKYvQ+nc5TheeH4RaKH1JzjZowZcgvbd msSmECSiNxnR0RM24MwXUcNcarCv/BK2yXVRCIRyII8yZQ3PNgoGz7Es7O0WL4jCvZSINGcDqIjQ6 dWaxfCVTnjoPD7GKm60g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFAD-007jEl-2N; Thu, 25 Nov 2021 13:51:49 +0000 Received: from smtp1.axis.com ([195.60.68.17]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFA8-007jAZ-8E for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 13:51:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1637848304; x=1669384304; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IZMfh96pc1eATKuBd9LQI2ag0STcz/D7Jqsa3v1w6EA=; b=SarhPzn6SandyCeXcASbf2qiAr7dwRiCyh6z0lRVmgt4RwmBKK2f3ZO4 PwyDMj2k5g4SPzuVPMCaTGIJj3y+8b+pqfiIViuzzELNaixqe2z5kRxUQ T+73g3hww6WoAoOvoZ5mUOsA/BTqIXY9S3KcqGpwuYgaZYi/2iqBg3cKn eZzE0ZmEZAV9A4ca5QJ5DpZ94GCqseYc7Q/9G9jdH8+z0Qr5cOfp5gn7H KdTrCGo2glAm/UyOd7ZV+KnIdeVoV7/rwEg2xcemJ1HQQQVJGsJr7tG+z 1IzA1PPPy7zGHjRJpUnLt9q3mqcMBNPIDXR/lnDyBx4gGXqtQJEKc9cdJ g==; Date: Thu, 25 Nov 2021 14:51:19 +0100 From: Vincent Whitchurch To: "jim.cromie@gmail.com" CC: Jason Baron , Pekka Paalanen , Sean Paul , Sean Paul , "quic_saipraka@quicinc.com" , Catalin Marinas , dri-devel , Will Deacon , "maz@kernel.org" , amd-gfx mailing list , Ingo Molnar , Daniel Vetter , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , Intel Graphics Development , Steven Rostedt , "intel-gvt-dev@lists.freedesktop.org" , Linux ARM , Greg KH , LKML , "quic_psodagud@quicinc.com" , "mathieu.desnoyers@efficios.com" Subject: Re: [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC Message-ID: <20211125135119.GA7625@axis.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> <20211111220206.121610-9-jim.cromie@gmail.com> <20211112114953.GA1381@axis.com> <20211116104631.195cbd0b@eldfell> <20211118172401.0b4d722e@eldfell> <41ea83b2-a707-cb6f-521e-070bb12502de@akamai.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_055144_829143_7125D2E5 X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 19, 2021 at 11:46:31PM +0100, jim.cromie@gmail.com wrote: > Vincent's code has the macro magic to define that event, which IIUC > is what makes it controllable by ftrace, and therefore acceptable in > principle to Steve. > Would there be any reason to expand his set of 2 events into dev_dbg, > pr_debug etc varieties ? > (ie any value to separating dev, !dev ?, maybe so > > Sean's code uses trace_array_printk primarily, which is EXPORTed, > which is a virtue. > > Vincents code does > +/* > + * This code is heavily based on __ftrace_trace_stack(). > + * > + * Allow 4 levels of nesting: normal, softirq, irq, NMI. > + */ > > to implement > > +static void dynamic_trace(const char *fmt, va_list args) > > Has this __ftrace_trace_stack() code been bundled into or hidden under > a supported interface ? > > would it look anything like trace_array_printk() ? > > what problem is that code solving inside dynamic-debug.c ? I'm not sure I fully understand all of your questions, but perhaps this thread with Steven's reply to the first version of my patchset will answer some of them: https://lore.kernel.org/lkml/20200723112644.7759f82f@oasis.local.home/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32857C433F5 for ; Thu, 25 Nov 2021 13:51:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 575506F384; Thu, 25 Nov 2021 13:51:24 +0000 (UTC) Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id F10396EF38; Thu, 25 Nov 2021 13:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1637848282; x=1669384282; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IZMfh96pc1eATKuBd9LQI2ag0STcz/D7Jqsa3v1w6EA=; b=jgzgG10w9vP4Gs2lzNKK5OcYWIoSjFCceX8DfO4YOJzZrwuB6uWkU+lh N/CD5xSySDkCXP39gNpoQDqbD9npZ2jEJ67qoJ4Y1m4s8/63qSGXmtpdX v5+YKWgrrJK5qrNiqgPcu2XvrW3x/1/v+fDfTHjFniB74T+Az0yq/bY+d QuIqeYSQVmODoOG7SlniN07TqY+gmVtrFhfcvJrzsUfO+ayb/EoOACknS Ecc+Tik9aU72uOh3QCtDj7VvFxOM7Md34cuvpJxb4ZiUm7St+4SVFi2zd fQeBhoivxxvTPhX68ikboM3RrwAH98C6zhGLcjst+LHcPtZt5qNv1CAHJ A==; Date: Thu, 25 Nov 2021 14:51:19 +0100 From: Vincent Whitchurch To: "jim.cromie@gmail.com" Subject: Re: [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC Message-ID: <20211125135119.GA7625@axis.com> References: <20211111220206.121610-1-jim.cromie@gmail.com> <20211111220206.121610-9-jim.cromie@gmail.com> <20211112114953.GA1381@axis.com> <20211116104631.195cbd0b@eldfell> <20211118172401.0b4d722e@eldfell> <41ea83b2-a707-cb6f-521e-070bb12502de@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "quic_saipraka@quicinc.com" , Jason Baron , Catalin Marinas , dri-devel , Will Deacon , "maz@kernel.org" , amd-gfx mailing list , Ingo Molnar , Daniel Vetter , Arnd Bergmann , "linux-arm-msm@vger.kernel.org" , Intel Graphics Development , Steven Rostedt , Sean Paul , "intel-gvt-dev@lists.freedesktop.org" , Linux ARM , Sean Paul , Greg KH , LKML , "quic_psodagud@quicinc.com" , "mathieu.desnoyers@efficios.com" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 19, 2021 at 11:46:31PM +0100, jim.cromie@gmail.com wrote: > Vincent's code has the macro magic to define that event, which IIUC > is what makes it controllable by ftrace, and therefore acceptable in > principle to Steve. > Would there be any reason to expand his set of 2 events into dev_dbg, > pr_debug etc varieties ? > (ie any value to separating dev, !dev ?, maybe so > > Sean's code uses trace_array_printk primarily, which is EXPORTed, > which is a virtue. > > Vincents code does > +/* > + * This code is heavily based on __ftrace_trace_stack(). > + * > + * Allow 4 levels of nesting: normal, softirq, irq, NMI. > + */ > > to implement > > +static void dynamic_trace(const char *fmt, va_list args) > > Has this __ftrace_trace_stack() code been bundled into or hidden under > a supported interface ? > > would it look anything like trace_array_printk() ? > > what problem is that code solving inside dynamic-debug.c ? I'm not sure I fully understand all of your questions, but perhaps this thread with Steven's reply to the first version of my patchset will answer some of them: https://lore.kernel.org/lkml/20200723112644.7759f82f@oasis.local.home/