Re: [RFC PATCH] arch: arm64: introduce RODATA_FULL_USE_PTE_CONT

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4335 bytes --]

Hi Huangzhaoyang,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on v5.16-rc2 next-20211125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huangzhaoyang/arch-arm64-introduce-RODATA_FULL_USE_PTE_CONT/20211122-133031
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-randconfig-m031-20211123 (https://download.01.org/0day-ci/archive/20211125/202111252004.KtdAqvyi-lkp(a)intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6d67cb438683b6f0ae4e8ca1504af4f8e9815b88
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huangzhaoyang/arch-arm64-introduce-RODATA_FULL_USE_PTE_CONT/20211122-133031
        git checkout 6d67cb438683b6f0ae4e8ca1504af4f8e9815b88
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/mm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/arm64/mm/mmu.c: In function 'pgattr_change_is_safe':
>> arch/arm64/mm/mmu.c:140:24: error: lvalue required as unary '&' operand
     140 |         if (old | new) & PTE_CONT)
         |                        ^
>> arch/arm64/mm/mmu.c:140:34: error: expected ';' before ')' token
     140 |         if (old | new) & PTE_CONT)
         |                                  ^
   In file included from include/linux/build_bug.h:5,
                    from include/linux/bits.h:22,
                    from arch/arm64/include/asm/sysreg.h:12,
                    from arch/arm64/include/asm/cputype.h:148,
                    from arch/arm64/include/asm/cache.h:8,
                    from include/linux/cache.h:6,
                    from arch/arm64/mm/mmu.c:9:
   include/linux/compiler.h:56:23: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
      56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                       ^~
   arch/arm64/mm/mmu.c:140:9: note: in expansion of macro 'if'
     140 |         if (old | new) & PTE_CONT)
         |         ^~
   arch/arm64/mm/mmu.c:140:34: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
     140 |         if (old | new) & PTE_CONT)
         |                                  ^
>> arch/arm64/mm/mmu.c:140:34: error: expected statement before ')' token


vim +140 arch/arm64/mm/mmu.c

   133	
   134		/* creating or taking down mappings is always safe */
   135		if (old == 0 || new == 0)
   136			return true;
   137	
   138		/* live contiguous mappings may not be manipulated at all */
   139	#ifndef CONFIG_RODATA_FULL_USE_PTE_CONT
 > 140		if (old | new) & PTE_CONT)
   141			return false;
   142	#endif
   143	
   144		/* Transitioning from Non-Global to Global is unsafe */
   145		if (old & ~new & PTE_NG)
   146			return false;
   147	
   148		/*
   149		 * Changing the memory type between Normal and Normal-Tagged is safe
   150		 * since Tagged is considered a permission attribute from the
   151		 * mismatched attribute aliases perspective.
   152		 */
   153		if (((old & PTE_ATTRINDX_MASK) == PTE_ATTRINDX(MT_NORMAL) ||
   154		     (old & PTE_ATTRINDX_MASK) == PTE_ATTRINDX(MT_NORMAL_TAGGED)) &&
   155		    ((new & PTE_ATTRINDX_MASK) == PTE_ATTRINDX(MT_NORMAL) ||
   156		     (new & PTE_ATTRINDX_MASK) == PTE_ATTRINDX(MT_NORMAL_TAGGED)))
   157			mask |= PTE_ATTRINDX_MASK;
   158	
   159		return ((old ^ new) & ~mask) == 0;
   160	}
   161	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org