From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH 07/21] btrfs: zoned: move btrfs_finish_block_group_to_copy to zoned code
Date: Fri, 26 Nov 2021 10:38:52 +0800 [thread overview]
Message-ID: <202111261027.3kJDKpBC-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3968 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <1482f3cd38ca134c23c8969a27191a828fc2f64d.1637745470.git.johannes.thumshirn@wdc.com>
References: <1482f3cd38ca134c23c8969a27191a828fc2f64d.1637745470.git.johannes.thumshirn@wdc.com>
TO: Johannes Thumshirn <johannes.thumshirn@wdc.com>
TO: David Sterba <dsterba@suse.com>
CC: Johannes Thumshirn <johannes.thumshirn@wdc.com>
CC: linux-btrfs(a)vger.kernel.org
CC: Nikolay Borisov <nborisov@suse.com>
CC: Naohiro Aota <Naohiro.Aota@wdc.com>
Hi Johannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on kdave/for-next]
[also build test WARNING on next-20211125]
[cannot apply to v5.16-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Johannes-Thumshirn/btrfs-first-batch-of-zoned-cleanups/20211124-173329
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: i386-randconfig-m021-20211124 (https://download.01.org/0day-ci/archive/20211126/202111261027.3kJDKpBC-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
fs/btrfs/zoned.c:2187 btrfs_finish_block_group_to_copy() error: 'em' dereferencing possible ERR_PTR()
Old smatch warnings:
fs/btrfs/zoned.c:169 sb_zone_number() error: uninitialized symbol 'zone'.
fs/btrfs/zoned.c:1456 btrfs_load_block_group_zone_info() error: uninitialized symbol 'ret'.
vim +/em +2187 fs/btrfs/zoned.c
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2162
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2163 bool btrfs_finish_block_group_to_copy(struct btrfs_device *srcdev,
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2164 struct btrfs_block_group *cache,
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2165 u64 physical)
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2166 {
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2167 struct btrfs_fs_info *fs_info = cache->fs_info;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2168 struct extent_map *em;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2169 struct map_lookup *map;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2170 u64 chunk_offset = cache->start;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2171 int num_extents, cur_extent;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2172 int i;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2173
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2174 /* Do not use "to_copy" on non zoned filesystem for now */
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2175 if (!btrfs_is_zoned(fs_info))
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2176 return true;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2177
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2178 spin_lock(&cache->lock);
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2179 if (cache->removed) {
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2180 spin_unlock(&cache->lock);
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2181 return true;
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2182 }
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2183 spin_unlock(&cache->lock);
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2184
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2185 em = btrfs_get_chunk_map(fs_info, chunk_offset, 1);
1a4c69dc517089 Johannes Thumshirn 2021-11-24 2186 ASSERT(!IS_ERR(em));
1a4c69dc517089 Johannes Thumshirn 2021-11-24 @2187 map = em->map_lookup;
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2021-11-26 2:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 2:38 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-24 9:30 [PATCH 00/21] btrfs: first batch of zoned cleanups Johannes Thumshirn
2021-11-24 9:30 ` [PATCH 07/21] btrfs: zoned: move btrfs_finish_block_group_to_copy to zoned code Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111261027.3kJDKpBC-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.