Re: [PATCH net-next 4/4] net: mvneta: Add TC traffic shaping offload

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hello Jakub,

On Thu, 25 Nov 2021 09:50:29 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

>On Thu, 25 Nov 2021 16:48:13 +0100 Maxime Chevallier wrote:
>> The mvneta controller is able to do some tocken-bucket per-queue traffic
>> shaping. This commit adds support for setting these using the TC mqprio
>> interface.
>> 
>> The token-bucket parameters are customisable, but the current
>> implementation configures them to have a 10kbps resolution for the
>> rate limitation, since it allows to cover the whole range of max_rate
>> values from 10kbps to 5Gbps with 10kbps increments.
>> 
>> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>  
>
>Breaks 32bit build, please make sure you use division helpers for 64b.

My bad, I'll update to use the proper helpers then (and compile-test
for 32bits this time too, sorry about that)

Thanks,

Maxime

-- 
Maxime Chevallier, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com