From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97162C433EF for ; Fri, 26 Nov 2021 17:51:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE46F83736; Fri, 26 Nov 2021 18:51:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Zcse34cN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 77F1483681; Fri, 26 Nov 2021 18:43:45 +0100 (CET) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25AF383681 for ; Fri, 26 Nov 2021 18:43:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tomm.merciai@gmail.com Received: by mail-ed1-x534.google.com with SMTP id l25so41602573eda.11 for ; Fri, 26 Nov 2021 09:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jwqyKZUxYX6afOIXCJONmhmrjd3o/zXgd4G1nwRzXMU=; b=Zcse34cNeif54TX8oQeURA+o7g84pVOD8NepAU5MzrgWvGAGRisjdHeYnRTIZBabFu 2WL/0Om+ZbLSy6vuAs9uYbkSgXrRfx1Ywqo1SkyxVs3B51diZ5BPMPUmq/J1+635aD41 YGZjm7tf51VWOdKlyHB71S5Y9OPmR/evJjKeASb0TLsPlId20T3UIhNIvmaVHFk1++/x rn1a4m+0Dgqr5wuqfy9fPRdx3JgWlMx0jdB1Fn1Mgbx+cxZafUt/dYMjQ5SC7goIY//B mfOMIOgFm5MQ+vAOlWsGv0+t+U8Fxs/sxmVFq3JnQff1Fws+wR1Tdk5R/Vcq3BfiwHCm gZoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jwqyKZUxYX6afOIXCJONmhmrjd3o/zXgd4G1nwRzXMU=; b=RrMejueeA1Mc5f4a5BwQtGDI7P6l5ACWvqv+tZVQcBz/VzqFNYDlkAeSpfO+sW194y QDg/ePM5N0hcniDzAr9uMb+Bfcv/zGPZjV5zlmNoa1Dzt4/xvrAoEHFzSZBHmJkVEW+a 2MC+3qZ9LkqC5f0r5qCpG4xNXy1Fv/BrxR152092T2p/OAPD4br4hPiU15HSK1RF+3jp 9UsYrZzRO4UH90Y8HJoVBJaG18dhGYmr57VZzd+ZterAqclLUrIExUG8Q/KTqDi+awmz mRfNR2H+t6dJIPApvz51NSsQkBZYb0wDJHTAGdNKvon1qxarXVXuoz6F4sRqwm64WvjM aJLg== X-Gm-Message-State: AOAM5304UoswjzeLAz1rCftz1U14y0RMohizWP6hg6+HAnpjoZglAdfD khbSGODaU92iq9GWNzyjxjE= X-Google-Smtp-Source: ABdhPJyHpBnAs63hOCKwuIG8HgBOB8RxwZ0fWwX3pSjcV7ZQor5FbMiK+EevHeU3JRPJTshKGHqRZQ== X-Received: by 2002:a05:6402:41a:: with SMTP id q26mr50619328edv.387.1637948621847; Fri, 26 Nov 2021 09:43:41 -0800 (PST) Received: from tom-desktop.station (net-2-39-74-150.cust.vodafonedsl.it. [2.39.74.150]) by smtp.gmail.com with ESMTPSA id sd28sm3841946ejc.37.2021.11.26.09.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 09:43:41 -0800 (PST) From: Tommaso Merciai To: Cc: michael@amarulasolutions.com, andrey.zhizhikin@leica-geosystems.com, Tommaso Merciai , Stefano Babic , Fabio Estevam , "NXP i.MX U-Boot Team" , Peng Fan , Ye Li , Simon Glass , Marek Vasut , Frieder Schrempf , Harald Seiler , Tim Harvey , "Ying-Chun Liu (PaulLiu)" , u-boot@lists.denx.de Subject: [RFC PATCH 1/3] imx8m: drop env_get_location for imx8mn and imx8mp Date: Fri, 26 Nov 2021 18:43:29 +0100 Message-Id: <20211126174331.5928-2-tomm.merciai@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211126174331.5928-1-tomm.merciai@gmail.com> References: <20211126174331.5928-1-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 26 Nov 2021 18:51:30 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This function defined for two architecture is not really generic and can generate problem when people add a new board. Signed-off-by: Tommaso Merciai --- Changes since v1: - Fix commit: drop down only env_get_location arch/arm/mach-imx/imx8m/soc.c | 39 ----------------------------------- 1 file changed, 39 deletions(-) diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c index 863508776d..f0030a557a 100644 --- a/arch/arm/mach-imx/imx8m/soc.c +++ b/arch/arm/mach-imx/imx8m/soc.c @@ -1313,45 +1313,6 @@ void do_error(struct pt_regs *pt_regs, unsigned int esr) #endif #if defined(CONFIG_IMX8MN) || defined(CONFIG_IMX8MP) -enum env_location env_get_location(enum env_operation op, int prio) -{ - enum boot_device dev = get_boot_device(); - enum env_location env_loc = ENVL_UNKNOWN; - - if (prio) - return env_loc; - - switch (dev) { -#ifdef CONFIG_ENV_IS_IN_SPI_FLASH - case QSPI_BOOT: - env_loc = ENVL_SPI_FLASH; - break; -#endif -#ifdef CONFIG_ENV_IS_IN_NAND - case NAND_BOOT: - env_loc = ENVL_NAND; - break; -#endif -#ifdef CONFIG_ENV_IS_IN_MMC - case SD1_BOOT: - case SD2_BOOT: - case SD3_BOOT: - case MMC1_BOOT: - case MMC2_BOOT: - case MMC3_BOOT: - env_loc = ENVL_MMC; - break; -#endif - default: -#if defined(CONFIG_ENV_IS_NOWHERE) - env_loc = ENVL_NOWHERE; -#endif - break; - } - - return env_loc; -} - #ifndef ENV_IS_EMBEDDED long long env_get_offset(long long defautl_offset) { -- 2.25.1