From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yury Norov Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Date: Sun, 28 Nov 2021 10:47:12 -0800 Message-ID: <20211128184712.GA309073@lapt> References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/n8Fw4IyU1F5fHoWTvLyqOcZIf3XUL5VB8l7IOe2NBY=; b=C5CV94jQnZ2w+Q hz+ukD2MzX3VwY4R2vsiYKbzq9vELHjWzT6fvbDFdtX/5dX1mE/bKsj5EZfkfr8RH+7xcK5TU2jKl K0lM68ayWSuoZ9b1WQCRfezZRWY+z9AffqkonsA1Dlvknh29rnNPkVmdpPgMnb5yrRUtS0zQAWxXf PU6Hw+BhxkzL4YuLfhQOARtyz+qnWexSOXgq5Zvq1QjmLdUhslBiahlH/2nIYRGTFhfSRHtHqvbj2 MX1riie4+Tgr/DNzbqtz++cM0JRpjaVNW5ArGjWjzZUQJN0exxaV4s5VfuywOQXHQ0pZunyogs9Cn 9bTMz02Wh+668PTKJeMg==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=oEs9cCLNoYNdz+AbfzXoumcqnU2rFCFJ5TyCH12jj8Ix0vmr0cjhof0ocW5eqSpQbo mrHrVXqzVgn1iu3yISJ4wwf50y2BGwES4qCIZWk6z19v3s6rfhM8ODKHsnHGdu0xSYmn zutWpoWgGKrfvlhNB+FDfgo3OCF/7V6L7yaewLYpZDm48/8KLn7Bhlr/nJjgfB4Oiw7i hyEVArk/04uNSdzcAMwME+LGzw661S1XN1lrF6iOjE5r2wDmrufbwXHGBlcjc0XG2JfP D0I2JqoyhsvbiLTErDYg5FY5mgjhIpdLZ1XuQkVWsomuMWeu+IFVGskruJ1MCFhjIPEq wYYw== Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org To: Dennis Zhou Cc: Joe Perches , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , "Paul E. McKenney" , "Rafael J. Wysocki" , Alexander Shishkin , Alexey Klimov , Amitkumar Karwar , Andi Kleen , Andrew Lunn , Andrew Morton , Andy Gross , Andy Lutomirski , Andy Shevchenko , Anup Patel , Ard Biesheuvel , Arnaldo Carvalho de Melo , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Christoph Lameter , Daniel On Sun, Nov 28, 2021 at 12:54:00PM -0500, Dennis Zhou wrote: > Hello, > > On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > > to return earlier depending on the condition. > > > [] > > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > > [] > > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > > * if platform didn't set the present map already, do it now > > > > * boot cpu is set to present already by init/main.c > > > > */ > > > > - if (num_present_cpus() <= 1) > > > > + if (num_present_cpus_le(2)) > > > > init_cpu_present(cpu_possible_mask); > > > > > > ? is this supposed to be 2 or 1 > > > > X <= 1 is the equivalent of X < 2. > > > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > > [] > > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > > return ret; > > > > } > > > > > > > > - if (num_present_cpus() > 4) { > > > > + if (num_present_cpus_gt(4)) { > > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > > __func__); > > > > > > It looks as if the present variants should be using the same values > > > so the _le test above with 1 changed to 2 looks odd. > > > > I think the confusion comes from le meaning less than rather than lt. > Given the general convention of: lt (<), le (<=), eg (=), ge (>=), > gt (>), I'd consider renaming your le to lt. Ok, makes sense. I'll rename in v2 and add <= and >= versions. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7DAC433EF for ; Sun, 28 Nov 2021 18:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359383AbhK1Sxe (ORCPT ); Sun, 28 Nov 2021 13:53:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353164AbhK1Svc (ORCPT ); Sun, 28 Nov 2021 13:51:32 -0500 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 285E4C061761; Sun, 28 Nov 2021 10:47:22 -0800 (PST) Received: by mail-qv1-xf35.google.com with SMTP id b11so12272923qvm.7; Sun, 28 Nov 2021 10:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=oEs9cCLNoYNdz+AbfzXoumcqnU2rFCFJ5TyCH12jj8Ix0vmr0cjhof0ocW5eqSpQbo mrHrVXqzVgn1iu3yISJ4wwf50y2BGwES4qCIZWk6z19v3s6rfhM8ODKHsnHGdu0xSYmn zutWpoWgGKrfvlhNB+FDfgo3OCF/7V6L7yaewLYpZDm48/8KLn7Bhlr/nJjgfB4Oiw7i hyEVArk/04uNSdzcAMwME+LGzw661S1XN1lrF6iOjE5r2wDmrufbwXHGBlcjc0XG2JfP D0I2JqoyhsvbiLTErDYg5FY5mgjhIpdLZ1XuQkVWsomuMWeu+IFVGskruJ1MCFhjIPEq wYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=Lub/jRMp5HbX/7AjjLJnC/Vab99j2ktajIscJ9p2O6ch5U1lp/Tn0kez/DgbArTIGQ 8m0oT0VC3mu6/D7QM/K64f825IqQ4PV23NUCnCcnk8nFkicrpjsqSr7IxL/MTT6eX1Jz Z+dw/0FVdyxd0Et0huAs5Bs4+wvok1a0lYjNLiH3mY5SqhISqzNpNbHt9Ji2ypsmIhhc jPwFpCvP+KFDmfu6fFMX79YeK1cgg4EKuV/9A4TfEP+HICmXhvopXpxMm4EtX7uosV4c 366JCnn+KwEE3AhUWUrH2Hta6Bko4ew4pO9sElQVR5XIlgMrUgBm+nmRDXH/H7vYzwxX Uxag== X-Gm-Message-State: AOAM53320Fj3LXJh5QRh59wXQpCYDVyyf8woeqAdQ+P/OHA+vu4K/MtR gE/G4I2K/wEgTDVt18/4JKw= X-Google-Smtp-Source: ABdhPJy+21VmTcm+AhhPYb7MVuOfGbfxLsGp1r9C41IKKFVcOTnAXjsR8SRxKxcOFPC3Y4DL0s01XQ== X-Received: by 2002:a05:6214:2348:: with SMTP id hu8mr12230119qvb.9.1638125241136; Sun, 28 Nov 2021 10:47:21 -0800 (PST) Received: from localhost ([66.216.211.25]) by smtp.gmail.com with ESMTPSA id e13sm7457944qte.56.2021.11.28.10.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 10:47:20 -0800 (PST) Date: Sun, 28 Nov 2021 10:47:12 -0800 From: Yury Norov To: Dennis Zhou Cc: Joe Perches , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , "Paul E. McKenney" , "Rafael J. Wysocki" , Alexander Shishkin , Alexey Klimov , Amitkumar Karwar , Andi Kleen , Andrew Lunn , Andrew Morton , Andy Gross , Andy Lutomirski , Andy Shevchenko , Anup Patel , Ard Biesheuvel , Arnaldo Carvalho de Melo , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Christoph Lameter , Daniel Vetter , Dave Hansen , David Airlie , David Laight , Dinh Nguyen , Geetha sowjanya , Geert Uytterhoeven , Greg Kroah-Hartman , Guo Ren , Hans de Goede , Heiko Carstens , Ian Rogers , Ingo Molnar , Jakub Kicinski , Jason Wessel , Jens Axboe , Jiri Olsa , Jonathan Cameron , Juri Lelli , Kalle Valo , Kees Cook , Krzysztof Kozlowski , Lee Jones , Marc Zyngier , Marcin Wojtas , Mark Gross , Mark Rutland , Matti Vaittinen , Mauro Carvalho Chehab , Mel Gorman , Michael Ellerman , Mike Marciniszyn , Nicholas Piggin , Palmer Dabbelt , Peter Zijlstra , Petr Mladek , Randy Dunlap , Rasmus Villemoes , Roy Pledge , Russell King , Saeed Mahameed , Sagi Grimberg , Sergey Senozhatsky , Solomon Peachy , Stephen Boyd , Stephen Rothwell , Steven Rostedt , Subbaraya Sundeep , Sudeep Holla , Sunil Goutham , Tariq Toukan , Tejun Heo , Thomas Bogendoerfer , Thomas Gleixner , Ulf Hansson , Vincent Guittot , Vineet Gupta , Viresh Kumar , Vivien Didelot , Vlastimil Babka , Will Deacon , bcm-kernel-feedback-list@broadcom.com, kvm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Message-ID: <20211128184712.GA309073@lapt> References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Sun, Nov 28, 2021 at 12:54:00PM -0500, Dennis Zhou wrote: > Hello, > > On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > > to return earlier depending on the condition. > > > [] > > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > > [] > > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > > * if platform didn't set the present map already, do it now > > > > * boot cpu is set to present already by init/main.c > > > > */ > > > > - if (num_present_cpus() <= 1) > > > > + if (num_present_cpus_le(2)) > > > > init_cpu_present(cpu_possible_mask); > > > > > > ? is this supposed to be 2 or 1 > > > > X <= 1 is the equivalent of X < 2. > > > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > > [] > > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > > return ret; > > > > } > > > > > > > > - if (num_present_cpus() > 4) { > > > > + if (num_present_cpus_gt(4)) { > > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > > __func__); > > > > > > It looks as if the present variants should be using the same values > > > so the _le test above with 1 changed to 2 looks odd. > > > > I think the confusion comes from le meaning less than rather than lt. > Given the general convention of: lt (<), le (<=), eg (=), ge (>=), > gt (>), I'd consider renaming your le to lt. Ok, makes sense. I'll rename in v2 and add <= and >= versions. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yury Norov Date: Sun, 28 Nov 2021 18:47:12 +0000 Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Message-Id: <20211128184712.GA309073@lapt> List-Id: References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dennis Zhou Cc: Joe Perches , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , "Paul E. McKenney" , "Rafael J. Wysocki" , Alexander Shishkin , Alexey Klimov , Amitkumar Karwar , Andi Kleen , Andrew Lunn , Andrew Morton , Andy Gross , Andy Lutomirski , Andy Shevchenko , Anup Patel , Ard Biesheuvel , Arnaldo Carvalho de Melo , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Christoph Lameter , Daniel Vetter , Dave Hansen , David Airlie , David Laight , Dinh Nguyen , Geetha sowjanya , Geert Uytterhoeven , Greg Kroah-Hartman , Guo Ren , Hans de Goede , Heiko Carstens , Ian Rogers , Ingo Molnar , Jakub Kicinski , Jason Wessel , Jens Axboe , Jiri Olsa , Jonathan Cameron , Juri Lelli , Kalle Valo , Kees Cook , Krzysztof Kozlowski , Lee Jones , Marc Zyngier , Marcin Wojtas , Mark Gross , Mark Rutland , Matti Vaittinen , Mauro Carvalho Chehab , Mel Gorman , Michael Ellerman , Mike Marciniszyn , Nicholas Piggin , Palmer Dabbelt , Peter Zijlstra , Petr Mladek , Randy Dunlap , Rasmus Villemoes , Roy Pledge , Russell King , Saeed Mahameed , Sagi Grimberg , Sergey Senozhatsky , Solomon Peachy , Stephen Boyd , Stephen Rothwell , Steven Rostedt , Subbaraya Sundeep , Sudeep Holla , Sunil Goutham , Tariq Toukan , Tejun Heo , Thomas Bogendoerfer , Thomas Gleixner , Ulf Hansson , Vincent Guittot , Vineet Gupta , Viresh Kumar , Vivien Didelot , Vlastimil Babka , Will Deacon , bcm-kernel-feedback-list@broadcom.com, kvm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org On Sun, Nov 28, 2021 at 12:54:00PM -0500, Dennis Zhou wrote: > Hello, > > On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > > to return earlier depending on the condition. > > > [] > > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > > [] > > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > > * if platform didn't set the present map already, do it now > > > > * boot cpu is set to present already by init/main.c > > > > */ > > > > - if (num_present_cpus() <= 1) > > > > + if (num_present_cpus_le(2)) > > > > init_cpu_present(cpu_possible_mask); > > > > > > ? is this supposed to be 2 or 1 > > > > X <= 1 is the equivalent of X < 2. > > > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > > [] > > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > > return ret; > > > > } > > > > > > > > - if (num_present_cpus() > 4) { > > > > + if (num_present_cpus_gt(4)) { > > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > > __func__); > > > > > > It looks as if the present variants should be using the same values > > > so the _le test above with 1 changed to 2 looks odd. > > > > I think the confusion comes from le meaning less than rather than lt. > Given the general convention of: lt (<), le (<=), eg (=), ge (>=), > gt (>), I'd consider renaming your le to lt. Ok, makes sense. I'll rename in v2 and add <= and >= versions. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EB84C433F5 for ; Sun, 28 Nov 2021 18:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/n8Fw4IyU1F5fHoWTvLyqOcZIf3XUL5VB8l7IOe2NBY=; b=C5CV94jQnZ2w+Q hz+ukD2MzX3VwY4R2vsiYKbzq9vELHjWzT6fvbDFdtX/5dX1mE/bKsj5EZfkfr8RH+7xcK5TU2jKl K0lM68ayWSuoZ9b1WQCRfezZRWY+z9AffqkonsA1Dlvknh29rnNPkVmdpPgMnb5yrRUtS0zQAWxXf PU6Hw+BhxkzL4YuLfhQOARtyz+qnWexSOXgq5Zvq1QjmLdUhslBiahlH/2nIYRGTFhfSRHtHqvbj2 MX1riie4+Tgr/DNzbqtz++cM0JRpjaVNW5ArGjWjzZUQJN0exxaV4s5VfuywOQXHQ0pZunyogs9Cn 9bTMz02Wh+668PTKJeMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrPCw-00GU7j-4f; Sun, 28 Nov 2021 18:47:26 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrPCs-00GU62-K7; Sun, 28 Nov 2021 18:47:24 +0000 Received: by mail-qv1-xf35.google.com with SMTP id i13so12286526qvm.1; Sun, 28 Nov 2021 10:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=oEs9cCLNoYNdz+AbfzXoumcqnU2rFCFJ5TyCH12jj8Ix0vmr0cjhof0ocW5eqSpQbo mrHrVXqzVgn1iu3yISJ4wwf50y2BGwES4qCIZWk6z19v3s6rfhM8ODKHsnHGdu0xSYmn zutWpoWgGKrfvlhNB+FDfgo3OCF/7V6L7yaewLYpZDm48/8KLn7Bhlr/nJjgfB4Oiw7i hyEVArk/04uNSdzcAMwME+LGzw661S1XN1lrF6iOjE5r2wDmrufbwXHGBlcjc0XG2JfP D0I2JqoyhsvbiLTErDYg5FY5mgjhIpdLZ1XuQkVWsomuMWeu+IFVGskruJ1MCFhjIPEq wYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=W+ePG4AXaCNLIJAeSkZfkFU8hlJX22GA4kJUtRD4hfo5IZA/6Ik0ga0f0KXiPKlZEw PMVGWwjdP1ykXTpe7JZ36IVCUMWh/FbB5pKty+uM1fnaWdJk87GwlVj6Yd8JlvMSzH1n nVC60ueI8mN5dJ1j2gWNyYJsTQu4igsfkAgHyePhMBDDEeQtS5NmpvqmOh/WBxlw2avW YMg95/c6z/+/M3TrHuAthim20ONa79/S3qgtzi5exFC3TwzvK+nGLTk+r4mHm162Aaro gkkjjV0eP0gE5rKkJ5kE+ayQKjYocXbSjkovs7YGGBe9Xw+F8l+Mh9svo2YlKwRkJpQf rjBQ== X-Gm-Message-State: AOAM530PVaOxEX5S8LaNaqxQsl5E0hHjJ3iys3cpkZwgimL9rmyrFV/F a9HAmMlpAq9RBHGSEHfqkSI= X-Google-Smtp-Source: ABdhPJy+21VmTcm+AhhPYb7MVuOfGbfxLsGp1r9C41IKKFVcOTnAXjsR8SRxKxcOFPC3Y4DL0s01XQ== X-Received: by 2002:a05:6214:2348:: with SMTP id hu8mr12230119qvb.9.1638125241136; Sun, 28 Nov 2021 10:47:21 -0800 (PST) Received: from localhost ([66.216.211.25]) by smtp.gmail.com with ESMTPSA id e13sm7457944qte.56.2021.11.28.10.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 10:47:20 -0800 (PST) Date: Sun, 28 Nov 2021 10:47:12 -0800 From: Yury Norov To: Dennis Zhou Cc: Joe Perches , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , "Paul E. McKenney" , "Rafael J. Wysocki" , Alexander Shishkin , Alexey Klimov , Amitkumar Karwar , Andi Kleen , Andrew Lunn , Andrew Morton , Andy Gross , Andy Lutomirski , Andy Shevchenko , Anup Patel , Ard Biesheuvel , Arnaldo Carvalho de Melo , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Christoph Lameter , Daniel Vetter , Dave Hansen , David Airlie , David Laight , Dinh Nguyen , Geetha sowjanya , Geert Uytterhoeven , Greg Kroah-Hartman , Guo Ren , Hans de Goede , Heiko Carstens , Ian Rogers , Ingo Molnar , Jakub Kicinski , Jason Wessel , Jens Axboe , Jiri Olsa , Jonathan Cameron , Juri Lelli , Kalle Valo , Kees Cook , Krzysztof Kozlowski , Lee Jones , Marc Zyngier , Marcin Wojtas , Mark Gross , Mark Rutland , Matti Vaittinen , Mauro Carvalho Chehab , Mel Gorman , Michael Ellerman , Mike Marciniszyn , Nicholas Piggin , Palmer Dabbelt , Peter Zijlstra , Petr Mladek , Randy Dunlap , Rasmus Villemoes , Roy Pledge , Russell King , Saeed Mahameed , Sagi Grimberg , Sergey Senozhatsky , Solomon Peachy , Stephen Boyd , Stephen Rothwell , Steven Rostedt , Subbaraya Sundeep , Sudeep Holla , Sunil Goutham , Tariq Toukan , Tejun Heo , Thomas Bogendoerfer , Thomas Gleixner , Ulf Hansson , Vincent Guittot , Vineet Gupta , Viresh Kumar , Vivien Didelot , Vlastimil Babka , Will Deacon , bcm-kernel-feedback-list@broadcom.com, kvm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Message-ID: <20211128184712.GA309073@lapt> References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_104722_709775_80A3AF17 X-CRM114-Status: GOOD ( 29.77 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, Nov 28, 2021 at 12:54:00PM -0500, Dennis Zhou wrote: > Hello, > > On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > > to return earlier depending on the condition. > > > [] > > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > > [] > > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > > * if platform didn't set the present map already, do it now > > > > * boot cpu is set to present already by init/main.c > > > > */ > > > > - if (num_present_cpus() <= 1) > > > > + if (num_present_cpus_le(2)) > > > > init_cpu_present(cpu_possible_mask); > > > > > > ? is this supposed to be 2 or 1 > > > > X <= 1 is the equivalent of X < 2. > > > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > > [] > > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > > return ret; > > > > } > > > > > > > > - if (num_present_cpus() > 4) { > > > > + if (num_present_cpus_gt(4)) { > > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > > __func__); > > > > > > It looks as if the present variants should be using the same values > > > so the _le test above with 1 changed to 2 looks odd. > > > > I think the confusion comes from le meaning less than rather than lt. > Given the general convention of: lt (<), le (<=), eg (=), ge (>=), > gt (>), I'd consider renaming your le to lt. Ok, makes sense. I'll rename in v2 and add <= and >= versions. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A08FFC433EF for ; Sun, 28 Nov 2021 18:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4CI389A4/lM/0d/bfSPXK+Nu7/kXD0q1RfyQkUKlKtk=; b=CwGstdtQaIAhef mvwvdm8I6OyVrxsGhfsyYXMUoSX7AKIOogNWEJB4Vjgg+bkS5l7mR++3iTw2kYmbuGsW1q50zjGcM sW0UB/zG9UyGSIORb24DR1IKOO3cf9ItAXxAMhNcLWYGDaaBnp72bIjsl2cGNk/g4ndCT0g1tKAHI KxNv8Go13JnW1C/a6n8TEny51phT9sasAGc4iWV4AqrRx33sxgNZq5R+Ru3MuWmK9Is99I1/1SHpc uh3m6H8iZ35KBXvH21gCiszQcjWBcK1bCH1Yx2EMy6i5r5VTgnRXC0vKouNJku/RX5zwx1K4AsFIB 6/QtFBe5nQ3YpxkKkA+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrPCy-00GU8j-7K; Sun, 28 Nov 2021 18:47:28 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrPCs-00GU62-K7; Sun, 28 Nov 2021 18:47:24 +0000 Received: by mail-qv1-xf35.google.com with SMTP id i13so12286526qvm.1; Sun, 28 Nov 2021 10:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=oEs9cCLNoYNdz+AbfzXoumcqnU2rFCFJ5TyCH12jj8Ix0vmr0cjhof0ocW5eqSpQbo mrHrVXqzVgn1iu3yISJ4wwf50y2BGwES4qCIZWk6z19v3s6rfhM8ODKHsnHGdu0xSYmn zutWpoWgGKrfvlhNB+FDfgo3OCF/7V6L7yaewLYpZDm48/8KLn7Bhlr/nJjgfB4Oiw7i hyEVArk/04uNSdzcAMwME+LGzw661S1XN1lrF6iOjE5r2wDmrufbwXHGBlcjc0XG2JfP D0I2JqoyhsvbiLTErDYg5FY5mgjhIpdLZ1XuQkVWsomuMWeu+IFVGskruJ1MCFhjIPEq wYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=W+ePG4AXaCNLIJAeSkZfkFU8hlJX22GA4kJUtRD4hfo5IZA/6Ik0ga0f0KXiPKlZEw PMVGWwjdP1ykXTpe7JZ36IVCUMWh/FbB5pKty+uM1fnaWdJk87GwlVj6Yd8JlvMSzH1n nVC60ueI8mN5dJ1j2gWNyYJsTQu4igsfkAgHyePhMBDDEeQtS5NmpvqmOh/WBxlw2avW YMg95/c6z/+/M3TrHuAthim20ONa79/S3qgtzi5exFC3TwzvK+nGLTk+r4mHm162Aaro gkkjjV0eP0gE5rKkJ5kE+ayQKjYocXbSjkovs7YGGBe9Xw+F8l+Mh9svo2YlKwRkJpQf rjBQ== X-Gm-Message-State: AOAM530PVaOxEX5S8LaNaqxQsl5E0hHjJ3iys3cpkZwgimL9rmyrFV/F a9HAmMlpAq9RBHGSEHfqkSI= X-Google-Smtp-Source: ABdhPJy+21VmTcm+AhhPYb7MVuOfGbfxLsGp1r9C41IKKFVcOTnAXjsR8SRxKxcOFPC3Y4DL0s01XQ== X-Received: by 2002:a05:6214:2348:: with SMTP id hu8mr12230119qvb.9.1638125241136; Sun, 28 Nov 2021 10:47:21 -0800 (PST) Received: from localhost ([66.216.211.25]) by smtp.gmail.com with ESMTPSA id e13sm7457944qte.56.2021.11.28.10.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 10:47:20 -0800 (PST) Date: Sun, 28 Nov 2021 10:47:12 -0800 From: Yury Norov To: Dennis Zhou Cc: Joe Perches , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , "Paul E. McKenney" , "Rafael J. Wysocki" , Alexander Shishkin , Alexey Klimov , Amitkumar Karwar , Andi Kleen , Andrew Lunn , Andrew Morton , Andy Gross , Andy Lutomirski , Andy Shevchenko , Anup Patel , Ard Biesheuvel , Arnaldo Carvalho de Melo , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Christoph Lameter , Daniel Vetter , Dave Hansen , David Airlie , David Laight , Dinh Nguyen , Geetha sowjanya , Geert Uytterhoeven , Greg Kroah-Hartman , Guo Ren , Hans de Goede , Heiko Carstens , Ian Rogers , Ingo Molnar , Jakub Kicinski , Jason Wessel , Jens Axboe , Jiri Olsa , Jonathan Cameron , Juri Lelli , Kalle Valo , Kees Cook , Krzysztof Kozlowski , Lee Jones , Marc Zyngier , Marcin Wojtas , Mark Gross , Mark Rutland , Matti Vaittinen , Mauro Carvalho Chehab , Mel Gorman , Michael Ellerman , Mike Marciniszyn , Nicholas Piggin , Palmer Dabbelt , Peter Zijlstra , Petr Mladek , Randy Dunlap , Rasmus Villemoes , Roy Pledge , Russell King , Saeed Mahameed , Sagi Grimberg , Sergey Senozhatsky , Solomon Peachy , Stephen Boyd , Stephen Rothwell , Steven Rostedt , Subbaraya Sundeep , Sudeep Holla , Sunil Goutham , Tariq Toukan , Tejun Heo , Thomas Bogendoerfer , Thomas Gleixner , Ulf Hansson , Vincent Guittot , Vineet Gupta , Viresh Kumar , Vivien Didelot , Vlastimil Babka , Will Deacon , bcm-kernel-feedback-list@broadcom.com, kvm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Message-ID: <20211128184712.GA309073@lapt> References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_104722_709775_80A3AF17 X-CRM114-Status: GOOD ( 29.77 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Sun, Nov 28, 2021 at 12:54:00PM -0500, Dennis Zhou wrote: > Hello, > > On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > > to return earlier depending on the condition. > > > [] > > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > > [] > > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > > * if platform didn't set the present map already, do it now > > > > * boot cpu is set to present already by init/main.c > > > > */ > > > > - if (num_present_cpus() <= 1) > > > > + if (num_present_cpus_le(2)) > > > > init_cpu_present(cpu_possible_mask); > > > > > > ? is this supposed to be 2 or 1 > > > > X <= 1 is the equivalent of X < 2. > > > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > > [] > > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > > return ret; > > > > } > > > > > > > > - if (num_present_cpus() > 4) { > > > > + if (num_present_cpus_gt(4)) { > > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > > __func__); > > > > > > It looks as if the present variants should be using the same values > > > so the _le test above with 1 changed to 2 looks odd. > > > > I think the confusion comes from le meaning less than rather than lt. > Given the general convention of: lt (<), le (<=), eg (=), ge (>=), > gt (>), I'd consider renaming your le to lt. Ok, makes sense. I'll rename in v2 and add <= and >= versions. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C2BBC433F5 for ; Sun, 28 Nov 2021 21:11:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4J2LkQ3VvCz3f4s for ; Mon, 29 Nov 2021 08:11:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=oEs9cCLN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::f36; helo=mail-qv1-xf36.google.com; envelope-from=yury.norov@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=oEs9cCLN; dkim-atps=neutral Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4J2HXb0T0Vz2yPv for ; Mon, 29 Nov 2021 05:47:24 +1100 (AEDT) Received: by mail-qv1-xf36.google.com with SMTP id u16so12281374qvk.4 for ; Sun, 28 Nov 2021 10:47:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=oEs9cCLNoYNdz+AbfzXoumcqnU2rFCFJ5TyCH12jj8Ix0vmr0cjhof0ocW5eqSpQbo mrHrVXqzVgn1iu3yISJ4wwf50y2BGwES4qCIZWk6z19v3s6rfhM8ODKHsnHGdu0xSYmn zutWpoWgGKrfvlhNB+FDfgo3OCF/7V6L7yaewLYpZDm48/8KLn7Bhlr/nJjgfB4Oiw7i hyEVArk/04uNSdzcAMwME+LGzw661S1XN1lrF6iOjE5r2wDmrufbwXHGBlcjc0XG2JfP D0I2JqoyhsvbiLTErDYg5FY5mgjhIpdLZ1XuQkVWsomuMWeu+IFVGskruJ1MCFhjIPEq wYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+5JBAVd8frUmOsccut4e882tgrn1djQ8KjHhL4/ag+E=; b=C7axdJwsSr2/2J3tg7m7h9pPiWA6piZgKgcF/kK/06AXTpDEN3cjh/7b1gQCxPQL0A cSNmMg05lNzoGPKcHWb/XvmynTbrTddIqNvwgXvct0ZczaYIUZsjLlL9OxBKqMxmNF6q OM2HnX/mjXJh8E3VKLE+Aezsv4PD8DcUu+HQikZZP1pPxmwCPdONueKc3t8o2ZBNU0+4 jYOrW6hKMQki/uW2znnGdQsMbTi8Soo6PjT8s06YWwSMwaqbuoDgktMwuYeYpzySu+K2 +u0vPOTjftFZI+ke9vwBOUcombChPIebcT1sW9LrDnISy0dKBv9SUI/nHUlgKU5IAHEW 0mmw== X-Gm-Message-State: AOAM530WcOPKSbLyBpoiIZlmSjp2FOd/dEtBjb1OuY+5wfQXHJhYF6um iZEPWAvIFwRsHwZzEP9/NYw= X-Google-Smtp-Source: ABdhPJy+21VmTcm+AhhPYb7MVuOfGbfxLsGp1r9C41IKKFVcOTnAXjsR8SRxKxcOFPC3Y4DL0s01XQ== X-Received: by 2002:a05:6214:2348:: with SMTP id hu8mr12230119qvb.9.1638125241136; Sun, 28 Nov 2021 10:47:21 -0800 (PST) Received: from localhost ([66.216.211.25]) by smtp.gmail.com with ESMTPSA id e13sm7457944qte.56.2021.11.28.10.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 10:47:20 -0800 (PST) Date: Sun, 28 Nov 2021 10:47:12 -0800 From: Yury Norov To: Dennis Zhou Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Message-ID: <20211128184712.GA309073@lapt> References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Mon, 29 Nov 2021 08:05:03 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Andrew Lunn , "Rafael J. Wysocki" , Catalin Marinas , Guo Ren , Christoph Lameter , Christoph Hellwig , Andi Kleen , Vincent Guittot , Ingo Molnar , Geert Uytterhoeven , Mel Gorman , Viresh Kumar , Petr Mladek , Arnaldo Carvalho de Melo , Jens Axboe , Andy Lutomirski , Lee Jones , Greg Kroah-Hartman , Randy Dunlap , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Sergey Senozhatsky , Thomas Gleixner , linux-crypto@vger.kernel.org, Joe Perches , Andrew Morton , Mark Rutland , Anup Patel , linux-ia64@vger.kernel.org, David Airlie , Roy Pledge , Dave Hansen , Solomon Peachy , Stephen Rothwell , Krzysztof Kozlowski , Matti Vaittinen , linux-alpha@vger.kernel.org, Tejun Heo , Kalle Valo , Stephen Boyd , Tariq Toukan , Dinh Nguyen , Jonathan Cameron , Ulf Hansson , Alexander Shishkin , Mike Marciniszyn , Rasmus Villemoes , Subbaraya Sundeep , Will Deacon , Sagi Grimberg , linux-csky@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-snps-arc@lists.infradead.org, Kees Cook , Arnd Bergmann , "James E.J. Bottomley" , Vineet Gupta , Steven Rostedt , Mark Gross , Borislav Petkov , Mauro Carvalho Chehab , Thomas Bogendoerfer , "Martin K. Petersen" , David Laight , Sudeep Holla , Geetha sowjanya , Ian Rogers , kvm@vger.kernel.org, Peter Zijlstra , Amitkumar Karwar , linux-mm@kvack.org, linux-riscv@lists.infradead.org, Jiri Olsa , Ard Biesheuvel , Marc Zyngier , Russell King , Andy Gross , Jakub Kicinski , Vivien Didelot , Sunil Goutham , "Paul E. McKenney" , linux-s390@vger.kernel.org, Alexey Klimov , Heiko Carstens , Hans de Goede , Nicholas Piggin , Marcin Wojtas , Vlastimil Babka , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, Palmer Dabbelt , Daniel Vetter , Jason Wessel , Saeed Mahameed , Andy Shevchenko Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Nov 28, 2021 at 12:54:00PM -0500, Dennis Zhou wrote: > Hello, > > On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > > to return earlier depending on the condition. > > > [] > > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > > [] > > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > > * if platform didn't set the present map already, do it now > > > > * boot cpu is set to present already by init/main.c > > > > */ > > > > - if (num_present_cpus() <= 1) > > > > + if (num_present_cpus_le(2)) > > > > init_cpu_present(cpu_possible_mask); > > > > > > ? is this supposed to be 2 or 1 > > > > X <= 1 is the equivalent of X < 2. > > > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > > [] > > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > > return ret; > > > > } > > > > > > > > - if (num_present_cpus() > 4) { > > > > + if (num_present_cpus_gt(4)) { > > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > > __func__); > > > > > > It looks as if the present variants should be using the same values > > > so the _le test above with 1 changed to 2 looks odd. > > > > I think the confusion comes from le meaning less than rather than lt. > Given the general convention of: lt (<), le (<=), eg (=), ge (>=), > gt (>), I'd consider renaming your le to lt. Ok, makes sense. I'll rename in v2 and add <= and >= versions.