Re: [PATCH V4 2/2] riscv: add RISC-V Svpbmt extension supports

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4847 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master hch-configfs/for-next v5.16-rc3 next-20211126]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/wefu-redhat-com/riscv-add-RISC-V-Svpbmt-Standard-Extension-supports/20211129-094324
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: riscv-randconfig-r042-20211128 (https://download.01.org/0day-ci/archive/20211129/202111291145.CM6aRxRv-lkp(a)intel.com/config)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b5b3142cd92db4be84159d03f650cf8e3ec00fda
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review wefu-redhat-com/riscv-add-RISC-V-Svpbmt-Standard-Extension-supports/20211129-094324
        git checkout b5b3142cd92db4be84159d03f650cf8e3ec00fda
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/riscv/include/asm/page.h:176,
                    from arch/riscv/include/asm/thread_info.h:11,
                    from include/linux/thread_info.h:60,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/riscv/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:78,
                    from include/linux/spinlock.h:55,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/mm.h:10,
                    from arch/riscv/kernel/asm-offsets.c:10:
   arch/riscv/include/asm/pgtable.h: In function 'pmd_page':
>> arch/riscv/include/asm/pgtable.h:234:28: error: implicit declaration of function '_chg_of_pmd' [-Werror=implicit-function-declaration]
     234 |         return pfn_to_page(_chg_of_pmd(pmd) >> _PAGE_PFN_SHIFT);
         |                            ^~~~~~~~~~~
   include/asm-generic/memory_model.h:40:32: note: in definition of macro '__pfn_to_page'
      40 | ({      unsigned long __pfn = (pfn);                    \
         |                                ^~~
   arch/riscv/include/asm/pgtable.h:234:16: note: in expansion of macro 'pfn_to_page'
     234 |         return pfn_to_page(_chg_of_pmd(pmd) >> _PAGE_PFN_SHIFT);
         |                ^~~~~~~~~~~
   In file included from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from arch/riscv/kernel/asm-offsets.c:10:
   arch/riscv/include/asm/pgtable.h: In function 'pte_pfn':
>> arch/riscv/include/asm/pgtable.h:255:17: error: implicit declaration of function '_chg_of_pte' [-Werror=implicit-function-declaration]
     255 |         return (_chg_of_pte(pte) >> _PAGE_PFN_SHIFT);
         |                 ^~~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:121: arch/riscv/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1197: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:219: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +/_chg_of_pmd +234 arch/riscv/include/asm/pgtable.h

   231	
   232	static inline struct page *pmd_page(pmd_t pmd)
   233	{
 > 234		return pfn_to_page(_chg_of_pmd(pmd) >> _PAGE_PFN_SHIFT);
   235	}
   236	
   237	static inline unsigned long pmd_page_vaddr(pmd_t pmd)
   238	{
   239		return (unsigned long)pfn_to_virt(_chg_of_pmd(pmd) >> _PAGE_PFN_SHIFT);
   240	}
   241	
   242	static inline pte_t pmd_pte(pmd_t pmd)
   243	{
   244		return __pte(pmd_val(pmd));
   245	}
   246	
   247	static inline pte_t pud_pte(pud_t pud)
   248	{
   249		return __pte(pud_val(pud));
   250	}
   251	
   252	/* Yields the page frame number (PFN) of a page table entry */
   253	static inline unsigned long pte_pfn(pte_t pte)
   254	{
 > 255		return (_chg_of_pte(pte) >> _PAGE_PFN_SHIFT);
   256	}
   257	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org