From: Raphael Norwitz <raphael.norwitz@nutanix.com>
To: Andy Pei <andy.pei@intel.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"mst@redhat.com" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"changpeng.liu@intel.com" <changpeng.liu@intel.com>
Subject: Re: [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
Date: Mon, 29 Nov 2021 21:57:40 +0000 [thread overview]
Message-ID: <20211129215732.GA5722@raphael-debian-dev> (raw)
In-Reply-To: <1637892018-89555-1-git-send-email-andy.pei@intel.com>
Just a commit message nit. Otherwise I'm happy with this. OFC should not
be queued for 6.2.
On Fri, Nov 26, 2021 at 10:00:18AM +0800, Andy Pei wrote:
> Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX virtio blk device
> to avoid guest DMA request size is too large to exceed hardware spec.
Grammar here. Should be something like "...DMA request sizes which are
to large for the hardware spec".
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
> ---
> hw/block/vhost-user-blk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> index ba13cb8..eb1264a 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,
> VHostUserBlk *s = VHOST_USER_BLK(vdev);
>
> /* Turn on pre-defined features */
> + virtio_add_feature(&features, VIRTIO_BLK_F_SIZE_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
> virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2021-11-29 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 2:00 [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device Andy Pei
2021-11-29 21:57 ` Raphael Norwitz [this message]
2022-01-03 9:25 ` Pei, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129215732.GA5722@raphael-debian-dev \
--to=raphael.norwitz@nutanix.com \
--cc=andy.pei@intel.com \
--cc=changpeng.liu@intel.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.