All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: pkshih@realtek.com
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] rtw89: add Realtek 802.11ax driver
Date: Tue, 30 Nov 2021 13:42:30 +0300	[thread overview]
Message-ID: <20211130104230.GE5827@kili> (raw)

Hello Ping-Ke Shih,

The patch e3ec7017f6a2: "rtw89: add Realtek 802.11ax driver" from Oct
11, 2021, leads to the following Smatch static checker warning:

	drivers/net/wireless/realtek/rtw89/mac80211.c:31 rtw89_ops_tx()
	error: uninitialized symbol 'qsel'.

drivers/net/wireless/realtek/rtw89/mac80211.c
    16 static void rtw89_ops_tx(struct ieee80211_hw *hw,
    17                          struct ieee80211_tx_control *control,
    18                          struct sk_buff *skb)
    19 {
    20         struct rtw89_dev *rtwdev = hw->priv;
    21         struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
    22         struct ieee80211_vif *vif = info->control.vif;
    23         struct ieee80211_sta *sta = control->sta;
    24         int ret, qsel;
    25 
    26         ret = rtw89_core_tx_write(rtwdev, vif, sta, skb, &qsel);
    27         if (ret) {
    28                 rtw89_err(rtwdev, "failed to transmit skb: %d\n", ret);
    29                 ieee80211_free_txskb(hw, skb);

Missing return; here?

    30         }
--> 31         rtw89_core_tx_kick_off(rtwdev, qsel);
    32 }

regards,
dan carpenter

             reply	other threads:[~2021-11-30 10:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 10:42 Dan Carpenter [this message]
2021-12-01  1:57 ` [bug report] rtw89: add Realtek 802.11ax driver Pkshih
  -- strict thread matches above, loose matches on Subject: below --
2022-12-12 15:33 Dan Carpenter
2022-12-13  0:46 ` Ping-Ke Shih
2022-12-13  4:21   ` Dan Carpenter
2021-11-12  7:51 Dan Carpenter
2021-11-15  7:33 ` Pkshih
2021-11-19  6:01   ` Pkshih
2021-11-08 14:47 Dan Carpenter
2021-11-09  1:04 ` Pkshih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130104230.GE5827@kili \
    --to=dan.carpenter@oracle.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.