Re: [PATCH V3 2/2] rtc: zynqmp: Add calibration set and get support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2652 bytes --]

Hi Srinivas,

I love your patch! Yet something to improve:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on v5.16-rc3 next-20211129]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivas-Neeli/dt-bindings-rtc-zynqmp-Add-clock-information/20211130-135800
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: i386-randconfig-a005-20211130 (https://download.01.org/0day-ci/archive/20211130/202111301703.oeV6PbAf-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/41ffd7c6e4799c865a4b74130d1bf5db3cfb85f7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Srinivas-Neeli/dt-bindings-rtc-zynqmp-Add-clock-information/20211130-135800
        git checkout 41ffd7c6e4799c865a4b74130d1bf5db3cfb85f7
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/rtc/rtc-zynqmp.o: in function `xlnx_rtc_read_offset':
>> drivers/rtc/rtc-zynqmp.c:180: undefined reference to `__divdi3'
   ld: drivers/rtc/rtc-zynqmp.o: in function `xlnx_rtc_set_offset':
   drivers/rtc/rtc-zynqmp.c:205: undefined reference to `__divdi3'


vim +180 drivers/rtc/rtc-zynqmp.c

   175	
   176	static int xlnx_rtc_read_offset(struct device *dev, long *offset)
   177	{
   178		struct xlnx_rtc_dev *xrtcdev = dev_get_drvdata(dev);
   179		long offset_val = 0;
 > 180		unsigned int tick_mult = RTC_PPB / xrtcdev->freq;
   181		unsigned int calibval;
   182	
   183		calibval = readl(xrtcdev->reg_base + RTC_CALIB_RD);
   184		/* Offset with seconds ticks */
   185		offset_val = calibval & RTC_TICK_MASK;
   186		offset_val = offset_val - RTC_CALIB_DEF;
   187		offset_val = offset_val * tick_mult;
   188	
   189		/* Offset with fractional ticks */
   190		if (calibval & RTC_FR_EN)
   191			offset_val += ((calibval & RTC_FR_MASK) >> RTC_FR_DATSHIFT)
   192				* (tick_mult / RTC_FR_MAX_TICKS);
   193		*offset = offset_val;
   194	
   195		return 0;
   196	}
   197	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org