From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC613C433F5 for ; Tue, 30 Nov 2021 17:38:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BBAC581184; Tue, 30 Nov 2021 18:37:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hiaBxR41"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B8C088306A; Tue, 30 Nov 2021 18:37:57 +0100 (CET) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 33CDC801E7 for ; Tue, 30 Nov 2021 18:37:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72d.google.com with SMTP id m186so27660435qkb.4 for ; Tue, 30 Nov 2021 09:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZRYMyIhGJhZvzNgKl1m2aTRxlkIH3Tf4pYGrAGztcVA=; b=hiaBxR41g/ZNOAmafjcTFU/BmBuaT9tJ8tTsqV9NkrC6tU1s66hEKIXAi3s8EruBaB G8BEAVkjUY2QgdMlH5r6YMMCpK0b6lo0t1I0k+CvPnqJmh2GAVjppQpD436OWDOlrZbx k9jisrrTS+Q6sk6Ez0L8fk7loUzyCckoMYfD0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZRYMyIhGJhZvzNgKl1m2aTRxlkIH3Tf4pYGrAGztcVA=; b=OjD9ZsijTjaEDOEOQYQKB7dHgtjF7yW50Ud6zGOquwpAZ/TTjL5vhR0yAYNl9wRBDB iLg95sGXtLuEefRU01G3W6WH8tc/7F+H827N72f7cv1uQh843TCkh23LSCjdceKbTrNa jSsVmC+B6gT4qPfn7rpQqAfQTZT3T7z2hxpcXqdDZiTqCUyEtib/cItpcVKMrN50BMPB Y3fBoKnLnLRg4NfV7y/XsrN2SaT5zIYeJbHcbNO09J9yZSxIOZhmK96s4+WFjsxdO3zl St57Qmd59ex0NOlBcOL0oApr3thqnFswltWmxxQBiWEd0nTpDB+ri/0fEa7b/8P6yfgN vuAg== X-Gm-Message-State: AOAM533AkU7Kn2pHMU0U+ER6+yxa/D8v0Rov4KxjsOg6ZMM3nMMOPHXU 7UELHrmXH0UfpGhqMiDHPAPKUg== X-Google-Smtp-Source: ABdhPJxGlHSKT1BaWG89XlWE6EKYcwGA1Rj/2dZhSOgudEek3fokdEO3n4L6fzRrJOJPkBoOEfFCaA== X-Received: by 2002:a05:620a:280d:: with SMTP id f13mr761046qkp.31.1638293873059; Tue, 30 Nov 2021 09:37:53 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-e478-4cc2-fb2f-8620.res6.spectrum.com. [2603:6081:7b01:cbda:e478:4cc2:fb2f:8620]) by smtp.gmail.com with ESMTPSA id bl16sm10049672qkb.44.2021.11.30.09.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 09:37:52 -0800 (PST) Date: Tue, 30 Nov 2021 12:37:50 -0500 From: Tom Rini To: Arnaud Ferraris Cc: Martijn Braam , u-boot@lists.denx.de, ~postmarketos/upstreaming@lists.sr.ht, Andre Przywara , "Arnaud Patard (Rtp)" , Christian Hewitt , Fabio Estevam , Heiko Schocher , Hugh Cole-Baker , Jagan Teki , Kever Yang , Neil Armstrong , Peter Robinson , Philipp Tomsich , Philipp Tomsich , Rick Chen , Simon Glass , Tim Harvey Subject: Re: [PATCH] rockchip: Add initial support for the PinePhone Pro Message-ID: <20211130173750.GD24579@bill-the-cat> References: <20211021171843.6301-1-martijn@brixit.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mzkJpTwdV7urqlBA" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --mzkJpTwdV7urqlBA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 30, 2021 at 05:47:25PM +0100, Arnaud Ferraris wrote: > Hi Martijn, >=20 > Thanks for this patch! It looks good overall, but I have a few minor > comments regarding the defconfig, see below. >=20 > Le 21/10/2021 =E0 19:18, Martijn Braam a =E9crit=A0: > > This is a new device by PINE64 that's very similar to the Pinebook Pro > > that's already supported. > >=20 > > Specification: > > - Rockchip RK3399 > > - 4GB Dual-Channel LPDDR4 > > - 128GB eMMC > > - mSD card slot > > - AP6255 for 802.11ac WiFi and Bluetooth > > - 6 inch 720*1440 DSI display > > - Quectel EG25g usb modem > > - Type-C port with alt-mode display (DP 1.2) and PD charging. > >=20 > > Signed-off-by: Martijn Braam > > --- > >=20 > > arch/arm/dts/Makefile | 1 + > > arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 44 ++ > > arch/arm/dts/rk3399-pinephone-pro.dts | 520 ++++++++++++++++++ I missed the first iteration, sorry, so replying here. For v2 please note what kernel arch/arm/dts/rk3399-pinephone-pro.dts is a copy from, thanks! --=20 Tom --mzkJpTwdV7urqlBA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGmYWoACgkQFHw5/5Y0 tyy7Hgv/ecQYMk0UxHtcfITu82Bp9pfV/1a0exwWsmutG4hEiNfoD3KaRvr+H7kx z2YDoVj19DjkJybZvcPPvXB/Pnog67wgS9WHMBfCJY58i5ZD/twRAK73WdNCHG6C re0TWX1OT7D8s/mCEZte9R6jcwjvhv+ua+Gu9qZx3zQYZf4urVz0W/q/1dqu0YMv HhtBAtbHOve9lFBeOrdiHDLYdUX0l7iPqu5GjyUPKMW5k2tyhsxFvBwhOSYh5tTn 1VG5Rcd/GUXObLEVvzQTw4dgjFdCom4CwcNZqhRyB2y3KkyzGI9e0+xBCAN2dPDf ljfukVTiesMAHlgd5QlA4hJHsWVwMKPxydEPgN6ySuSYavadfCTK4c57nlhq1A0X Ymz+WUSDfWxcVr1DUir76Plkr3ocGAUZlKnkM+D1ic/3slVuQO14DBfP/P8QuFQT xKYFaYWHmRkCVtYGJFnTpIAQVVtx2bkahBRxXMp770eawJgYEAdmNjrSmDOh4HxE yOf9HO1M =rGUc -----END PGP SIGNATURE----- --mzkJpTwdV7urqlBA--