From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Tamas K Lengyel" <tamas@tklengyel.com>,
"Alexandru Isaila" <aisaila@bitdefender.com>,
"Petre Pircalabu" <ppircalabu@bitdefender.com>
Subject: [PATCH 1/2] x86/hvm: Simplify hvm_enable_msr_interception()
Date: Tue, 30 Nov 2021 18:11:38 +0000 [thread overview]
Message-ID: <20211130181139.14398-2-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <20211130181139.14398-1-andrew.cooper3@citrix.com>
The sole caller doesn't check the return value, and both vendors implement the
hook.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Tamas K Lengyel <tamas@tklengyel.com>
CC: Alexandru Isaila <aisaila@bitdefender.com>
CC: Petre Pircalabu <ppircalabu@bitdefender.com>
---
xen/include/asm-x86/hvm/hvm.h | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h
index bd2cbb0e7baf..2767427aa938 100644
--- a/xen/include/asm-x86/hvm/hvm.h
+++ b/xen/include/asm-x86/hvm/hvm.h
@@ -631,15 +631,9 @@ static inline enum hvm_intblk nhvm_interrupt_blocked(struct vcpu *v)
return hvm_funcs.nhvm_intr_blocked(v);
}
-static inline bool_t hvm_enable_msr_interception(struct domain *d, uint32_t msr)
+static inline void hvm_enable_msr_interception(struct domain *d, uint32_t msr)
{
- if ( hvm_funcs.enable_msr_interception )
- {
- hvm_funcs.enable_msr_interception(d, msr);
- return 1;
- }
-
- return 0;
+ hvm_funcs.enable_msr_interception(d, msr);
}
static inline bool_t hvm_is_singlestep_supported(void)
--
2.11.0
next prev parent reply other threads:[~2021-11-30 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 18:11 [PATCH 0/2] x86/hvm: Cleanup Andrew Cooper
2021-11-30 18:11 ` Andrew Cooper [this message]
2021-12-01 9:06 ` [PATCH 1/2] x86/hvm: Simplify hvm_enable_msr_interception() Jan Beulich
2021-11-30 18:11 ` [PATCH 2/2] x86/hvm: Rework nested hap functions to reduce parameters Andrew Cooper
2021-12-01 9:14 ` Jan Beulich
2021-12-01 20:13 ` Andrew Cooper
2021-12-02 8:06 ` Jan Beulich
2022-01-13 15:21 ` [PATCH 0/2] x86/hvm: Cleanup Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130181139.14398-2-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=aisaila@bitdefender.com \
--cc=ppircalabu@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.