From: Tom Rini <trini@konsulko.com>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Arnaud Ferraris <arnaud.ferraris@collabora.com>,
Martijn Braam <martijn@brixit.nl>,
u-boot@lists.denx.de, ~postmarketos/upstreaming@lists.sr.ht,
Andre Przywara <andre.przywara@arm.com>,
"Arnaud Patard (Rtp)" <arnaud.patard@rtp-net.org>,
Christian Hewitt <christianshewitt@gmail.com>,
Fabio Estevam <festevam@gmail.com>, Heiko Schocher <hs@denx.de>,
Hugh Cole-Baker <sigmaris@gmail.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Kever Yang <kever.yang@rock-chips.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Rick Chen <rick@andestech.com>, Simon Glass <sjg@chromium.org>,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH] rockchip: Add initial support for the PinePhone Pro
Date: Tue, 30 Nov 2021 13:46:57 -0500 [thread overview]
Message-ID: <20211130184657.GI24579@bill-the-cat> (raw)
In-Reply-To: <CALeDE9PHvDg3SQ+XLbeC2wK5_1L0Qv2XiEBipWkHvx4vOx=ryg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]
On Tue, Nov 30, 2021 at 06:44:05PM +0000, Peter Robinson wrote:
> On Tue, Nov 30, 2021 at 5:37 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Nov 30, 2021 at 05:47:25PM +0100, Arnaud Ferraris wrote:
> > > Hi Martijn,
> > >
> > > Thanks for this patch! It looks good overall, but I have a few minor
> > > comments regarding the defconfig, see below.
> > >
> > > Le 21/10/2021 à 19:18, Martijn Braam a écrit :
> > > > This is a new device by PINE64 that's very similar to the Pinebook Pro
> > > > that's already supported.
> > > >
> > > > Specification:
> > > > - Rockchip RK3399
> > > > - 4GB Dual-Channel LPDDR4
> > > > - 128GB eMMC
> > > > - mSD card slot
> > > > - AP6255 for 802.11ac WiFi and Bluetooth
> > > > - 6 inch 720*1440 DSI display
> > > > - Quectel EG25g usb modem
> > > > - Type-C port with alt-mode display (DP 1.2) and PD charging.
> > > >
> > > > Signed-off-by: Martijn Braam <martijn@brixit.nl>
> > > > ---
> > > >
> > > > arch/arm/dts/Makefile | 1 +
> > > > arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 44 ++
> > > > arch/arm/dts/rk3399-pinephone-pro.dts | 520 ++++++++++++++++++
> >
> > I missed the first iteration, sorry, so replying here. For v2 please
> > note what kernel arch/arm/dts/rk3399-pinephone-pro.dts is a copy from,
> > thanks!
>
> I'm not sure it's even been posted upstream for review, I've certainly
> not seen it.
That's a red flag over here, it needs to be in linux-next or linux
proper.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-30 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 17:18 [PATCH] rockchip: Add initial support for the PinePhone Pro Martijn Braam
2021-11-30 16:47 ` Arnaud Ferraris
2021-11-30 17:37 ` Tom Rini
2021-11-30 18:44 ` Peter Robinson
2021-11-30 18:46 ` Tom Rini [this message]
2021-12-24 3:01 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130184657.GI24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=andre.przywara@arm.com \
--cc=arnaud.ferraris@collabora.com \
--cc=arnaud.patard@rtp-net.org \
--cc=christianshewitt@gmail.com \
--cc=festevam@gmail.com \
--cc=hs@denx.de \
--cc=jagan@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=martijn@brixit.nl \
--cc=narmstrong@baylibre.com \
--cc=pbrobinson@gmail.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=rick@andestech.com \
--cc=sigmaris@gmail.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.