From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1150073618572120129==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files Date: Tue, 30 Nov 2021 18:38:23 +0800 Message-ID: <202111301848.t0EBmRw2-lkp@intel.com> In-Reply-To: <1638179932-3353-4-git-send-email-srivasam@codeaurora.org> List-Id: --===============1150073618572120129== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Srinivasa, Thank you for the patch! Yet something to improve: [auto build test ERROR on linusw-pinctrl/devel] [also build test ERROR on v5.16-rc3 next-20211130] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Srinivasa-Rao-Mandadapu/Ad= d-pin-control-support-for-lpass-sc7280/20211129-180254 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctr= l.git devel config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20211130/= 202111301848.t0EBmRw2-lkp(a)intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/08f308b432fbb4f1eb2c05d94= 058fd365d79627a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Srinivasa-Rao-Mandadapu/Add-pin-co= ntrol-support-for-lpass-sc7280/20211129-180254 git checkout 08f308b432fbb4f1eb2c05d94058fd365d79627a # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darm SHELL=3D/bin/bash arch/arm/common/ drivers/pinctr= l/qcom/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_gpio_set_mux': drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:113:9: error: implicit declarat= ion of function 'u32p_replace_bits' [-Werror=3Dimplicit-function-declaratio= n] 113 | u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK); | ^~~~~~~~~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_config_get': >> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:138:16: error: implicit declara= tion of function 'FIELD_GET' [-Werror=3Dimplicit-function-declaration] 138 | pull =3D FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg); | ^~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_config_set': drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:244:23: error: implicit declara= tion of function 'u32_encode_bits' [-Werror=3Dimplicit-function-declaration] 244 | val =3D u32_encode_bits(value ? 1 : 0, LPI_GPIO_= VALUE_OUT_MASK); | ^~~~~~~~~~~~~~~ In file included from drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:15: At top level: drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:133:27: warning: 'gpio13_pins' = defined but not used [-Wunused-const-variable=3D] 133 | static const unsigned int gpio13_pins[] =3D { 13 }; | ^~~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:132:27: warning: 'gpio12_pins' = defined but not used [-Wunused-const-variable=3D] 132 | static const unsigned int gpio12_pins[] =3D { 12 }; | ^~~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:131:27: warning: 'gpio11_pins' = defined but not used [-Wunused-const-variable=3D] 131 | static const unsigned int gpio11_pins[] =3D { 11 }; | ^~~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:130:27: warning: 'gpio10_pins' = defined but not used [-Wunused-const-variable=3D] 130 | static const unsigned int gpio10_pins[] =3D { 10 }; | ^~~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:129:27: warning: 'gpio9_pins' d= efined but not used [-Wunused-const-variable=3D] 129 | static const unsigned int gpio9_pins[] =3D { 9 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:128:27: warning: 'gpio8_pins' d= efined but not used [-Wunused-const-variable=3D] 128 | static const unsigned int gpio8_pins[] =3D { 8 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:127:27: warning: 'gpio7_pins' d= efined but not used [-Wunused-const-variable=3D] 127 | static const unsigned int gpio7_pins[] =3D { 7 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:126:27: warning: 'gpio6_pins' d= efined but not used [-Wunused-const-variable=3D] 126 | static const unsigned int gpio6_pins[] =3D { 6 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:125:27: warning: 'gpio5_pins' d= efined but not used [-Wunused-const-variable=3D] 125 | static const unsigned int gpio5_pins[] =3D { 5 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:124:27: warning: 'gpio4_pins' d= efined but not used [-Wunused-const-variable=3D] 124 | static const unsigned int gpio4_pins[] =3D { 4 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:123:27: warning: 'gpio3_pins' d= efined but not used [-Wunused-const-variable=3D] 123 | static const unsigned int gpio3_pins[] =3D { 3 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:122:27: warning: 'gpio2_pins' d= efined but not used [-Wunused-const-variable=3D] 122 | static const unsigned int gpio2_pins[] =3D { 2 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:121:27: warning: 'gpio1_pins' d= efined but not used [-Wunused-const-variable=3D] 121 | static const unsigned int gpio1_pins[] =3D { 1 }; | ^~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:120:27: warning: 'gpio0_pins' d= efined but not used [-Wunused-const-variable=3D] 120 | static const unsigned int gpio0_pins[] =3D { 0 }; | ^~~~~~~~~~ cc1: some warnings being treated as errors vim +/FIELD_GET +138 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c 6e261d1090d6db Srinivas Kandagatla 2020-12-02 125 = 6e261d1090d6db Srinivas Kandagatla 2020-12-02 126 static int lpi_config_g= et(struct pinctrl_dev *pctldev, 6e261d1090d6db Srinivas Kandagatla 2020-12-02 127 unsigned int pin, = unsigned long *config) 6e261d1090d6db Srinivas Kandagatla 2020-12-02 128 { 6e261d1090d6db Srinivas Kandagatla 2020-12-02 129 unsigned int param =3D= pinconf_to_config_param(*config); 6e261d1090d6db Srinivas Kandagatla 2020-12-02 130 struct lpi_pinctrl *st= ate =3D dev_get_drvdata(pctldev->dev); 6e261d1090d6db Srinivas Kandagatla 2020-12-02 131 unsigned int arg =3D 0; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 132 int is_out; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 133 int pull; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 134 u32 ctl_reg; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 135 = 6e261d1090d6db Srinivas Kandagatla 2020-12-02 136 ctl_reg =3D lpi_gpio_r= ead(state, pin, LPI_GPIO_CFG_REG); 6e261d1090d6db Srinivas Kandagatla 2020-12-02 137 is_out =3D ctl_reg & L= PI_GPIO_OE_MASK; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 @138 pull =3D FIELD_GET(LPI= _GPIO_PULL_MASK, ctl_reg); 6e261d1090d6db Srinivas Kandagatla 2020-12-02 139 = 6e261d1090d6db Srinivas Kandagatla 2020-12-02 140 switch (param) { 6e261d1090d6db Srinivas Kandagatla 2020-12-02 141 case PIN_CONFIG_BIAS_D= ISABLE: 6e261d1090d6db Srinivas Kandagatla 2020-12-02 142 if (pull =3D=3D LPI_G= PIO_BIAS_DISABLE) 6e261d1090d6db Srinivas Kandagatla 2020-12-02 143 arg =3D 1; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 144 break; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 145 case PIN_CONFIG_BIAS_P= ULL_DOWN: 6e261d1090d6db Srinivas Kandagatla 2020-12-02 146 if (pull =3D=3D LPI_G= PIO_PULL_DOWN) 6e261d1090d6db Srinivas Kandagatla 2020-12-02 147 arg =3D 1; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 148 break; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 149 case PIN_CONFIG_BIAS_B= US_HOLD: 6e261d1090d6db Srinivas Kandagatla 2020-12-02 150 if (pull =3D=3D LPI_G= PIO_KEEPER) 6e261d1090d6db Srinivas Kandagatla 2020-12-02 151 arg =3D 1; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 152 break; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 153 case PIN_CONFIG_BIAS_P= ULL_UP: 6e261d1090d6db Srinivas Kandagatla 2020-12-02 154 if (pull =3D=3D LPI_G= PIO_PULL_UP) 6e261d1090d6db Srinivas Kandagatla 2020-12-02 155 arg =3D 1; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 156 break; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 157 case PIN_CONFIG_INPUT_= ENABLE: 6e261d1090d6db Srinivas Kandagatla 2020-12-02 158 case PIN_CONFIG_OUTPUT: 6e261d1090d6db Srinivas Kandagatla 2020-12-02 159 if (is_out) 6e261d1090d6db Srinivas Kandagatla 2020-12-02 160 arg =3D 1; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 161 break; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 162 default: 6e261d1090d6db Srinivas Kandagatla 2020-12-02 163 return -EINVAL; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 164 } 6e261d1090d6db Srinivas Kandagatla 2020-12-02 165 = 6e261d1090d6db Srinivas Kandagatla 2020-12-02 166 *config =3D pinconf_to= _config_packed(param, arg); 6e261d1090d6db Srinivas Kandagatla 2020-12-02 167 return 0; 6e261d1090d6db Srinivas Kandagatla 2020-12-02 168 } 6e261d1090d6db Srinivas Kandagatla 2020-12-02 169 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============1150073618572120129==--