Re: [PATCH v1 1/1] binman: Do not pollute source tree when build with `make O=...`

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

On Tue, Nov 30, 2021 at 09:10:11PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 30, 2021 at 9:06 PM Tom Rini <trini@konsulko.com> wrote:
> > On Tue, Nov 30, 2021 at 08:58:25PM +0200, Andy Shevchenko wrote:
> > > On Tue, Nov 30, 2021 at 8:52 PM Tom Rini <trini@konsulko.com> wrote:
> > > > On Tue, Nov 30, 2021 at 09:42:04PM +0300, Andy Shevchenko wrote:
> > > > > +#
> > > > > +# Do not pollute source tree with cache files:
> > > > > +# https://stackoverflow.com/a/60024195/2511795
> > > > > +# https://bugs.python.org/issue33499
> > > > > +#
> > > > > +sys.pycache_prefix = os.path.relpath(os.path.dirname(sys.argv[0]), os.environ['srctree'])
> > > > > +
> > > > >  # Bring in the patman and dtoc libraries (but don't override the first path
> > > > >  # in PYTHONPATH)
> > > > >  our_path = os.path.dirname(os.path.realpath(__file__))
> > > >
> > > > Do we need some wrapper around this so it doesn't blow up on older than
> > > > Python 3.8?
> > >
> > > Why does it blow? Some global variables which won't be used by older versions.
> >
> > Does it?  I don't know, I wasn't clear enough, sorry.  What happens on
> > an older python here?  Silent ignore is fine.
> 
> Usually that's the idea that new features are hardly tried to be
> backward compatible (yes, I know that the history of Python had a lot
> of counter examples, but still). In any case, that one was never used
> before.
> 
> You may try yourself, btw:
> 
> sys.foobar = "blablabla"

Ah ok, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]