From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810412C9D for ; Tue, 30 Nov 2021 11:19:48 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10183"; a="216887584" X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="216887584" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 03:19:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="540375411" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2021 03:19:46 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1ms1An-000DCt-Nm; Tue, 30 Nov 2021 11:19:45 +0000 Date: Tue, 30 Nov 2021 19:18:55 +0800 From: kernel test robot To: Luca Coelho Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org Subject: Re: [PATCH 04/16] cfg80211: Use the HE operation IE to determine a 6GHz BSS channel Message-ID: <202111301955.BdSRnKyU-lkp@intel.com> References: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Hi Luca, Thank you for the patch! Yet something to improve: [auto build test ERROR on jberg-mac80211-next/master] [also build test ERROR on next-20211130] [cannot apply to jberg-mac80211/master linus/master v5.16-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/cfg80211-mac80211-patches-from-our-internal-tree-2021-11-29/20211129-213704 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master config: riscv-randconfig-c006-20211128 (https://download.01.org/0day-ci/archive/20211130/202111301955.BdSRnKyU-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 25eb7fa01d7ebbe67648ea03841cda55b4239ab2) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/da233d0b8179f2db6b1f5e783da1c0b986cc8e96 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Luca-Coelho/cfg80211-mac80211-patches-from-our-internal-tree-2021-11-29/20211129-213704 git checkout da233d0b8179f2db6b1f5e783da1c0b986cc8e96 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash net/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/wireless/scan.c:1801:6: error: use of undeclared identifier 'channel' if (channel->band == NL80211_BAND_6GHZ) { ^ net/wireless/scan.c:1813:12: error: use of undeclared identifier 'channel' return channel; ^ >> net/wireless/scan.c:1815:4: error: use of undeclared identifier 'freq' freq = ieee80211_channel_to_frequency(he_6ghz_oper->primary, ^ net/wireless/scan.c:1822:12: error: use of undeclared identifier 'freq' abs(freq - channel->center_freq) <= 80 && ^ net/wireless/scan.c:1822:19: error: use of undeclared identifier 'channel' abs(freq - channel->center_freq) <= 80 && ^ net/wireless/scan.c:1822:12: error: use of undeclared identifier 'freq' abs(freq - channel->center_freq) <= 80 && ^ net/wireless/scan.c:1822:19: error: use of undeclared identifier 'channel' abs(freq - channel->center_freq) <= 80 && ^ net/wireless/scan.c:1821:8: error: use of undeclared identifier 'freq' if (freq != channel->center_freq && ^ net/wireless/scan.c:1821:16: error: use of undeclared identifier 'channel' if (freq != channel->center_freq && ^ >> net/wireless/scan.c:1823:9: error: use of undeclared identifier 'ftype'; did you mean '_ctype'? (ftype != CFG80211_BSS_FTYPE_BEACON || ^~~~~ _ctype include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 10 errors generated. vim +/channel +1801 net/wireless/scan.c 1794 1795 int cfg80211_get_ies_channel_number(const u8 *ie, size_t ielen, 1796 enum nl80211_band band) 1797 { 1798 const u8 *tmp; 1799 int channel_number = -1; 1800 > 1801 if (channel->band == NL80211_BAND_6GHZ) { 1802 const struct element *elem; 1803 1804 elem = cfg80211_find_ext_elem(WLAN_EID_EXT_HE_OPERATION, ie, 1805 ielen); 1806 if (elem && elem->datalen >= ieee80211_he_oper_size(&elem->data[1])) { 1807 struct ieee80211_he_operation *he_oper = 1808 (void *)(&elem->data[1]); 1809 const struct ieee80211_he_6ghz_oper *he_6ghz_oper; 1810 1811 he_6ghz_oper = ieee80211_he_6ghz_oper(he_oper); 1812 if (!he_6ghz_oper) 1813 return channel; 1814 > 1815 freq = ieee80211_channel_to_frequency(he_6ghz_oper->primary, 1816 NL80211_BAND_6GHZ); 1817 1818 /* duplicated beacon indication is relevant for beacons 1819 * only 1820 */ 1821 if (freq != channel->center_freq && 1822 abs(freq - channel->center_freq) <= 80 && > 1823 (ftype != CFG80211_BSS_FTYPE_BEACON || 1824 he_6ghz_oper->control & IEEE80211_HE_6GHZ_OPER_CTRL_DUP_BEACON)) 1825 channel_number = he_6ghz_oper->primary; 1826 } 1827 } else if (band == NL80211_BAND_S1GHZ) { 1828 tmp = cfg80211_find_ie(WLAN_EID_S1G_OPERATION, ie, ielen); 1829 if (tmp && tmp[1] >= sizeof(struct ieee80211_s1g_oper_ie)) { 1830 struct ieee80211_s1g_oper_ie *s1gop = (void *)(tmp + 2); 1831 1832 channel_number = s1gop->primary_ch; 1833 } 1834 } else { 1835 tmp = cfg80211_find_ie(WLAN_EID_DS_PARAMS, ie, ielen); 1836 if (tmp && tmp[1] == 1) { 1837 channel_number = tmp[2]; 1838 } else { 1839 tmp = cfg80211_find_ie(WLAN_EID_HT_OPERATION, ie, ielen); 1840 if (tmp && tmp[1] >= sizeof(struct ieee80211_ht_operation)) { 1841 struct ieee80211_ht_operation *htop = (void *)(tmp + 2); 1842 1843 channel_number = htop->primary_chan; 1844 } 1845 } 1846 } 1847 1848 return channel_number; 1849 } 1850 EXPORT_SYMBOL(cfg80211_get_ies_channel_number); 1851 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4788177946758473651==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 04/16] cfg80211: Use the HE operation IE to determine a 6GHz BSS channel Date: Tue, 30 Nov 2021 19:18:55 +0800 Message-ID: <202111301955.BdSRnKyU-lkp@intel.com> In-Reply-To: List-Id: --===============4788177946758473651== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Luca, Thank you for the patch! Yet something to improve: [auto build test ERROR on jberg-mac80211-next/master] [also build test ERROR on next-20211130] [cannot apply to jberg-mac80211/master linus/master v5.16-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Luca-Coelho/cfg80211-mac80= 211-patches-from-our-internal-tree-2021-11-29/20211129-213704 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next= .git master config: riscv-randconfig-c006-20211128 (https://download.01.org/0day-ci/arc= hive/20211130/202111301955.BdSRnKyU-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 25eb7f= a01d7ebbe67648ea03841cda55b4239ab2) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/da233d0b8179f2db6b1f5e783= da1c0b986cc8e96 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Luca-Coelho/cfg80211-mac80211-patc= hes-from-our-internal-tree-2021-11-29/20211129-213704 git checkout da233d0b8179f2db6b1f5e783da1c0b986cc8e96 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Driscv SHELL=3D/bin/bash net/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/wireless/scan.c:1801:6: error: use of undeclared identifier 'channel' if (channel->band =3D=3D NL80211_BAND_6GHZ) { ^ net/wireless/scan.c:1813:12: error: use of undeclared identifier 'channe= l' return channel; ^ >> net/wireless/scan.c:1815:4: error: use of undeclared identifier 'freq' freq =3D ieee80211_channel_to_frequency(he_6ghz_= oper->primary, ^ net/wireless/scan.c:1822:12: error: use of undeclared identifier 'freq' abs(freq - channel->center_freq) <=3D 80 && ^ net/wireless/scan.c:1822:19: error: use of undeclared identifier 'channe= l' abs(freq - channel->center_freq) <=3D 80 && ^ net/wireless/scan.c:1822:12: error: use of undeclared identifier 'freq' abs(freq - channel->center_freq) <=3D 80 && ^ net/wireless/scan.c:1822:19: error: use of undeclared identifier 'channe= l' abs(freq - channel->center_freq) <=3D 80 && ^ net/wireless/scan.c:1821:8: error: use of undeclared identifier 'freq' if (freq !=3D channel->center_freq && ^ net/wireless/scan.c:1821:16: error: use of undeclared identifier 'channe= l' if (freq !=3D channel->center_freq && ^ >> net/wireless/scan.c:1823:9: error: use of undeclared identifier 'ftype';= did you mean '_ctype'? (ftype !=3D CFG80211_BSS_FTYPE_BEACON || ^~~~~ _ctype include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 10 errors generated. vim +/channel +1801 net/wireless/scan.c 1794 = 1795 int cfg80211_get_ies_channel_number(const u8 *ie, size_t ielen, 1796 enum nl80211_band band) 1797 { 1798 const u8 *tmp; 1799 int channel_number =3D -1; 1800 = > 1801 if (channel->band =3D=3D NL80211_BAND_6GHZ) { 1802 const struct element *elem; 1803 = 1804 elem =3D cfg80211_find_ext_elem(WLAN_EID_EXT_HE_OPERATION, ie, 1805 ielen); 1806 if (elem && elem->datalen >=3D ieee80211_he_oper_size(&elem->data[= 1])) { 1807 struct ieee80211_he_operation *he_oper =3D 1808 (void *)(&elem->data[1]); 1809 const struct ieee80211_he_6ghz_oper *he_6ghz_oper; 1810 = 1811 he_6ghz_oper =3D ieee80211_he_6ghz_oper(he_oper); 1812 if (!he_6ghz_oper) 1813 return channel; 1814 = > 1815 freq =3D ieee80211_channel_to_frequency(he_6ghz_oper->primary, 1816 NL80211_BAND_6GHZ); 1817 = 1818 /* duplicated beacon indication is relevant for beacons 1819 * only 1820 */ 1821 if (freq !=3D channel->center_freq && 1822 abs(freq - channel->center_freq) <=3D 80 && > 1823 (ftype !=3D CFG80211_BSS_FTYPE_BEACON || 1824 he_6ghz_oper->control & IEEE80211_HE_6GHZ_OPER_CTRL_DUP_BEAC= ON)) 1825 channel_number =3D he_6ghz_oper->primary; 1826 } 1827 } else if (band =3D=3D NL80211_BAND_S1GHZ) { 1828 tmp =3D cfg80211_find_ie(WLAN_EID_S1G_OPERATION, ie, ielen); 1829 if (tmp && tmp[1] >=3D sizeof(struct ieee80211_s1g_oper_ie)) { 1830 struct ieee80211_s1g_oper_ie *s1gop =3D (void *)(tmp + 2); 1831 = 1832 channel_number =3D s1gop->primary_ch; 1833 } 1834 } else { 1835 tmp =3D cfg80211_find_ie(WLAN_EID_DS_PARAMS, ie, ielen); 1836 if (tmp && tmp[1] =3D=3D 1) { 1837 channel_number =3D tmp[2]; 1838 } else { 1839 tmp =3D cfg80211_find_ie(WLAN_EID_HT_OPERATION, ie, ielen); 1840 if (tmp && tmp[1] >=3D sizeof(struct ieee80211_ht_operation)) { 1841 struct ieee80211_ht_operation *htop =3D (void *)(tmp + 2); 1842 = 1843 channel_number =3D htop->primary_chan; 1844 } 1845 } 1846 } 1847 = 1848 return channel_number; 1849 } 1850 EXPORT_SYMBOL(cfg80211_get_ies_channel_number); 1851 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4788177946758473651==--