From: Nathan Chancellor <nathan@kernel.org>
To: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>,
Russ Weight <russell.h.weight@intel.com>,
Tom Rix <trix@redhat.com>
Subject: [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()
Date: Tue, 30 Nov 2021 15:11:24 -0700 [thread overview]
Message-ID: <20211130221123.3800420-1-nathan@kernel.org> (raw)
Clang warns:
drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
return ret;
^~~
ret is only assigned in an error path now so just return 0 directly.
Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1517
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
Reviewed-by: Tom Rix <trix@redhat.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
v1 -> v2: https://lore.kernel.org/r/20211129161009.3625548-1-nathan@kernel.org/
* Drop clang's suggestion text (Tom).
* Pick up Russ and Tom's review tags.
drivers/fpga/stratix10-soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 737d14c6e0de..357cea58ec98 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, mgr);
- return ret;
+ return 0;
probe_err:
stratix10_svc_free_channel(priv->chan);
base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac
--
2.34.1
next reply other threads:[~2021-11-30 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 22:11 Nathan Chancellor [this message]
2021-12-01 0:48 ` [PATCH v2] fpga: stratix10-soc: Do not use ret uninitialized in s10_probe() Xu Yilun
2021-12-03 4:10 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130221123.3800420-1-nathan@kernel.org \
--to=nathan@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mdf@kernel.org \
--cc=ndesaulniers@google.com \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.