From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1448FC433FE for ; Thu, 2 Dec 2021 11:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346582AbhLBLwd convert rfc822-to-8bit (ORCPT ); Thu, 2 Dec 2021 06:52:33 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:40113 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346549AbhLBLw3 (ORCPT ); Thu, 2 Dec 2021 06:52:29 -0500 Received: (Authenticated sender: herve.codina@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 4E29B240004; Thu, 2 Dec 2021 11:48:58 +0000 (UTC) Date: Thu, 2 Dec 2021 12:48:55 +0100 From: Herve Codina To: Viresh Kumar Cc: Viresh Kumar , Shiraz Hashim , soc@kernel.org, Rob Herring , Thomas Gleixner , Marc Zyngier , Linus Walleij , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 0/6] spear: Fix SPEAr3XX plgpio support Message-ID: <20211202124855.1c1298e7@bootlin.com> In-Reply-To: <20211202112700.mkjmwibabj2cpr6u@vireshk-i7> References: <20211202095255.165797-1-herve.codina@bootlin.com> <20211202112700.mkjmwibabj2cpr6u@vireshk-i7> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 2 Dec 2021 16:57:00 +0530 Viresh Kumar wrote: > On 02-12-21, 10:52, Herve Codina wrote: > > Hi, > > > > This patch series fixes the plgpio support on SPEAr3xx SOCs. > > > > The first four patches of this series fixes a ressources > > sharing issue between the plgpio driver and the pinmux > > driver. > > Indeed, these two drivers can use the same IO address range > > on some SPEAr3xx SOCs. > > To solve the issue, a regmap (syscon managed) is used in both > > drivers and the plgpio driver can reference the pinmux regmap > > to use it. > > > > The second part of this series is related to IRQs. > > The plgpio on SPEAr320s SOC uses an IRQ line in the reserve > > range (from SPEAr320 point of view). > > This issue is fixed enabling all the 'reserved' IRQs and > > adding a dtsi file for the SPEAr320s with the correct interrupt > > for the plgpio node. > > Are these changes backwards compatible ? I mean new kernel will work > with old DTBs ? It may be quite important to not break that here. > Yes they are. - the regmap reference (phandle) is optional. - The IRQ for plgpio is used only on the new spear320s.dtsi. I have not seen any issues on my board (spear320s SOC) when I only add support for the 'reserved' IRQs (ie no spurious interrupts occur when I apply the patch related to shirq). I cannot test on SPEAr320 SOC as I haven't got any board with this SOC. Herve -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF108C433F5 for ; Thu, 2 Dec 2021 11:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U9iUn+8q4c15kkCp6Xg2Al12itC/Wozg/XStTJeddb0=; b=sGBGUEC4WCvgDn XMIGQVtnuiLkEBfCwm2g57iZcLpVFbafWjb9wDp7gQ/DQvndpOrLJ8bQ5TGGlOcOhrj1zF1JbUt6Y O/8nA/IY3b4u6bDylbYvVDaqz2YUMx6voAT91dte1K3ru3lCJJ+AsMFv8ET4LZDIwFOpErkDwI96X WDU7usrDxDmsVlDzM7DeitZ8jlRz2HWO5nt1Vkwe0ef7t/qlo/0NRDus6IQzaLUTab8y0K/IjSIlc E8tpUaL5jlzYYJxSy7qM82RWU34WOSIp+ELWddrzFIQb0jfsdccZZltwDYRvdMrSB/zqSk81zBP/s zBV1PgU849zEMNx/vgbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mskaJ-00C37x-UF; Thu, 02 Dec 2021 11:49:08 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mskaF-00C37D-MK for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 11:49:05 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 4E29B240004; Thu, 2 Dec 2021 11:48:58 +0000 (UTC) Date: Thu, 2 Dec 2021 12:48:55 +0100 From: Herve Codina To: Viresh Kumar Cc: Viresh Kumar , Shiraz Hashim , soc@kernel.org, Rob Herring , Thomas Gleixner , Marc Zyngier , Linus Walleij , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 0/6] spear: Fix SPEAr3XX plgpio support Message-ID: <20211202124855.1c1298e7@bootlin.com> In-Reply-To: <20211202112700.mkjmwibabj2cpr6u@vireshk-i7> References: <20211202095255.165797-1-herve.codina@bootlin.com> <20211202112700.mkjmwibabj2cpr6u@vireshk-i7> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211202_034903_892234_84BA47D4 X-CRM114-Status: GOOD ( 24.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyIERlYyAyMDIxIDE2OjU3OjAwICswNTMwClZpcmVzaCBLdW1hciA8dmlyZXNoLmt1 bWFyQGxpbmFyby5vcmc+IHdyb3RlOgoKPiBPbiAwMi0xMi0yMSwgMTA6NTIsIEhlcnZlIENvZGlu YSB3cm90ZToKPiA+IEhpLAo+ID4gCj4gPiBUaGlzIHBhdGNoIHNlcmllcyBmaXhlcyB0aGUgcGxn cGlvIHN1cHBvcnQgb24gU1BFQXIzeHggU09Dcy4KPiA+IAo+ID4gVGhlIGZpcnN0IGZvdXIgcGF0 Y2hlcyBvZiB0aGlzIHNlcmllcyBmaXhlcyBhIHJlc3NvdXJjZXMKPiA+IHNoYXJpbmcgaXNzdWUg YmV0d2VlbiB0aGUgcGxncGlvIGRyaXZlciBhbmQgdGhlIHBpbm11eAo+ID4gZHJpdmVyLgo+ID4g SW5kZWVkLCB0aGVzZSB0d28gZHJpdmVycyBjYW4gdXNlIHRoZSBzYW1lIElPIGFkZHJlc3MgcmFu Z2UKPiA+IG9uIHNvbWUgU1BFQXIzeHggU09Dcy4KPiA+IFRvIHNvbHZlIHRoZSBpc3N1ZSwgYSBy ZWdtYXAgKHN5c2NvbiBtYW5hZ2VkKSBpcyB1c2VkIGluIGJvdGgKPiA+IGRyaXZlcnMgYW5kIHRo ZSBwbGdwaW8gZHJpdmVyIGNhbiByZWZlcmVuY2UgdGhlIHBpbm11eCByZWdtYXAKPiA+IHRvIHVz ZSBpdC4KPiA+IAo+ID4gVGhlIHNlY29uZCBwYXJ0IG9mIHRoaXMgc2VyaWVzIGlzIHJlbGF0ZWQg dG8gSVJRcy4KPiA+IFRoZSBwbGdwaW8gb24gU1BFQXIzMjBzIFNPQyB1c2VzIGFuIElSUSBsaW5l IGluIHRoZSByZXNlcnZlCj4gPiByYW5nZSAoZnJvbSBTUEVBcjMyMCBwb2ludCBvZiB2aWV3KS4K PiA+IFRoaXMgaXNzdWUgaXMgZml4ZWQgZW5hYmxpbmcgYWxsIHRoZSAncmVzZXJ2ZWQnIElSUXMg YW5kCj4gPiBhZGRpbmcgYSBkdHNpIGZpbGUgZm9yIHRoZSBTUEVBcjMyMHMgd2l0aCB0aGUgY29y cmVjdCBpbnRlcnJ1cHQKPiA+IGZvciB0aGUgcGxncGlvIG5vZGUuICAKPiAKPiBBcmUgdGhlc2Ug Y2hhbmdlcyBiYWNrd2FyZHMgY29tcGF0aWJsZSA/IEkgbWVhbiBuZXcga2VybmVsIHdpbGwgd29y awo+IHdpdGggb2xkIERUQnMgPyBJdCBtYXkgYmUgcXVpdGUgaW1wb3J0YW50IHRvIG5vdCBicmVh ayB0aGF0IGhlcmUuCj4gCgpZZXMgdGhleSBhcmUuCi0gdGhlIHJlZ21hcCByZWZlcmVuY2UgKHBo YW5kbGUpIGlzIG9wdGlvbmFsLgotIFRoZSBJUlEgZm9yIHBsZ3BpbyBpcyB1c2VkIG9ubHkgb24g dGhlIG5ldyBzcGVhcjMyMHMuZHRzaS4KCkkgaGF2ZSBub3Qgc2VlbiBhbnkgaXNzdWVzIG9uIG15 IGJvYXJkIChzcGVhcjMyMHMgU09DKSB3aGVuIEkgb25seSBhZGQgc3VwcG9ydApmb3IgdGhlICdy ZXNlcnZlZCcgSVJRcyAoaWUgbm8gc3B1cmlvdXMgaW50ZXJydXB0cyBvY2N1ciB3aGVuIEkgYXBw bHkgdGhlIHBhdGNoCnJlbGF0ZWQgdG8gc2hpcnEpLgpJIGNhbm5vdCB0ZXN0IG9uIFNQRUFyMzIw IFNPQyBhcyBJIGhhdmVuJ3QgZ290IGFueSBib2FyZCB3aXRoIHRoaXMgU09DLgoKSGVydmUKCi0t IApIZXJ2w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5l ZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=