From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH net v2 3/6] net: dsa: mv88e6xxx: Save power by disabling SerDes trasmitter and receiver
Date: Thu, 02 Dec 2021 18:37:01 +0800 [thread overview]
Message-ID: <202112021828.M2Es3NN7-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3573 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20211130170151.7741-4-kabel@kernel.org>
References: <20211130170151.7741-4-kabel@kernel.org>
TO: "Marek Behún" <kabel@kernel.org>
Hi "Marek,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Marek-Beh-n/mv88e6xxx-fixes-mainly-88E6393X-family/20211201-011600
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 34d8778a943761121f391b7921f79a7adbe1feaf
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: arm-randconfig-m031-20211128 (https://download.01.org/0day-ci/archive/20211202/202112021828.M2Es3NN7-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/dsa/mv88e6xxx/serdes.c:1409 mv88e6393x_serdes_power() error: uninitialized symbol 'err'.
vim +/err +1409 drivers/net/dsa/mv88e6xxx/serdes.c
de776d0d316f72 Pavana Sharma 2021-03-17 1377
de776d0d316f72 Pavana Sharma 2021-03-17 1378 int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
de776d0d316f72 Pavana Sharma 2021-03-17 1379 bool on)
de776d0d316f72 Pavana Sharma 2021-03-17 1380 {
de776d0d316f72 Pavana Sharma 2021-03-17 1381 u8 cmode = chip->ports[port].cmode;
4ac5ae42775ac2 Marek Behún 2021-11-30 1382 int err;
de776d0d316f72 Pavana Sharma 2021-03-17 1383
de776d0d316f72 Pavana Sharma 2021-03-17 1384 if (port != 0 && port != 9 && port != 10)
de776d0d316f72 Pavana Sharma 2021-03-17 1385 return -EOPNOTSUPP;
de776d0d316f72 Pavana Sharma 2021-03-17 1386
4ac5ae42775ac2 Marek Behún 2021-11-30 1387 if (on) {
4ac5ae42775ac2 Marek Behún 2021-11-30 1388 err = mv88e6393x_serdes_erratum_4_8(chip, lane);
4ac5ae42775ac2 Marek Behún 2021-11-30 1389 if (err)
4ac5ae42775ac2 Marek Behún 2021-11-30 1390 return err;
89085d6bbe9f67 Marek Behún 2021-11-30 1391
89085d6bbe9f67 Marek Behún 2021-11-30 1392 err = mv88e6393x_serdes_power_lane(chip, lane, true);
89085d6bbe9f67 Marek Behún 2021-11-30 1393 if (err)
89085d6bbe9f67 Marek Behún 2021-11-30 1394 return err;
4ac5ae42775ac2 Marek Behún 2021-11-30 1395 }
4ac5ae42775ac2 Marek Behún 2021-11-30 1396
de776d0d316f72 Pavana Sharma 2021-03-17 1397 switch (cmode) {
de776d0d316f72 Pavana Sharma 2021-03-17 1398 case MV88E6XXX_PORT_STS_CMODE_SGMII:
de776d0d316f72 Pavana Sharma 2021-03-17 1399 case MV88E6XXX_PORT_STS_CMODE_1000BASEX:
de776d0d316f72 Pavana Sharma 2021-03-17 1400 case MV88E6XXX_PORT_STS_CMODE_2500BASEX:
89085d6bbe9f67 Marek Behún 2021-11-30 1401 err = mv88e6390_serdes_power_sgmii(chip, lane, on);
89085d6bbe9f67 Marek Behún 2021-11-30 1402 break;
de776d0d316f72 Pavana Sharma 2021-03-17 1403 case MV88E6393X_PORT_STS_CMODE_5GBASER:
de776d0d316f72 Pavana Sharma 2021-03-17 1404 case MV88E6393X_PORT_STS_CMODE_10GBASER:
89085d6bbe9f67 Marek Behún 2021-11-30 1405 err = mv88e6390_serdes_power_10g(chip, lane, on);
89085d6bbe9f67 Marek Behún 2021-11-30 1406 break;
de776d0d316f72 Pavana Sharma 2021-03-17 1407 }
de776d0d316f72 Pavana Sharma 2021-03-17 1408
89085d6bbe9f67 Marek Behún 2021-11-30 @1409 if (err)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2021-12-02 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 10:37 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-30 17:01 [PATCH net v2 0/6] mv88e6xxx fixes (mainly 88E6393X family) Marek Behún
2021-11-30 17:01 ` [PATCH net v2 3/6] net: dsa: mv88e6xxx: Save power by disabling SerDes trasmitter and receiver Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112021828.M2Es3NN7-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.