All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>, Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	David Dai <daidavid1@codeaurora.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH] spmi: pmic-arb: Add support for PMIC v7
Date: Thu, 02 Dec 2021 15:06:23 -0800	[thread overview]
Message-ID: <20211202230624.C05F3C00446@smtp.kernel.org> (raw)
In-Reply-To: <20211201072718.3969011-1-vkoul@kernel.org>

Quoting Vinod Koul (2021-11-30 23:27:18)
> @@ -1169,8 +1270,12 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
>         pmic_arb = spmi_controller_get_drvdata(ctrl);
>         pmic_arb->spmic = ctrl;
>  
> +       /*
> +        * Don't use devm_ioremap_resource() as the resources are shared in
> +        * PMIC v7 onwards, so causing failure when mapping
> +        */
>         res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
> -       core = devm_ioremap_resource(&ctrl->dev, res);
> +       core = devm_ioremap(&ctrl->dev, res->start, resource_size(res));

What does this mean? We have two nodes in DT that have the same reg
properties? How does that work?

>         if (IS_ERR(core)) {
>                 err = PTR_ERR(core);
>                 goto err_put_ctrl;

  reply	other threads:[~2021-12-02 23:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  7:27 [PATCH] spmi: pmic-arb: Add support for PMIC v7 Vinod Koul
2021-12-02 23:06 ` Stephen Boyd [this message]
2021-12-02 23:51   ` David Collins
2021-12-03  3:13     ` Stephen Boyd
2021-12-04  0:45       ` David Collins
2021-12-07 11:52         ` Vinod Koul
2021-12-10  2:01           ` Stephen Boyd
2021-12-07 11:49     ` Vinod Koul
2021-12-02 23:09 ` Subbaraman Narayanamurthy
2021-12-07 11:47   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202230624.C05F3C00446@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daidavid1@codeaurora.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.