From: Ramalingam C <ramalingam.c@intel.com>
To: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/3] Replace VT-d workaround with guard pages
Date: Fri, 3 Dec 2021 16:41:54 +0530 [thread overview]
Message-ID: <20211203111154.GF25851@intel.com> (raw)
In-Reply-To: <20211202092424.4000107-1-tejaskumarx.surendrakumar.upadhyay@intel.com>
On 2021-12-02 at 14:54:21 +0530, Tejas Upadhyay wrote:
> Replace filling the GGTT entirely with scratch pages to avoid invalid
> accesses from VT-d overfetch of scanout by only surrounding scanout vma
> with guard pages. This eliminates the 100+ms delay in resume where we
> have to repopulate the GGTT with scratch.
>
> This should also help in avoiding slow suspend/resume on GEN11/12
> platforms. Which will also resolve issues with following reported
> errors : "slow framebuffer consoles issue impacts Linux S3"
Please remove the R-b tag received not from upstreaming review and
change logs for the iterations happened somewhere else.
Ram.
>
> V2: solved checkpatch warning
>
> Chris Wilson (3):
> drm/i915: Wrap all access to i915_vma.node.start|size
> drm/i915: Introduce guard pages to i915_vma
> drm/i915: Refine VT-d scanout workaround
>
> drivers/gpu/drm/i915/display/intel_dpt.c | 4 +-
> drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +-
> drivers/gpu/drm/i915/gem/i915_gem_domain.c | 13 +++++
> .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 34 ++++++------
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +-
> drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +-
> drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 4 +-
> .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +-
> .../i915/gem/selftests/i915_gem_client_blt.c | 15 ++---
> .../drm/i915/gem/selftests/i915_gem_context.c | 19 +++++--
> .../drm/i915/gem/selftests/i915_gem_mman.c | 2 +-
> .../drm/i915/gem/selftests/igt_gem_utils.c | 6 +-
> drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 2 +-
> drivers/gpu/drm/i915/gt/gen7_renderclear.c | 2 +-
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +--
> drivers/gpu/drm/i915/gt/intel_ggtt.c | 42 +++++---------
> drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 3 +-
> drivers/gpu/drm/i915/gt/intel_ppgtt.c | 5 +-
> drivers/gpu/drm/i915/gt/intel_renderstate.c | 2 +-
> .../gpu/drm/i915/gt/intel_ring_submission.c | 2 +-
> drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 8 +--
> drivers/gpu/drm/i915/gt/selftest_execlists.c | 18 +++---
> drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 15 ++---
> drivers/gpu/drm/i915/gt/selftest_lrc.c | 16 +++---
> .../drm/i915/gt/selftest_ring_submission.c | 2 +-
> drivers/gpu/drm/i915/gt/selftest_rps.c | 12 ++--
> .../gpu/drm/i915/gt/selftest_workarounds.c | 8 +--
> drivers/gpu/drm/i915/i915_cmd_parser.c | 4 +-
> drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
> drivers/gpu/drm/i915/i915_gem_gtt.h | 1 +
> drivers/gpu/drm/i915/i915_perf.c | 2 +-
> drivers/gpu/drm/i915/i915_vma.c | 55 ++++++++++++++-----
> drivers/gpu/drm/i915/i915_vma.h | 24 +++++++-
> drivers/gpu/drm/i915/i915_vma_types.h | 3 +-
> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 12 +++-
> drivers/gpu/drm/i915/selftests/i915_request.c | 20 +++----
> drivers/gpu/drm/i915/selftests/igt_spinner.c | 8 +--
> 37 files changed, 226 insertions(+), 159 deletions(-)
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-12-03 11:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:24 [Intel-gfx] [PATCH 0/3] Replace VT-d workaround with guard pages Tejas Upadhyay
2021-12-02 9:24 ` [Intel-gfx] [PATCH V2 1/3] drm/i915: Wrap all access to i915_vma.node.start|size Tejas Upadhyay
2021-12-03 10:14 ` Ramalingam C
2021-12-02 9:24 ` [Intel-gfx] [PATCH V2 2/3] drm/i915: Introduce guard pages to i915_vma Tejas Upadhyay
2021-12-03 10:54 ` Ramalingam C
2021-12-03 10:57 ` Ramalingam C
2021-12-02 9:24 ` [Intel-gfx] [PATCH V2 3/3] drm/i915: Refine VT-d scanout workaround Tejas Upadhyay
2021-12-03 11:05 ` Ramalingam C
2021-12-02 9:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Replace VT-d workaround with guard pages (rev2) Patchwork
2021-12-02 10:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-02 11:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-03 11:11 ` Ramalingam C [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-02 8:31 [Intel-gfx] [PATCH 0/3] Replace VT-d workaround with guard pages Tejas Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203111154.GF25851@intel.com \
--to=ramalingam.c@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.