From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 326B5C433EF for ; Fri, 3 Dec 2021 17:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q7UWxSULOw3BAy2AHgnjDPN6W4zRRo1fN8xq4V/lDx0=; b=NnjFx13HW4Tm+Z 44MHXwQdy+GJabuyKdPaIgMp+TzXL0yKQO14vOMf8O3BQMJdPG+w8GwjEznxM4t48pMYPYs+G9mCP AgxhuHF0mfannxkkkLnyRYKmZ7HKYhOcAO3Z6hfJh4bfZjISfahtyo/KyQ3fXw1CRo2kDukljKcfv dv2uI8bAQeKIdcePb+Iq5kdvsJQk9nHm/NhqgLKGUkEGzUqIKVoHsZkFFfZA0U8FPitr0FpSvpsEA z1pfJTxZOjYHq2c5eNZ+zC13VC0TYO2OvGfZxbDz38TeGvmhNnFyIX24ihDZUliAIhqTNh74jUoP3 76zWuKZjM+D36SRo6IvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtCZl-00Ggrw-Dh; Fri, 03 Dec 2021 17:42:25 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtCZi-00GgrK-9E for linux-arm-kernel@lists.infradead.org; Fri, 03 Dec 2021 17:42:24 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10187"; a="217042219" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="217042219" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 09:42:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="541696409" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 03 Dec 2021 09:42:17 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mtCZd-000Hrv-0t; Fri, 03 Dec 2021 17:42:17 +0000 Date: Sat, 4 Dec 2021 01:41:25 +0800 From: kernel test robot To: Qin Jian , robh+dt@kernel.org Cc: kbuild-all@lists.01.org, mturquette@baylibre.com, sboyd@kernel.org, tglx@linutronix.de, maz@kernel.org, p.zabel@pengutronix.de, linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver Message-ID: <202112040151.1DH0alac-lkp@intel.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211203_094222_370688_0B7BDD67 X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Qin, I love your patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [cannot apply to pza/reset/next robh/for-next tip/irq/core linus/master v5.16-rc3 next-20211203] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20211203-154345 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20211204/202112040151.1DH0alac-lkp@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/14961fb5913762db86b6816b325ef2e87cf4a319 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20211203-154345 git checkout 14961fb5913762db86b6816b325ef2e87cf4a319 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/irqchip/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/irqchip/irq-sp7021-intc.c: In function 'sp_intc_handle_ext_cascaded': >> drivers/irqchip/irq-sp7021-intc.c:160:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 160 | int ext_num = (int)irq_desc_get_handler_data(desc); | ^ drivers/irqchip/irq-sp7021-intc.c: In function 'sp_intc_irq_map': >> drivers/irqchip/irq-sp7021-intc.c:218:76: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 218 | irq_set_chained_handler_and_data(irq, sp_intc_handle_ext_cascaded, (void *)i); | ^ drivers/irqchip/irq-sp7021-intc.c: At top level: drivers/irqchip/irq-sp7021-intc.c:223:6: warning: no previous prototype for 'sp_intc_set_ext' [-Wmissing-prototypes] 223 | void sp_intc_set_ext(u32 hwirq, int ext_num) | ^~~~~~~~~~~~~~~ drivers/irqchip/irq-sp7021-intc.c:229:12: warning: no previous prototype for 'sp_intc_init_dt' [-Wmissing-prototypes] 229 | int __init sp_intc_init_dt(struct device_node *node, struct device_node *parent) | ^~~~~~~~~~~~~~~ vim +160 drivers/irqchip/irq-sp7021-intc.c 156 157 static void sp_intc_handle_ext_cascaded(struct irq_desc *desc) 158 { 159 struct irq_chip *chip = irq_desc_get_chip(desc); > 160 int ext_num = (int)irq_desc_get_handler_data(desc); 161 int hwirq; 162 163 chained_irq_enter(chip, desc); 164 165 while ((hwirq = sp_intc_get_ext_irq(ext_num)) >= 0) { 166 if (unlikely(IS_GPIO_INT(hwirq) && TEST_STATE(hwirq, _IS_ACTIVE))) { // WORKAROUND 167 ASSIGN_STATE(hwirq, _IS_ACTIVE, false); 168 sp_intc_assign_bit(hwirq, REG_INTR_POLARITY, TEST_STATE(hwirq, _IS_LOW)); 169 } else { 170 generic_handle_domain_irq(sp_intc.domain, hwirq); 171 } 172 } 173 174 chained_irq_exit(chip, desc); 175 } 176 177 #ifdef CONFIG_SMP 178 static int sp_intc_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force) 179 { 180 return -EINVAL; 181 } 182 #endif 183 184 static struct irq_chip sp_intc_chip = { 185 .name = "sp_intc", 186 .irq_ack = sp_intc_ack_irq, 187 .irq_mask = sp_intc_mask_irq, 188 .irq_unmask = sp_intc_unmask_irq, 189 .irq_set_type = sp_intc_set_type, 190 #ifdef CONFIG_SMP 191 .irq_set_affinity = sp_intc_set_affinity, 192 #endif 193 }; 194 195 static int sp_intc_irq_domain_map(struct irq_domain *domain, 196 unsigned int irq, irq_hw_number_t hwirq) 197 { 198 irq_set_chip_and_handler(irq, &sp_intc_chip, handle_level_irq); 199 irq_set_chip_data(irq, &sp_intc_chip); 200 irq_set_noprobe(irq); 201 202 return 0; 203 } 204 205 static const struct irq_domain_ops sp_intc_dm_ops = { 206 .xlate = irq_domain_xlate_twocell, 207 .map = sp_intc_irq_domain_map, 208 }; 209 210 static int sp_intc_irq_map(struct device_node *node, int i) 211 { 212 unsigned int irq; 213 214 irq = irq_of_parse_and_map(node, i); 215 if (!irq) 216 return -ENOENT; 217 > 218 irq_set_chained_handler_and_data(irq, sp_intc_handle_ext_cascaded, (void *)i); 219 220 return 0; 221 } 222 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3700547270801176061==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver Date: Sat, 04 Dec 2021 01:41:25 +0800 Message-ID: <202112040151.1DH0alac-lkp@intel.com> In-Reply-To: List-Id: --===============3700547270801176061== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Qin, I love your patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [cannot apply to pza/reset/next robh/for-next tip/irq/core linus/master v5.= 16-rc3 next-20211203] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Qin-Jian/Add-Sunplus-SP702= 1-SoC-Support/20211203-154345 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-n= ext config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20211204= /202112040151.1DH0alac-lkp(a)intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/14961fb5913762db86b6816b3= 25ef2e87cf4a319 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qin-Jian/Add-Sunplus-SP7021-SoC-Su= pport/20211203-154345 git checkout 14961fb5913762db86b6816b325ef2e87cf4a319 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash drivers/irqchip/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/irqchip/irq-sp7021-intc.c: In function 'sp_intc_handle_ext_casca= ded': >> drivers/irqchip/irq-sp7021-intc.c:160:23: warning: cast from pointer to = integer of different size [-Wpointer-to-int-cast] 160 | int ext_num =3D (int)irq_desc_get_handler_data(desc); | ^ drivers/irqchip/irq-sp7021-intc.c: In function 'sp_intc_irq_map': >> drivers/irqchip/irq-sp7021-intc.c:218:76: warning: cast to pointer from = integer of different size [-Wint-to-pointer-cast] 218 | irq_set_chained_handler_and_data(irq, sp_intc_handle_ext= _cascaded, (void *)i); | = ^ drivers/irqchip/irq-sp7021-intc.c: At top level: drivers/irqchip/irq-sp7021-intc.c:223:6: warning: no previous prototype = for 'sp_intc_set_ext' [-Wmissing-prototypes] 223 | void sp_intc_set_ext(u32 hwirq, int ext_num) | ^~~~~~~~~~~~~~~ drivers/irqchip/irq-sp7021-intc.c:229:12: warning: no previous prototype= for 'sp_intc_init_dt' [-Wmissing-prototypes] 229 | int __init sp_intc_init_dt(struct device_node *node, struct devi= ce_node *parent) | ^~~~~~~~~~~~~~~ vim +160 drivers/irqchip/irq-sp7021-intc.c 156 = 157 static void sp_intc_handle_ext_cascaded(struct irq_desc *desc) 158 { 159 struct irq_chip *chip =3D irq_desc_get_chip(desc); > 160 int ext_num =3D (int)irq_desc_get_handler_data(desc); 161 int hwirq; 162 = 163 chained_irq_enter(chip, desc); 164 = 165 while ((hwirq =3D sp_intc_get_ext_irq(ext_num)) >=3D 0) { 166 if (unlikely(IS_GPIO_INT(hwirq) && TEST_STATE(hwirq, _IS_ACTIVE)))= { // WORKAROUND 167 ASSIGN_STATE(hwirq, _IS_ACTIVE, false); 168 sp_intc_assign_bit(hwirq, REG_INTR_POLARITY, TEST_STATE(hwirq, _I= S_LOW)); 169 } else { 170 generic_handle_domain_irq(sp_intc.domain, hwirq); 171 } 172 } 173 = 174 chained_irq_exit(chip, desc); 175 } 176 = 177 #ifdef CONFIG_SMP 178 static int sp_intc_set_affinity(struct irq_data *d, const struct cpu= mask *mask, bool force) 179 { 180 return -EINVAL; 181 } 182 #endif 183 = 184 static struct irq_chip sp_intc_chip =3D { 185 .name =3D "sp_intc", 186 .irq_ack =3D sp_intc_ack_irq, 187 .irq_mask =3D sp_intc_mask_irq, 188 .irq_unmask =3D sp_intc_unmask_irq, 189 .irq_set_type =3D sp_intc_set_type, 190 #ifdef CONFIG_SMP 191 .irq_set_affinity =3D sp_intc_set_affinity, 192 #endif 193 }; 194 = 195 static int sp_intc_irq_domain_map(struct irq_domain *domain, 196 unsigned int irq, irq_hw_number_t hwirq) 197 { 198 irq_set_chip_and_handler(irq, &sp_intc_chip, handle_level_irq); 199 irq_set_chip_data(irq, &sp_intc_chip); 200 irq_set_noprobe(irq); 201 = 202 return 0; 203 } 204 = 205 static const struct irq_domain_ops sp_intc_dm_ops =3D { 206 .xlate =3D irq_domain_xlate_twocell, 207 .map =3D sp_intc_irq_domain_map, 208 }; 209 = 210 static int sp_intc_irq_map(struct device_node *node, int i) 211 { 212 unsigned int irq; 213 = 214 irq =3D irq_of_parse_and_map(node, i); 215 if (!irq) 216 return -ENOENT; 217 = > 218 irq_set_chained_handler_and_data(irq, sp_intc_handle_ext_cascaded, = (void *)i); 219 = 220 return 0; 221 } 222 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============3700547270801176061==--